linux.git/net/irda/irttp.c, branch v4.13

irda: Convert function pointer arrays and uses to const

2014-12-10T20:33:16+00:00

Making things const is a good thing.

(x86-64 defconfig with all irda)
$ size net/irda/built-in.o*
   text	   data	    bss	    dec	    hex	filename
 109276	   1868	    244	 111388	  1b31c	net/irda/built-in.o.new
 108828	   2316	    244	 111388	  1b31c	net/irda/built-in.o.old

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

irda: Convert IRDA_DEBUG to pr_debug

2014-11-12T18:56:41+00:00

Use the normal kernel debugging mechanism which also
enables dynamic_debug at the same time.

Other miscellanea:

o Remove sysctl for irda_debug
o Remove function tracing like uses (use ftrace instead)
o Coalesce formats
o Realign arguments
o Remove unnecessary OOM messages

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

irda: Remove IRDA_ logging macros

2014-11-11T23:11:00+00:00

And use the more common mechanisms directly.

Other miscellanea:

o Coalesce formats
o Add missing newlines
o Realign arguments
o Remove unnecessary OOM message logging as
  there's a generic stack dump already on OOM.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net/irda: fixed style issues in irttp

2013-07-20T00:34:40+00:00

Applied error fixes suggested by checpatch.pl

Signed-off-by: Dragos Foianu 
Signed-off-by: David S. Miller

irda: irttp: fix memory leak in irttp_open_tsap() error path

2012-11-28T16:25:29+00:00

Cleanup the memory we allocated earlier in irttp_open_tsap() when we hit
this error path. The leak goes back to at least 1da177e4
("Linux-2.6.12-rc2").

Discovered with Trinity (the syscall fuzzer).

Signed-off-by: Tommi Rantala 
Signed-off-by: David S. Miller

silence some noisy printks in irda

2012-10-04T19:53:48+00:00

Fuzzing causes these printks to spew constantly.
Changing them to DEBUG statements is consistent with other usage in the file,
and makes them disappear when CONFIG_IRDA_DEBUG is disabled.

Signed-off-by: Dave Jones 
Signed-off-by: David S. Miller

irttp: Use kmemdup rather than duplicating its implementation

2011-11-21T20:02:17+00:00

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer 
Signed-off-by: David S. Miller

net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules

2011-10-31T23:30:30+00:00

These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.

Signed-off-by: Paul Gortmaker

net: Remove casts of void *

2011-06-17T03:19:27+00:00

Unnecessary casts of void * clutter the code.

These are the remainder casts after several specific
patches to remove netdev_priv and dev_priv.

Done via coccinelle script:

$ cat cast_void_pointer.cocci
@@
type T;
T *pt;
void *pv;
@@

- pt = (T *)pv;
+ pt = pv;

Signed-off-by: Joe Perches 
Acked-by: Paul Moore 
Signed-off-by: David S. Miller

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi