linux.git/net/ipv6/netfilter, branch v2.6.39 Linux kernel source tree netfilter: IPv6: initialize TOS field in REJECT target module 2011-05-10T07:55:44+00:00 Fernando Luis Vazquez Cao fernando@oss.ntt.co.jp 2011-05-10T07:55:44+00:00 4319cc0cf5bb894b7368008cdf6dd20eb8868018 The IPv6 header is not zeroed out in alloc_skb so we must initialize it properly unless we want to see IPv6 packets with random TOS fields floating around. The current implementation resets the flow label but this could be changed if deemed necessary. We stumbled upon this issue when trying to apply a mangle rule to the RST packet generated by the REJECT target module. Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> 
The IPv6 header is not zeroed out in alloc_skb so we must initialize
it properly unless we want to see IPv6 packets with random TOS fields
floating around. The current implementation resets the flow label
but this could be changed if deemed necessary.

We stumbled upon this issue when trying to apply a mangle rule to
the RST packet generated by the REJECT target module.

Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Fix common misspellings 2011-03-31T14:26:23+00:00 Lucas De Marchi lucas.demarchi@profusion.mobi 2011-03-31T01:57:33+00:00 25985edcedea6396277003854657b5f3cb31a628 Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi> 
Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
netfilter: xtables: fix reentrancy 2011-03-20T14:40:06+00:00 Eric Dumazet eric.dumazet@gmail.com 2011-03-20T14:40:06+00:00 db856674ac69e31946e56085239757cca3f7655f commit f3c5c1bfd4308 (make ip_tables reentrant) introduced a race in handling the stackptr restore, at the end of ipt_do_table() We should do it before the call to xt_info_rdunlock_bh(), or we allow cpu preemption and another cpu overwrites stackptr of original one. A second fix is to change the underflow test to check the origptr value instead of 0 to detect underflow, or else we allow a jump from different hooks. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Patrick McHardy <kaber@trash.net> 
commit f3c5c1bfd4308 (make ip_tables reentrant) introduced a race in
handling the stackptr restore, at the end of ipt_do_table()

We should do it before the call to xt_info_rdunlock_bh(), or we allow
cpu preemption and another cpu overwrites stackptr of original one.

A second fix is to change the underflow test to check the origptr value
instead of 0 to detect underflow, or else we allow a jump from different
hooks.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6 2011-03-15T20:03:27+00:00 David S. Miller davem@davemloft.net 2011-03-15T20:03:27+00:00 31111c26d976ca0f298312f08e44cdb078005b03 Conflicts: Documentation/feature-removal-schedule.txt 
Conflicts:
	Documentation/feature-removal-schedule.txt
ipv6: netfilter: ip6_tables: fix infoleak to userspace 2011-03-15T12:37:13+00:00 Vasiliy Kulikov segoon@openwall.com 2011-03-15T12:37:13+00:00 6a8ab060779779de8aea92ce3337ca348f973f54 Structures ip6t_replace, compat_ip6t_replace, and xt_get_revision are copied from userspace. Fields of these structs that are zero-terminated strings are not checked. When they are used as argument to a format string containing "%s" in request_module(), some sensitive information is leaked to userspace via argument of spawned modprobe process. The first bug was introduced before the git epoch; the second was introduced in 3bc3fe5e (v2.6.25-rc1); the third is introduced by 6b7d31fc (v2.6.15-rc1). To trigger the bug one should have CAP_NET_ADMIN. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Patrick McHardy <kaber@trash.net> 
Structures ip6t_replace, compat_ip6t_replace, and xt_get_revision are
copied from userspace.  Fields of these structs that are
zero-terminated strings are not checked.  When they are used as argument
to a format string containing "%s" in request_module(), some sensitive
information is leaked to userspace via argument of spawned modprobe
process.

The first bug was introduced before the git epoch;  the second was
introduced in 3bc3fe5e (v2.6.25-rc1);  the third is introduced by
6b7d31fc (v2.6.15-rc1).  To trigger the bug one should have
CAP_NET_ADMIN.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net: Put fl6_* macros to struct flowi6 and use them again. 2011-03-12T23:08:55+00:00 David S. Miller davem@davemloft.net 2011-03-12T21:36:19+00:00 1958b856c1a59c0f1e892b92debb8c9fe4f364dc Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>
ipv6: Convert to use flowi6 where applicable. 2011-03-12T23:08:54+00:00 David S. Miller davem@davemloft.net 2011-03-12T21:22:43+00:00 4c9483b2fb5d2548c3cc1fe03cdd4484ceeb5d1c Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Make flowi ports AF dependent. 2011-03-12T23:08:46+00:00 David S. Miller davem@davemloft.net 2011-03-12T05:43:55+00:00 6281dcc94a96bd73017b2baa8fa83925405109ef Create two sets of port member accessors, one set prefixed by fl4_* and the other prefixed by fl6_* This will let us to create AF optimal flow instances. It will work because every context in which we access the ports, we have to be fully aware of which AF the flowi is anyways. Signed-off-by: David S. Miller <davem@davemloft.net> 
Create two sets of port member accessors, one set prefixed by fl4_*
and the other prefixed by fl6_*

This will let us to create AF optimal flow instances.

It will work because every context in which we access the ports,
we have to be fully aware of which AF the flowi is anyways.

Signed-off-by: David S. Miller <davem@davemloft.net>
net: Put flowi_* prefix on AF independent members of struct flowi 2011-03-12T23:08:44+00:00 David S. Miller davem@davemloft.net 2011-03-12T05:29:39+00:00 1d28f42c1bd4bb2363d88df74d0128b4da135b4a I intend to turn struct flowi into a union of AF specific flowi structs. There will be a common structure that each variant includes first, much like struct sock_common. This is the first step to move in that direction. Signed-off-by: David S. Miller <davem@davemloft.net> 
I intend to turn struct flowi into a union of AF specific flowi
structs.  There will be a common structure that each variant includes
first, much like struct sock_common.

This is the first step to move in that direction.

Signed-off-by: David S. Miller <davem@davemloft.net>
xfrm: Return dst directly from xfrm_lookup() 2011-03-02T21:27:41+00:00 David S. Miller davem@davemloft.net 2011-03-02T21:27:41+00:00 452edd598f60522c11f7f88fdbab27eb36509d1a Instead of on the stack. Signed-off-by: David S. Miller <davem@davemloft.net> 
Instead of on the stack.

Signed-off-by: David S. Miller <davem@davemloft.net>