linux.git/net/ipv6/ipcomp6.c, branch v2.6.33 Linux kernel source tree ipcomp: Avoid duplicate calls to ipcomp_destroy 2010-02-16T22:53:24+00:00 Herbert Xu herbert@gondor.apana.org.au 2010-02-15T19:24:30+00:00 10e7454ed7a2da39f1f6255f63d7df27ab4bb67f When ipcomp_tunnel_attach fails we will call ipcomp_destroy twice. This may lead to double-frees on certain structures. As there is no reason to explicitly call ipcomp_destroy, this patch removes it from ipcomp*.c and lets the standard xfrm_state destruction take place. This is based on the discovery and patch by Alexey Dobriyan. Tested-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> 
When ipcomp_tunnel_attach fails we will call ipcomp_destroy twice.
This may lead to double-frees on certain structures.

As there is no reason to explicitly call ipcomp_destroy, this patch
removes it from ipcomp*.c and lets the standard xfrm_state destruction
take place.

This is based on the discovery and patch by Alexey Dobriyan.

Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: constify struct inet6_protocol 2009-09-15T00:03:05+00:00 Alexey Dobriyan adobriyan@gmail.com 2009-09-14T12:22:28+00:00 41135cc836a1abeb12ca1416bdb29e87ad021153 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ipv6: Use correct data types for ICMPv6 type and code 2009-06-23T11:31:07+00:00 Brian Haley brian.haley@hp.com 2009-06-23T11:31:07+00:00 d5fdd6babcfc2b0e6a8da1acf492a69fb54b4c47 Change all the code that deals directly with ICMPv6 type and code values to use u8 instead of a signed int as that's the actual data type. Signed-off-by: Brian Haley <brian.haley@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Change all the code that deals directly with ICMPv6 type and code
values to use u8 instead of a signed int as that's the actual data
type.

Signed-off-by: Brian Haley <brian.haley@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
netns xfrm: state lookup in netns 2008-11-26T01:30:50+00:00 Alexey Dobriyan adobriyan@gmail.com 2008-11-26T01:30:50+00:00 221df1ed33c9284fc7a6f6e47ca7f8d5f3665d43 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
netns xfrm: add struct xfrm_state::xs_net 2008-11-26T01:15:16+00:00 Alexey Dobriyan adobriyan@gmail.com 2008-11-26T01:15:16+00:00 673c09be457bb23aa0eaaa79804cbb342210d195 To avoid unnecessary complications with passing netns around. * set once, very early after allocating * once set, never changes For a while create every xfrm_state in init_net. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
To avoid unnecessary complications with passing netns around.

* set once, very early after allocating
* once set, never changes

For a while create every xfrm_state in init_net.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: replace %p6 with %pI6 2008-10-29T19:52:50+00:00 Harvey Harrison harvey.harrison@gmail.com 2008-10-29T19:52:50+00:00 5b095d98928fdb9e3b75be20a54b7a6cbf6ca9ad Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: replace uses of NIP6_FMT with %p6 2008-10-29T06:02:31+00:00 Harvey Harrison harvey.harrison@gmail.com 2008-10-28T23:09:23+00:00 0c6ce78abf6e228d44c3840edb8a4ae0c1299825 Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ipcomp: Fix warnings after ipcomp consolidation. 2008-07-27T10:59:24+00:00 David S. Miller davem@davemloft.net 2008-07-27T10:59:24+00:00 2c3abab7c95295f319dc8899b74cbd60140fcdfb net/ipv4/ipcomp.c: In function ‘ipcomp4_init_state’: net/ipv4/ipcomp.c:109: warning: unused variable ‘calg_desc’ net/ipv4/ipcomp.c:108: warning: unused variable ‘ipcd’ net/ipv4/ipcomp.c:107: warning: ‘err’ may be used uninitialized in this function net/ipv6/ipcomp6.c: In function ‘ipcomp6_init_state’: net/ipv6/ipcomp6.c:139: warning: unused variable ‘calg_desc’ net/ipv6/ipcomp6.c:138: warning: unused variable ‘ipcd’ net/ipv6/ipcomp6.c:137: warning: ‘err’ may be used uninitialized in this function Signed-off-by: David S. Miller <davem@davemloft.net> 
net/ipv4/ipcomp.c: In function ‘ipcomp4_init_state’:
net/ipv4/ipcomp.c:109: warning: unused variable ‘calg_desc’
net/ipv4/ipcomp.c:108: warning: unused variable ‘ipcd’
net/ipv4/ipcomp.c:107: warning: ‘err’ may be used uninitialized in this function
net/ipv6/ipcomp6.c: In function ‘ipcomp6_init_state’:
net/ipv6/ipcomp6.c:139: warning: unused variable ‘calg_desc’
net/ipv6/ipcomp6.c:138: warning: unused variable ‘ipcd’
net/ipv6/ipcomp6.c:137: warning: ‘err’ may be used uninitialized in this function

Signed-off-by: David S. Miller <davem@davemloft.net>
ipsec: ipcomp - Merge IPComp implementations 2008-07-25T09:54:40+00:00 Herbert Xu herbert@gondor.apana.org.au 2008-07-25T09:54:40+00:00 6fccab671f2f0a24b799f29a4ec878f62d34656c This patch merges the IPv4/IPv6 IPComp implementations since most of the code is identical. As a result future enhancements will no longer need to be duplicated. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch merges the IPv4/IPv6 IPComp implementations since most
of the code is identical.  As a result future enhancements will no
longer need to be duplicated.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Remove unnecessary inclusions of asm/semaphore.h 2008-04-19T02:15:50+00:00 Matthew Wilcox matthew@wil.cx 2008-04-19T02:15:50+00:00 5f090dcb4d4fff373ce7165bce4ba5e87534d50a None of these files use any of the functionality promised by asm/semaphore.h. It's possible that they rely on it dragging in some unrelated header file, but I can't build all these files, so we'll have fix any build failures as they come up. Signed-off-by: Matthew Wilcox <willy@linux.intel.com> 
None of these files use any of the functionality promised by
asm/semaphore.h.  It's possible that they rely on it dragging in some
unrelated header file, but I can't build all these files, so we'll have
fix any build failures as they come up.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>