linux.git/net/ipv4/tcp_input.c, branch v2.6.30

tcp: Fix tcp_prequeue() to get correct rto_min value

2009-05-04T18:11:01+00:00

tcp_prequeue() refers to the constant value (TCP_RTO_MIN) regardless of
the actual value might be tuned. The following patches fix this and make
tcp_prequeue get the actual value returns from tcp_rto_min().

Signed-off-by: Satoru SATOH 
Signed-off-by: David S. Miller

tcp: fix >2 iw selection

2009-04-14T09:08:53+00:00

A long-standing feature in tcp_init_metrics() is such that
any of its goto reset prevents call to tcp_init_cwnd().

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: Discard segments that ack data not yet sent

2009-03-23T04:49:57+00:00

Discard incoming packets whose ack field iincludes data not yet sent.
This is consistent with RFC 793 Section 3.9.

Change tcp_ack() to distinguish between too-small and too-large ack
field values.  Keep segments with too-large ack fields out of the fast
path, and change slow path to discard them.

Reported-by:  Oliver Zheng 
Signed-off-by: John Dykstra 
Signed-off-by: David S. Miller

net/*: use linux/kernel.h swap()

2009-03-21T20:36:17+00:00

tcp_sack_swap seems unnecessary so I pushed swap to the caller.
Also removed comment that seemed then pointless, and added include
when not already there. Compile tested.

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: simplify tcp_current_mss

2009-03-16T03:09:54+00:00

There's very little need for most of the callsites to get
tp->xmit_goal_size updated. That will cost us divide as is,
so slice the function in two. Also, the only users of the
tp->xmit_goal_size are directly behind tcp_current_mss(),
so there's no need to store that variable into tcp_sock
at all! The drop of xmit_goal_size currently leaves 16-bit
hole and some reorganization would again be necessary to
change that (but I'm aiming to fill that hole with u16
xmit_goal_size_segs to cache the results of the remaining
divide to get that tso on regression).

Bring xmit_goal_size parts into tcp.c

Signed-off-by: Ilpo Järvinen 
Cc: Evgeniy Polyakov 
Cc: Ingo Molnar 
Signed-off-by: David S. Miller

tcp: don't check mtu probe completion in the loop

2009-03-16T03:09:53+00:00

It seems that no variables clash such that we couldn't do
the check just once later on. Therefore move it.

Also kill dead obvious comment, dead argument and add
unlikely since this mtu probe does not happen too often.

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: consolidate paws check

2009-03-16T03:09:52+00:00

Wow, it was quite tricky to merge that stream of negations
but I think I finally got it right:

check & replace_ts_recent:
(s32)(rcv_tsval - ts_recent) >= 0                  => 0
(s32)(ts_recent - rcv_tsval) <= 0                  => 0

discard:
(s32)(ts_recent - rcv_tsval)  > TCP_PAWS_WINDOW    => 1
(s32)(ts_recent - rcv_tsval) <= TCP_PAWS_WINDOW    => 0

I toggled the return values of tcp_paws_check around since
the old encoding added yet-another negation making tracking
of truth-values really complicated.

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: kill dead end_seq variable in clean_rtx_queue

2009-03-16T03:09:51+00:00

I've already forgotten what for this was necessary, anyway
it's no longer used (if it ever was).

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: remove pointless .dsack/.num_sacks code

2009-03-16T03:09:51+00:00

In the pure assignment case, the earlier zeroing is
still in effect.

David S. Miller raised concerns if the ifs are there to avoid
dirtying cachelines. I came to these conclusions:

> We'll be dirty it anyway (now that I check), the first "real" statement
> in tcp_rcv_established is:
>
>       tp->rx_opt.saw_tstamp = 0;
>
> ...that'll land on the same dword. :-/
>
> I suppose the blocks are there just because they had more complexity
> inside when they had to calculate the eff_sacks too (maybe it would
> have been better to just remove them in that drop-patch so you would
> have had less head-ache :-)).

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

tcp: tcp_init_wl / tcp_update_wl argument cleanup

2009-03-03T06:42:02+00:00

The above functions from include/net/tcp.h have been defined with an
argument that they never use. The argument is 'u32 ack' which is never
used inside the function body, and thus it can be removed. The rest of
the patch involves the necessary changes to the function callers of the
above two functions.

Signed-off-by: Hantzis Fotis 
Signed-off-by: David S. Miller