linux.git/net/ipv4/netfilter, branch v2.6.18 Linux kernel source tree [NETFILTER]: arp_tables: fix table locking in arpt_do_table 2006-08-22T21:33:56+00:00 Patrick McHardy kaber@trash.net 2006-08-21T22:31:08+00:00 e0b7cde9975e17a61b4511c7822803dfb7210011 table->private might change because of ruleset changes, don't use it without holding the lock. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
table->private might change because of ruleset changes, don't use it
without holding the lock.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: ip_tables: fix table locking in ipt_do_table 2006-08-18T01:13:53+00:00 Patrick McHardy kaber@trash.net 2006-08-18T01:13:53+00:00 8311731afc439f508ab4d759edadedae75afb73e table->private might change because of ruleset changes, don't use it without holding the lock. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
table->private might change because of ruleset changes, don't use it without
holding the lock.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: ctnetlink: fix deadlock in table dumping 2006-08-18T01:12:38+00:00 Patrick McHardy kaber@trash.net 2006-08-18T01:12:38+00:00 d205dc40798d97d63ad348bfaf7394f445d152d4 ip_conntrack_put must not be called while holding ip_conntrack_lock since destroy_conntrack takes it again. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
ip_conntrack_put must not be called while holding ip_conntrack_lock
since destroy_conntrack takes it again.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: ulog: fix panic on SMP kernels 2006-08-14T01:57:54+00:00 Mark Huang mlhuang@cs.princeton.edu 2006-08-14T01:57:54+00:00 dcb7cd97f133f7cfbd181149a1e60215a869f895 Fix kernel panic on various SMP machines. The culprit is a null ub->skb in ulog_send(). If ulog_timer() has already been scheduled on one CPU and is spinning on the lock, and ipt_ulog_packet() flushes the queue on another CPU by calling ulog_send() right before it exits, there will be no skbuff when ulog_timer() acquires the lock and calls ulog_send(). Cancelling the timer in ulog_send() doesn't help because it has already been scheduled and is running on the first CPU. Similar problem exists in ebt_ulog.c and nfnetlink_log.c. Signed-off-by: Mark Huang <mlhuang@cs.princeton.edu> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Fix kernel panic on various SMP machines. The culprit is a null
ub->skb in ulog_send(). If ulog_timer() has already been scheduled on
one CPU and is spinning on the lock, and ipt_ulog_packet() flushes the
queue on another CPU by calling ulog_send() right before it exits,
there will be no skbuff when ulog_timer() acquires the lock and calls
ulog_send(). Cancelling the timer in ulog_send() doesn't help because
it has already been scheduled and is running on the first CPU.

Similar problem exists in ebt_ulog.c and nfnetlink_log.c.

Signed-off-by: Mark Huang <mlhuang@cs.princeton.edu>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: {arp,ip,ip6}_tables: proper error recovery in init path 2006-08-14T01:57:28+00:00 Patrick McHardy kaber@trash.net 2006-08-14T01:57:28+00:00 0eff66e625306a794ecba4b29ed12f7a147ce219 Neither of {arp,ip,ip6}_tables cleans up behind itself when something goes wrong during initialization. Noticed by Rennie deGraaf <degraaf@cpsc.ucalgary.ca> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Neither of {arp,ip,ip6}_tables cleans up behind itself when something goes
wrong during initialization.

Noticed by Rennie deGraaf <degraaf@cpsc.ucalgary.ca>

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: xt_hashlimit: fix limit off-by-one 2006-08-14T01:06:02+00:00 Patrick McHardy kaber@trash.net 2006-08-14T01:06:02+00:00 1c7628bd7a458faf7c96ef521f6d3a5ea9b106b8 Hashlimit doesn't account for the first packet, which is inconsistent with the limit match. Reported by ryan.castellucci@gmail.com, netfilter bugzilla #500. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Hashlimit doesn't account for the first packet, which is inconsistent
with the limit match.

Reported by ryan.castellucci@gmail.com, netfilter bugzilla #500.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: xt_hashlimit/xt_string: missing string validation 2006-08-02T20:38:29+00:00 Patrick McHardy kaber@trash.net 2006-08-01T06:47:31+00:00 3ab720881b6e36bd5190a3a11cee8d8d067c4ad7 The hashlimit table name and the textsearch algorithm need to be terminated, the textsearch pattern length must not exceed the maximum size. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
The hashlimit table name and the textsearch algorithm need to be
terminated, the textsearch pattern length must not exceed the
maximum size.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: SIP helper: expect RTP streams in both directions 2006-08-02T20:38:28+00:00 Patrick McHardy kaber@trash.net 2006-08-01T06:46:18+00:00 b10866fd7dd9ae9b8dd03646d28702a76d624474 Since we don't know in which direction the first packet will arrive, we need to create one expectation for each direction, which is currently prevented by max_expected beeing set to 1. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since we don't know in which direction the first packet will arrive, we
need to create one expectation for each direction, which is currently
prevented by max_expected beeing set to 1.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: SNMP NAT: fix byteorder confusion 2006-07-25T05:53:35+00:00 Patrick McHardy kaber@trash.net 2006-07-25T05:53:35+00:00 8cf8fb5687bb37737ea419a0b2143aab49295779 Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NETFILTER]: conntrack: fix SYSCTL=n compile 2006-07-25T05:53:12+00:00 Adrian Bunk bunk@stusta.de 2006-07-25T05:53:12+00:00 72b558235950538da8bf5a8de746a194831c6fe6 Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>