linux.git/net/ipv4/ipmr.c, branch v2.6.38

net: Support compat SIOCGETVIFCNT ioctl in ipv4.

2011-02-04T01:24:28+00:00

Signed-off-by: David S. Miller

net: Fix bug in compat SIOCGETSGCNT handling.

2011-02-04T01:21:31+00:00

Commit 709b46e8d90badda1898caea50483c12af178e96 ("net: Add compat
ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT") added the
correct plumbing to handle SIOCGETSGCNT properly.

However, whilst definiting a proper "struct compat_sioc_sg_req" it
isn't actually used in ipmr_compat_ioctl().

Correct this oversight.

Signed-off-by: David S. Miller

net: Add compat ioctl support for the ipv4 multicast ioctl SIOCGETSGCNT

2011-01-30T09:14:38+00:00

SIOCGETSGCNT is not a unique ioctl value as it it maps tio SIOCPROTOPRIVATE +1,
which unfortunately means the existing infrastructure for compat networking
ioctls is insufficient.  A trivial compact ioctl implementation would conflict
with:

SIOCAX25ADDUID
SIOCAIPXPRISLT
SIOCGETSGCNT_IN6
SIOCGETSGCNT
SIOCRSSCAUSE
SIOCX25SSUBSCRIP
SIOCX25SDTEFACILITIES

To make this work I have updated the compat_ioctl decode path to mirror the
the normal ioctl decode path.  I have added an ipv4 inet_compat_ioctl function
so that I can have ipv4 specific compat ioctls.   I have added a compat_ioctl
function into struct proto so I can break out ioctls by which kind of ip socket
I am using.  I have added a compat_raw_ioctl function because SIOCGETSGCNT only
works on raw sockets.  I have added a ipmr_compat_ioctl that mirrors the normal
ipmr_ioctl.

This was necessary because unfortunately the struct layout for the SIOCGETSGCNT
has unsigned longs in it so changes between 32bit and 64bit kernels.

This change was sufficient to run a 32bit ip multicast routing daemon on a
64bit kernel.

Reported-by: Bill Fenner 
Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

net: use the macros defined for the members of flowi

2010-11-17T20:27:45+00:00

Use the macros defined for the members of flowi to clean the code up.

Signed-off-by: Changli Gao 
Signed-off-by: David S. Miller

ipv4: Make rt->fl.iif tests lest obscure.

2010-11-12T01:07:48+00:00

When we test rt->fl.iif against zero, we're seeing if it's
an output or an input route.

Make that explicit with some helper functions.

Signed-off-by: David S. Miller

ipmr: cleanups

2010-10-04T04:50:53+00:00

Various code style cleanups

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipmr: RCU protection for mfc_cache_array

2010-10-04T04:50:53+00:00

Use RCU & RTNL protection for mfc_cache_array[]

ipmr_cache_find() is called under rcu_read_lock();

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipmr: RCU conversion of mroute_sk

2010-10-04T04:50:52+00:00

Use RCU and RTNL to protect (struct mr_table)->mroute_sk

Readers use RCU, writers use RTNL.

ip_ra_control() already use an RCU grace period before
ip_ra_destroy_rcu(), so we dont need synchronize_rcu() in
mrtsock_destruct()

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipmr: __pim_rcv() is called under rcu_read_lock

2010-10-04T04:50:52+00:00

No need to get a reference on reg_dev and release it, we are in a
rcu_read_lock() protected section.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipv4: ip_ptr cleanups

2010-09-16T05:06:05+00:00

dev->ip_ptr is protected by rtnl and rcu.

Yet some places dont use appropriate primitives and/or locking rules.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller