linux.git/net/ipv4/ipip.c, branch v2.6.29

net: fix tunnels in netns after ndo_ changes

2008-11-24T01:26:26+00:00

dev_net_set() should be the very first thing after alloc_netdev().

"ndo_" changes turned simple assignment (which is OK to do before netns
assignment) into quite non-trivial operation (which is not OK, init_net was
used). This leads to incomplete initialisation of tunnel device in netns.

BUG: unable to handle kernel NULL pointer dereference at 00000004
IP: [] ip6_tnl_exit_net+0x37/0x4f
*pde = 00000000 
Oops: 0000 [#1] PREEMPT DEBUG_PAGEALLOC
last sysfs file: /sys/class/net/lo/operstate

Pid: 10, comm: netns Not tainted (2.6.28-rc6 #1) 
EIP: 0060:[] EFLAGS: 00010246 CPU: 0
EIP is at ip6_tnl_exit_net+0x37/0x4f
EAX: 00000000 EBX: 00000020 ECX: 00000000 EDX: 00000003
ESI: c5caef30 EDI: c782bbe8 EBP: c7909f50 ESP: c7909f48
 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
Process netns (pid: 10, ti=c7908000 task=c7905780 task.ti=c7908000)
Stack:
 c03e75e0 c7390bc8 c7909f60 c0245448 c7390bd8 c7390bf0 c7909fa8 c012577a
 00000000 00000002 00000000 c0125736 c782bbe8 c7909f90 c0308fe3 c782bc04
 c7390bd4 c0245406 c084b718 c04f0770 c03ad785 c782bbe8 c782bc04 c782bc0c
Call Trace:
 [] ? cleanup_net+0x42/0x82
 [] ? run_workqueue+0xd6/0x1ae
 [] ? run_workqueue+0x92/0x1ae
 [] ? schedule+0x275/0x285
 [] ? cleanup_net+0x0/0x82
 [] ? worker_thread+0x81/0x8d
 [] ? autoremove_wake_function+0x0/0x33
 [] ? worker_thread+0x0/0x8d
 [] ? kthread+0x39/0x5e
 [] ? kthread+0x0/0x5e
 [] ? kernel_thread_helper+0x7/0x10
Code: db e8 05 ff ff ff 89 c6 e8 dc 04 f6 ff eb 08 8b 40 04 e8 38 89 f5 ff 8b 44 9e 04 85 c0 75 f0 43 83 fb 20 75 f2 8b 86 84 00 00 00 <8b> 40 04 e8 1c 89 f5 ff e8 98 04 f6 ff 89 f0 e8 f8 63 e6 ff 5b 
EIP: [] ip6_tnl_exit_net+0x37/0x4f SS:ESP 0068:c7909f48
---[ end trace 6c2f2328fccd3e0c ]---

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

ipip: convert to net_device_ops

2008-11-21T04:33:21+00:00

Convert to network device ops. Needed to change to directly call
the init routine since two sides share same ops.  In the process
found by inspection a device ref count leak if register_netdevice failed.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: clean up net/ipv4/ipip.c raw.c tcp.c tcp_minisocks.c tcp_yeah.c xfrm4_policy.c

2008-11-03T08:24:34+00:00

Signed-off-by: Jianjun Kong 
Signed-off-by: David S. Miller

net: Rationalise email address: Network Specific Parts

2008-10-14T02:01:08+00:00

Clean up the various different email addresses of mine listed in the code
to a single current and valid address. As Dave says his network merges
for 2.6.28 are now done this seems a good point to send them in where
they won't risk disrupting real changes.

Signed-off-by: Alan Cox 
Signed-off-by: David S. Miller

net: remove CVS keywords

2008-06-12T04:00:38+00:00

This patch removes CVS keywords that weren't updated for a long time
from comments.

Signed-off-by: Adrian Bunk 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2008-05-26T06:26:10+00:00

Conflicts:

	drivers/net/cpmac.c
	net/mac80211/mlme.c

net: The world is not perfect patch.

2008-05-22T00:47:54+00:00

  Unless there will be any objection here, I suggest consider the
following patch which simply removes the code for the
-DI_WISH_WORLD_WERE_PERFECT in the three methods which use it.

The compilation errors we get when using -DI_WISH_WORLD_WERE_PERFECT
show that this code was not built and not used for really a long time.

Signed-off-by: Rami Rosen 
Signed-off-by: David S. Miller

ipip: Use on-device stats instead of private ones.

2008-05-21T21:15:16+00:00

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

[IPIP]: Allow to create IPIP tunnels in net namespaces.

2008-04-16T08:06:18+00:00

Set the proper net before calling register_netdev and disable 
the tunnel device netns changing.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

[IPIP]: Use proper net in (mostly) routing calls.

2008-04-16T08:05:57+00:00

There are some ip_route_output_key() calls in there that require
a proper net so give one to them.

Besides - give a proper net to a single __get_dev_by_index call 
in ipip_tunnel_bind_dev().

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller