linux.git/net/ipv4/ipconfig.c, branch v2.6.23

[IPCONFIG]: ip_auto_config fix

2007-08-14T05:51:59+00:00

The following commandline:

 root=/dev/mtdblock6 rw rootfstype=jffs2 ip=192.168.1.10:::255.255.255.0:localhost.localdomain:eth1:off console=ttyS0,115200

makes ip_auto_config fall back to DHCP and complain "IP-Config: Incomplete
network configuration information." depending on if CONFIG_IP_PNP_DHCP is
set or not.

The only way I can make ip_auto_config accept my IP config is to add an
entry for the server IP:

ip=192.168.1.10:192.168.1.15::255.255.255.0:localhost.localdomain:eth1:off

I think this is a bug since I am not using a NFS root FS.

The following patch fixes the above problem.

From: Andrew Morton 

Davem said (in February!):

  Well, first of all the change in question is not in 2.4.x either.  I just
  checked the current 2.4.x GIT tree and the test is exactly:

	if (ic_myaddr == INADDR_NONE ||
#ifdef CONFIG_ROOT_NFS
	    (MAJOR(ROOT_DEV) == UNNAMED_MAJOR
	     && root_server_addr == INADDR_NONE
	     && ic_servaddr == INADDR_NONE) ||
#endif
	    ic_first_dev->next) {

  which matches 2.6.x

  I even checked 2.4.x when it was branched for 2.5.x and the test was the
  same at the point in time too.

  Looking at the proposed change a bit it appears that it is probably
  correct, as it's trying to check that ROOT_DEV is nfs root.  But if it is
  correct then the UNNAMED_MAJOR comparison in the same code block should be
  removed as it becomes superfluous.

  I'm happy to apply this patch with that modification made.

Signed-off-by: Joakim Tjernlund 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NET]: Rework dev_base via list_head (v3)

2007-05-03T22:13:45+00:00

Cleanup of dev_base list use, with the aim to simplify making device
list per-namespace. In almost every occasion, use of dev_base variable
and dev->next pointer could be easily replaced by for_each_netdev
loop. A few most complicated places were converted to using
first_netdev()/next_netdev().

Signed-off-by: Pavel Emelianov 
Acked-by: Kirill Korotaev 
Signed-off-by: David S. Miller

[NET]: cleanup extra semicolons

2007-04-26T05:29:24+00:00

Spring cleaning time...

There seems to be a lot of places in the network code that have
extra bogus semicolons after conditionals.  Most commonly is a
bogus semicolon after: switch() { }

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_transport_header(skb)

2007-04-26T05:25:31+00:00

For the places where we need a pointer to the transport header, it is
still legal to touch skb->h.raw directly if just adding to,
subtracting from or setting it to another layer header.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph

2007-04-26T05:25:10+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF] ipconfig: Another conversion to skb_reset_network_header related to skb_put

2007-04-26T05:24:52+00:00

boot_pkt->iph is the first member, that is at skb->data, so just use
skb_reset_network_header().

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV4]: cleanup

2007-04-26T05:24:11+00:00

Add whitespace around keywords.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[PATCH] mark struct file_operations const 7

2007-02-12T17:48:46+00:00

Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NET] IPV4: Fix whitespace errors.

2007-02-11T07:19:39+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[NET]: ipconfig and nfsroot annotations

2006-12-03T05:21:09+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller