linux.git/net/ipv4/icmp.c, branch v3.9

ipv4: fix error handling in icmp_protocol.

2013-02-22T20:10:18+00:00

Now we handle icmp errors in each transport protocol's err_handler,
for icmp protocols, that is ping_err. Since this handler only care
of those icmp errors triggered by echo request, errors triggered
by echo reply(which sent by kernel) are sliently ignored.

So wrap ping_err() with icmp_err() to deal with those icmp errors.

Signed-off-by: Li Wei 
Signed-off-by: David S. Miller

ipv4: avoid passing NULL to inet_putpeer() in icmpv4_xrlim_allow()

2012-11-26T22:24:41+00:00

inet_getpeer_v4() can return NULL under OOM conditions, and while
inet_peer_xrlim_allow() is OK with a NULL peer, inet_putpeer() will
crash.

This code path now uses the same idiom as the others from:
1d861aa4b3fb08822055345f480850205ffe6170 ("inet: Minimize use of
cached route inetpeer.").

Signed-off-by: Neal Cardwell 
Signed-off-by: David S. Miller

ipv4: Prepare for change of rt->rt_iif encoding.

2012-07-23T23:36:26+00:00

Use inet_iif() consistently, and for TCP record the input interface of
cached RX dst in inet sock.

rt->rt_iif is going to be encoded differently, so that we can
legitimately cache input routes in the FIB info more aggressively.

When the input interface is "use SKB device index" the rt->rt_iif will
be set to zero.

This forces us to move the TCP RX dst cache installation into the ipv4
specific code, and as well it should since doing the route caching for
ipv6 is pointless at the moment since it is not inspected in the ipv6
input paths yet.

Also, remove the unlikely on dst->obsolete, all ipv4 dsts have
obsolete set to a non-zero value to force invocation of the check
callback.

Signed-off-by: David S. Miller

ipv4: Really ignore ICMP address requests/replies.

2012-07-23T20:20:26+00:00

Alexey removed kernel side support for requests, and the
only thing we do for replies is log a message if something
doesn't look right.

As Alexey's comment indicates, this belongs in userspace (if
anywhere), and thus we can safely just get rid of this code.

Signed-off-by: David S. Miller

ipv4: Put proper checks into icmp_socket_deliver().

2012-07-12T15:06:04+00:00

All handler->err() routines expect that we've done a pskb_may_pull()
test to make sure that IP header length + 8 bytes can be safely
pulled.

Reported-by: Hiroaki SHIMODA 
Signed-off-by: David S. Miller

ipv4: Kill ip_rt_redirect().

2012-07-12T04:30:08+00:00

No longer needed, as the protocol handlers now all properly
propagate the redirect back into the routing code.

Signed-off-by: David S. Miller

ipv4: Rearrange arguments to ip_rt_redirect()

2012-07-12T03:38:08+00:00

Pass in the SKB rather than just the IP addresses, so that policy
and other aspects can reside in ip_rt_redirect() rather then
icmp_redirect().

Signed-off-by: David S. Miller

ipv4: Deliver ICMP redirects to sockets too.

2012-07-12T01:35:12+00:00

And thus, we can remove the ping_err() hack.

Signed-off-by: David S. Miller

ipv4: Pull icmp socket delivery out into a helper function.

2012-07-12T01:32:17+00:00

Signed-off-by: David S. Miller

inet: Minimize use of cached route inetpeer.

2012-07-11T05:40:11+00:00

Only use it in the absolutely required cases:

1) COW'ing metrics

2) ipv4 PMTU

3) ipv4 redirects

Signed-off-by: David S. Miller