linux.git/net/ipv4/fib_semantics.c, branch v2.6.18

[IPV4]: severe locking bug in fib_semantics.c

2006-08-17T23:44:46+00:00

Found in 2.4 by Yixin Pan .

> When I read fib_semantics.c of Linux-2.4.32, write_lock(&fib_info_lock) =
> is used in fib_release_info() instead of write_lock_bh(&fib_info_lock).  =
> Is the following case possible: a BH interrupts fib_release_info() while =
> holding the write lock, and calls ip_check_fib_default() which calls =
> read_lock(&fib_info_lock), and spin forever.

Signed-off-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[IPV4]: Fix nexthop realm dumping for multipath routes

2006-07-21T22:09:55+00:00

Routing realms exist per nexthop, but are only returned to userspace
for the first nexthop. This is due to the fact that iproute2 only
allows to set the realm for the first nexthop and the kernel refuses
multipath routes where only a single realm is present.

Dump all realms for multipath routes to enable iproute to correctly
display them.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET]: Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-21T21:51:30+00:00

Signed-off-by: Panagiotis Issaris 
Signed-off-by: David S. Miller

Remove obsolete #include

2006-06-30T17:25:36+00:00

Signed-off-by: Jörn Engel 
Signed-off-by: Adrian Bunk

[NETLINK]: illegal use of pid in rtnetlink

2006-02-10T00:43:41+00:00

When a netlink message is not related to a netlink socket,
it is issued by kernel socket with pid 0. Netlink "pid" has nothing
to do with current->pid. I called it incorrectly, if it was named "port",
the confusion would be avoided.

Signed-off-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[INET_SOCK]: Move struct inet_sock & helper functions to net/inet_sock.h

2006-01-03T21:11:21+00:00

To help in reducing the number of include dependencies, several files were
touched as they were getting needed headers indirectly for stuff they use.

Thanks also to Alan Menegotto for pointing out that net/dccp/proto.c had
linux/dccp.h include twice.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[NET]: Add const markers to various variables.

2005-11-30T00:21:38+00:00

the patch below marks various variables const in net/; the goal is to
move them to the .rodata section so that they can't false-share
cachelines with things that get written to, as well as potentially
helping gcc a bit with optimisations.  (these were found using a gcc
patch to warn about such variables)

Signed-off-by: Arjan van de Ven 
Signed-off-by: David S. Miller

[IPV4]: Replace __in_dev_get with __in_dev_get_rcu/rtnl

2005-10-03T21:35:55+00:00

The following patch renames __in_dev_get() to __in_dev_get_rtnl() and
introduces __in_dev_get_rcu() to cover the second case.

1) RCU with refcnt should use in_dev_get().
2) RCU without refcnt should use __in_dev_get_rcu().
3) All others must hold RTNL and use __in_dev_get_rtnl().

There is one exception in net/ipv4/route.c which is in fact a pre-existing
race condition.  I've marked it as such so that we remember to fix it.

This patch is based on suggestions and prior work by Suzanne Wood and
Paul McKenney.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[IPV4]: Prepare FIB core for RCU.

2005-08-29T23:08:31+00:00

* RCU versions of hlist_***_rcu
* fib_alias partial rcu port just whats needed now.

Signed-off-by: Robert Olsson 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETLINK]: Convert netlink users to use group numbers instead of bitmasks

2005-08-29T23:00:54+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller