linux.git/net/ipv4/devinet.c, branch v4.20

net: Allow class-e address assignment via ifconfig ioctl

2018-12-14T23:39:31+00:00

While most distributions long ago switched to the iproute2 suite
of utilities, which allow class-e (240.0.0.0/4) address assignment,
distributions relying on busybox, toybox and other forms of
ifconfig cannot assign class-e addresses without this kernel patch.

While CIDR has been obsolete for 2 decades, and a survey of all the
open source code in the world shows the IN_whatever macros are also
obsolete... rather than obsolete CIDR from this ioctl entirely, this
patch merely enables class-e assignment, sanely.

Signed-off-by: Dave Taht 
Signed-off-by: David S. Miller

net/{ipv4,ipv6}: Do not put target net if input nsid is invalid

2018-10-25T23:21:31+00:00

The cleanup path will put the target net when netnsid is set.  So we must
reset netnsid if the input is invalid.

Fixes: d7e38611b81e ("net/ipv4: Put target net when address dump fails due to bad attributes")
Fixes: 242afaa6968c ("net/ipv6: Put target net when address dump fails due to bad attributes")
Cc: David Ahern 
Signed-off-by: Bjørn Mork 
Reviewed-by: David Ahern 
Signed-off-by: David S. Miller

net/ipv4: Put target net when address dump fails due to bad attributes

2018-10-24T21:06:25+00:00

If tgt_net is set based on IFA_TARGET_NETNSID attribute in the dump
request, make sure all error paths call put_net.

Fixes: 5fcd266a9f64 ("net/ipv4: Add support for dumping addresses for a specific device")
Fixes: c33078e3dfb1 ("net/ipv4: Update inet_dump_ifaddr for strict data checking")
Reported-by: Li RongQing 
Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

net/ipv4: Add support for dumping addresses for a specific device

2018-10-23T02:33:29+00:00

If an RTM_GETADDR dump request has ifa_index set in the ifaddrmsg
header, then return only the addresses for that device.

Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

net/ipv4: Move loop over addresses on a device into in_dev_dump_addr

2018-10-23T02:33:29+00:00

Similar to IPv6 move the logic that walks over the ipv4 address list
for a device into a helper.

Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

net: Update netconf dump handlers for strict data checking

2018-10-08T17:39:05+00:00

Update inet_netconf_dump_devconf, inet6_netconf_dump_devconf, and
mpls_netconf_dump_devconf for strict data checking. If the flag is set,
the dump request is expected to have an netconfmsg struct as the header.
The struct only has the family member and no attributes can be appended.

Signed-off-by: David Ahern 
Acked-by: Christian Brauner 
Signed-off-by: David S. Miller

net/ipv4: Update inet_dump_ifaddr for strict data checking

2018-10-08T17:39:04+00:00

Update inet_dump_ifaddr for strict data checking. If the flag is set,
the dump request is expected to have an ifaddrmsg struct as the header
potentially followed by one or more attributes. Any data passed in the
header or as an attribute is taken as a request to influence the data
returned. Only values supported by the dump handler are allowed to be
non-0 or set in the request. At the moment only the IFA_TARGET_NETNSID
attribute is supported. Follow on patches can support for other fields
(e.g., honor ifa_index and only return data for the given device index).

Signed-off-by: David Ahern 
Acked-by: Christian Brauner 
Signed-off-by: David S. Miller

net: Add extack to nlmsg_parse

2018-10-08T17:39:04+00:00

Make sure extack is passed to nlmsg_parse where easy to do so.
Most of these are dump handlers and leveraging the extack in
the netlink_callback.

Signed-off-by: David Ahern 
Acked-by: Christian Brauner 
Signed-off-by: David S. Miller

ipv4: add inet_fill_args

2018-09-06T05:27:11+00:00

inet_fill_ifaddr() already took 6 arguments which meant the 7th argument
would need to be pushed onto the stack on x86.
Add a new struct inet_fill_args which holds common information passed
to inet_fill_ifaddr() and shortens the function to three pointer arguments.

Signed-off-by: Christian Brauner 
Cc: Kirill Tkhai 
Signed-off-by: David S. Miller

ipv4: enable IFA_TARGET_NETNSID for RTM_GETADDR

2018-09-06T05:27:11+00:00

- Backwards Compatibility:
  If userspace wants to determine whether ipv4 RTM_GETADDR requests
  support the new IFA_TARGET_NETNSID property it should verify that the
  reply includes the IFA_TARGET_NETNSID property. If it does not
  userspace should assume that IFA_TARGET_NETNSID is not supported for
  ipv4 RTM_GETADDR requests on this kernel.
- From what I gather from current userspace tools that make use of
  RTM_GETADDR requests some of them pass down struct ifinfomsg when they
  should actually pass down struct ifaddrmsg. To not break existing
  tools that pass down the wrong struct we will do the same as for
  RTM_GETLINK | NLM_F_DUMP requests and not error out when the
  nlmsg_parse() fails.

- Security:
  Callers must have CAP_NET_ADMIN in the owning user namespace of the
  target network namespace.

Signed-off-by: Christian Brauner 
Signed-off-by: David S. Miller