linux.git/net/ethernet, branch v2.6.16

[NET] ethernet: Fix first packet goes out with MAC 00:00:00:00:00:00

2006-02-24T00:18:01+00:00

When you turn off ARP on a netdevice then the first packet always goes
out with a dstMAC of all zeroes. This is because the first packet is
used to resolve ARP entries. Even though the ARP entry may be resolved
(I tried by setting a static ARP entry for a host i was pinging from),
it gets overwritten by virtue of having the netdevice disabling ARP.

Subsequent packets go out fine with correct dstMAC address (which may
be why people have ignored reporting this issue).

To cut the story short: 

the culprit code is in net/ethernet/eth.c::eth_header()

----
        /*
         *      Anyway, the loopback-device should never use this
function...
         */

        if (dev->flags & (IFF_LOOPBACK|IFF_NOARP))
        {
                memset(eth->h_dest, 0, dev->addr_len);
                return ETH_HLEN;
        }

	if(daddr)
        {
                memcpy(eth->h_dest,daddr,dev->addr_len);
                return ETH_HLEN;
        }

----

Note how the h_dest is being reset when device has IFF_NOARP.

As a note:
All devices including loopback pass a daddr. loopback in fact passes
a 0 all the time ;-> 
This means i can delete the check totaly or i can remove the IFF_NOARP

Alexey says:
--------------------
I think, it was me who did this crap. It was so long ago I do not remember
why it was made.

I remember some troubles with dummy device. It tried to resolve
addresses, apparently, without success and generated errors instead of
blackholing. I think the problem was eventually solved at neighbour
level.

After some thinking I suspect the deletion of this chunk could change
behaviour of some parts which do not use neighbour cache f.e. packet
socket.

I think safer approach would be to move this chunk after if (daddr).
And the possibility to remove this completely could be analyzed later.
--------------------

Patch updated with Alexey's safer suggestions.

Signed-off-by: Jamal Hadi Salim 
Acked-by: Alexey Kuznetsov 
Signed-off-by: David S. Miller

[NET]: Use newer is_multicast_ether_addr() in some files

2006-01-06T21:05:58+00:00

This uses is_multicast_ether_addr() because it has recently been
changed to do the same thing these seperate tests are doing.

Signed-off-by: Kris Katterjohn 
Signed-off-by: David S. Miller

[NET]: Change 1500 to ETH_DATA_LEN in some files

2006-01-06T00:48:56+00:00

These patches add the header linux/if_ether.h and change 1500 to
ETH_DATA_LEN in some files.

Signed-off-by: Kris Katterjohn 
Signed-off-by: David S. Miller

[NET]: kfree cleanup

2005-11-08T17:41:34+00:00

From: Jesper Juhl 

This is the net/ part of the big kfree cleanup patch.

Remove pointless checks for NULL prior to calling kfree() in net/.

Signed-off-by: Jesper Juhl 
Cc: "David S. Miller" 
Cc: Arnaldo Carvalho de Melo 
Acked-by: Marcel Holtmann 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: Andrew Morton

[ETH]: ether address compare

2005-10-29T04:23:58+00:00

Expose faster ether compare for use by protocols and other
driver. And change name to be more consistent with other ether
address manipulation routines in same file

Signed-off-by: Stephen Hemminger 
Signed-off-by: Arnaldo Carvalho de Melo

[NET]: Fix reversed logic in eth_type_trans().

2005-09-29T05:37:53+00:00

I got the second compare_eth_addr() test reversed, oops.

Signed-off-by: David S. Miller

[NET]: Slightly optimize ethernet address comparison.

2005-09-27T23:03:05+00:00

We know the thing is at least 2-byte aligned, so take
advantage of that instead of invoking memcmp() which
results in truly horrifically inefficient code because
it can't assume anything about alignment.

Signed-off-by: David S. Miller

[NET]: Fix sparse warnings

2005-08-29T23:01:32+00:00

Of this type, mostly:

CHECK   net/ipv6/netfilter.c
net/ipv6/netfilter.c:96:12: warning: symbol 'ipv6_netfilter_init' was not declared. Should it be static?
net/ipv6/netfilter.c:101:6: warning: symbol 'ipv6_netfilter_fini' was not declared. Should it be static?

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[NET]: Remove explicit initializations of skb->input_dev

2005-08-29T22:33:26+00:00

Instead, set it in one place, namely the beginning of
netif_receive_skb().

Based upon suggestions from Jamal Hadi Salim.

Signed-off-by: David S. Miller

[NET]: __be'ify *_type_trans()

2005-07-12T19:08:43+00:00

tr_type_trans(), hippi_type_trans() left as-is.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller