linux.git/net/devlink, branch v6.6

devlink: Hold devlink lock on health reporter dump get

2023-10-06T22:56:46+00:00

Devlink health dump get callback should take devlink lock as any other
devlink callback. Otherwise, since devlink_mutex was removed, this
callback is not protected from a race of the reporter being destroyed
while handling the callback.

Add devlink lock to the callback and to any call for
devlink_health_do_dump(). This should be safe as non of the drivers dump
callback implementation takes devlink lock.

As devlink lock is added to any callback of dump, the reporter dump_lock
is now redundant and can be removed.

Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex")
Signed-off-by: Moshe Shemesh 
Reviewed-by: Jiri Pirko 
Reviewed-by: Przemek Kitszel 
Link: https://lore.kernel.org/r/1696510216-189379-1-git-send-email-moshe@nvidia.com
Signed-off-by: Jakub Kicinski

devlink: move devlink_notify_register/unregister() to dev.c

2023-08-28T15:02:24+00:00

At last, move the last bits out of leftover.c,
the devlink_notify_register/unregister() functions to dev.c

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-16-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: move small_ops definition into netlink.c

2023-08-28T15:02:23+00:00

Move the generic netlink small_ops definition where they are consumed,
into netlink.c

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-15-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: move tracepoint definitions into core.c

2023-08-28T15:02:23+00:00

Move remaining tracepoint definitions to most suitable file core.c.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-14-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: push linecard related code into separate file

2023-08-28T15:02:23+00:00

Cut out another chunk from leftover.c and put linecard related code
into a separate file.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-13-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: push rate related code into separate file

2023-08-28T15:02:23+00:00

Cut out another chunk from leftover.c and put rate related code
into a separate file.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-12-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: push trap related code into separate file

2023-08-28T15:02:23+00:00

Cut out another chunk from leftover.c and put trap related code
into a separate file.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-11-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: use tracepoint_enabled() helper

2023-08-28T15:02:23+00:00

In preparation for the trap code move, use tracepoint_enabled() helper
instead of trace_devlink_trap_report_enabled() which would not be
defined in that scope.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-10-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: push region related code into separate file

2023-08-28T15:02:23+00:00

Cut out another chunk from leftover.c and put region related code
into a separate file.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-9-jiri@resnulli.us
Signed-off-by: Jakub Kicinski

devlink: push param related code into separate file

2023-08-28T15:02:22+00:00

Cut out another chunk from leftover.c and put param related code
into a separate file.

Signed-off-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20230828061657.300667-8-jiri@resnulli.us
Signed-off-by: Jakub Kicinski