linux.git/net/dccp, branch v2.6.15

[DCCP]: Comment typo

2005-12-22T03:02:39+00:00

I hope to actually change this behaviour shortly but this will help
anybody grepping code at present.

Signed-off-by: Ian McDonald 
Signed-off-by: David S. Miller

[DCCP]: Add missing no_policy flag to struct net_protocol

2005-11-21T05:16:13+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET]: kfree cleanup

2005-11-08T17:41:34+00:00

From: Jesper Juhl 

This is the net/ part of the big kfree cleanup patch.

Remove pointless checks for NULL prior to calling kfree() in net/.

Signed-off-by: Jesper Juhl 
Cc: "David S. Miller" 
Cc: Arnaldo Carvalho de Melo 
Acked-by: Marcel Holtmann 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: Andrew Morton

[TCP/DCCP]: Randomize port selection

2005-11-05T23:23:15+00:00

This patch randomizes the port selected on bind() for connections
to help with possible security attacks. It should also be faster
in most cases because there is no need for a global lock.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Arnaldo Carvalho de Melo

[DCCP]: Set socket owner iff packet is not data

2005-11-01T00:30:02+00:00

  
Here is a complimentary insurance policy for those feeling a bit insecure.
You don't have to accept this.  However, if you do, you can't blame me for
it :)
  
> 1) dccp_transmit_skb sets the owner for all packets except data packets.
  
We can actually verify this by looking at pkt_type.
  
Signed-off-by: Herbert Xu 
Signed-off-by: Arnaldo Carvalho de Melo

[DCCP]: Simplify skb_set_owner_w semantics

2005-10-31T21:26:17+00:00

  
While we're at it let's reorganise the set_owner_w calls a little so that:
  
1) dccp_transmit_skb sets the owner for all packets except data packets.
2) Add dccp_skb_entail to set owner for packets queued for retransmission.
3) Make dccp_transmit_skb static.
  
Signed-off-by: Herbert Xu 
Signed-off-by: Arnaldo Carvalho de Melo

[PATCH] gfp_t: net/*

2005-10-28T15:16:47+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[DCCP]: Clear the IPCB area

2005-10-20T16:49:59+00:00

Turns out the problem has nothing to do with use-after-free or double-free.
It's just that we're not clearing the CB area and DCCP unlike TCP uses a CB
format that's incompatible with IP.

Signed-off-by: Herbert Xu 
Signed-off-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo

[DCCP]: Make dccp_write_xmit always free the packet

2005-10-20T16:44:29+00:00

icmp_send doesn't use skb->sk at all so even if skb->sk has already
been freed it can't cause crash there (it would've crashed somewhere
else first, e.g., ip_queue_xmit).

I found a double-free on an skb that could explain this though.
dccp_sendmsg and dccp_write_xmit are a little confused as to what
should free the packet when something goes wrong.  Sometimes they
both go for the ball and end up in each other's way.

This patch makes dccp_write_xmit always free the packet no matter
what.  This makes sense since dccp_transmit_skb which in turn comes
from the fact that ip_queue_xmit always frees the packet.

Signed-off-by: Herbert Xu 
Signed-off-by: Arnaldo Carvalho de Melo

[DCCP]: Use skb_set_owner_w in dccp_transmit_skb when skb->sk is NULL

2005-10-20T16:25:28+00:00

David S. Miller  wrote:
> One thing you can probably do for this bug is to mark data packets
> explicitly somehow, perhaps in the SKB control block DCCP already
> uses for other data.  Put some boolean in there, set it true for
> data packets.  Then change the test in dccp_transmit_skb() as
> appropriate to test the boolean flag instead of "skb_cloned(skb)".

I agree.  In fact we already have that flag, it's called skb->sk.
So here is patch to test that instead of skb_cloned().

Signed-off-by: Herbert Xu 
Acked-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo