linux.git/net/dccp/ackvec.c, branch v2.6.17 Linux kernel source tree [DCCP] Ackvec: fix soft lockup in ackvec handling code 2006-06-12T04:08:03+00:00 Andrea Bittau a.bittau@cs.ucl.ac.uk 2006-06-12T03:58:33+00:00 afec35e3fee900b3016519d0b5512064e4625b2c A soft lockup existed in the handling of ack vector records. Specifically, when a tail of the list of ack vector records was removed, it was possible to end up iterating infinitely on an element of the tail. Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk> Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz> Signed-off-by: David S. Miller <davem@davemloft.net> 
A soft lockup existed in the handling of ack vector records.
Specifically, when a tail of the list of ack vector records was
removed, it was possible to end up iterating infinitely on an element
of the tail.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] options: Make dccp_insert_options & friends yell on error 2006-03-21T06:32:06+00:00 Arnaldo Carvalho de Melo acme@mandriva.com 2006-03-21T06:32:06+00:00 2d0817d11eaec57435feb61493331a763f732a2b And not the silly LIMIT_NETDEBUG and silently return without inserting the option requested. Also drop some old debugging messages associated to option insertion. Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
And not the silly LIMIT_NETDEBUG and silently return without inserting
the option requested.

Also drop some old debugging messages associated to option insertion.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] ackvec: Delete all the ack vector records in dccp_ackvec_free 2006-03-21T01:20:46+00:00 Arnaldo Carvalho de Melo acme@mandriva.com 2006-03-21T01:20:46+00:00 d5e9b2c737ecaedae66e3dffdd0d92d2a189ec5c Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] ackvec: Introduce ack vector records 2006-03-21T01:19:55+00:00 Andrea Bittau a.bittau@cs.ucl.ac.uk 2006-03-21T01:19:55+00:00 02bcf28c82c8e4b72c4b89bddbbb6fea1a646d07 Based on a patch by Andrea Bittau. Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Based on a patch by Andrea Bittau.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] ackvec: Introduce dccp_ackvec_slab 2006-03-21T01:16:17+00:00 Arnaldo Carvalho de Melo acme@mandriva.com 2006-03-21T01:16:17+00:00 9b07ef5ddaced1e822b1a1fb1da088eb15c45cb4 Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] ackvec: Ditch dccpav_buf_len 2006-03-21T01:15:42+00:00 Arnaldo Carvalho de Melo acme@mandriva.com 2006-03-21T01:15:42+00:00 7400d781105d18bf5bba89f8b986a413f14144a8 Simplifying the code a bit as we're always using DCCP_MAX_ACKVEC_LEN. Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Simplifying the code a bit as we're always using DCCP_MAX_ACKVEC_LEN.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NET]: "signed long" -> "long" 2006-01-17T21:03:54+00:00 Kris Katterjohn kjak@users.sourceforge.net 2006-01-17T21:03:54+00:00 a8fc3d8decfd5601fb14a2163952f81fa6b971bb Signed-off-by: Kris Katterjohn <kjak@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Kris Katterjohn <kjak@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[DCCP] ackvec: use u8 for the buf offsets 2006-01-04T03:46:34+00:00 Arnaldo Carvalho de Melo acme@mandriva.com 2006-01-04T03:46:34+00:00 e4dfd449c80a41bb615b23d0fc198ba08360a1f8 Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> 
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
[DCCP] ackvec: Fix spelling of "throw" 2006-01-04T03:45:17+00:00 Andrea Bittau a.bittau@cs.ucl.ac.uk 2006-01-04T03:45:17+00:00 6742bbcbb8a0959e1dff0ce055768e3217d9967a Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> 
Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
[PATCH] gfp flags annotations - part 1 2005-10-08T22:00:57+00:00 Al Viro viro@ftp.linux.org.uk 2005-10-07T06:46:04+00:00 dd0fc66fb33cd610bc1a5db8a5e232d34879b4d7 - added typedef unsigned int __nocast gfp_t; - replaced __nocast uses for gfp flags with gfp_t - it gives exactly the same warnings as far as sparse is concerned, doesn't change generated code (from gcc point of view we replaced unsigned int with typedef) and documents what's going on far better. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@osdl.org> 
 - added typedef unsigned int __nocast gfp_t;

 - replaced __nocast uses for gfp flags with gfp_t - it gives exactly
   the same warnings as far as sparse is concerned, doesn't change
   generated code (from gcc point of view we replaced unsigned int with
   typedef) and documents what's going on far better.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>