linux.git/net/core, branch v3.7-rc5

af-packet: fix oops when socket is not present

2012-11-07T20:40:14+00:00

Due to a NULL dereference, the following patch is causing oops
in normal trafic condition:

commit c0de08d04215031d68fa13af36f347a6cfa252ca
Author: Eric Leblond 
Date:   Thu Aug 16 22:02:58 2012 +0000

    af_packet: don't emit packet on orig fanout group

This buggy patch was a feature fix and has reached most stable
branches.

When skb->sk is NULL and when packet fanout is used, there is a
crash in match_fanout_group where skb->sk is accessed.
This patch fixes the issue by returning false as soon as the
socket is NULL: this correspond to the wanted behavior because
the kernel as to resend the skb to all the listening socket in
this case.

Signed-off-by: Eric Leblond 
Signed-off-by: David S. Miller

rtnetlink: Use nlmsg type RTM_NEWNEIGH from dflt fdb dump

2012-11-03T19:27:08+00:00

Change the dflt fdb dump handler to use RTM_NEWNEIGH to
be compatible with bridge dump routines.

The dump reply from the network driver handlers should
match the reply from bridge handler. The fact they were
not in the ixgbe case was effectively a bug. This patch
resolves it.

Applications that were not checking the nlmsg type will
continue to work. And now applications that do check
the type will work as expected.

Signed-off-by: John Fastabend 
Signed-off-by: David S. Miller

net: fix secpath kmemleak

2012-10-22T19:16:07+00:00

Mike Kazantsev found 3.5 kernels and beyond were leaking memory,
and tracked the faulty commit to a1c7fff7e18f59e ("net:
netdev_alloc_skb() use build_skb()")

While this commit seems fine, it uncovered a bug introduced
in commit bad43ca8325 ("net: introduce skb_try_coalesce()), in function
kfree_skb_partial()"):

If head is stolen, we free the sk_buff,
without removing references on secpath (skb->sp).

So IPsec + IP defrag/reassembly (using skb coalescing), or
TCP coalescing could leak secpath objects.

Fix this bug by calling skb_release_head_state(skb) to properly
release all possible references to linked objects.

Reported-by: Mike Kazantsev 
Signed-off-by: Eric Dumazet 
Bisected-by: Mike Kazantsev 
Tested-by: Mike Kazantsev 
Signed-off-by: David S. Miller

net: add doc for in4_pton()

2012-10-12T17:56:52+00:00

It is not easy to use in4_pton() correctly without reading
its definition, so add some doc for it.

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: add doc for in6_pton()

2012-10-12T17:56:52+00:00

It is not easy to use in6_pton() correctly without reading
its definition, so add some doc for it.

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

pktgen: replace scan_ip6() with in6_pton()

2012-10-11T02:33:30+00:00

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

pktgen: enable automatic IPv6 address setting

2012-10-11T02:33:30+00:00

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

pktgen: display IPv4 address in human-readable format

2012-10-11T02:33:30+00:00

It is weird to display IPv4 address in %x format, what's more,
IPv6 address is disaplayed in human-readable format too. So,
make it human-readable.

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

pktgen: set different default min_pkt_size for different protocols

2012-10-11T02:33:30+00:00

ETH_ZLEN is too small for IPv6, so this default value is not
suitable.

Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

pktgen: fix crash when generating IPv6 packets

2012-10-11T02:33:30+00:00

For IPv6, sizeof(struct ipv6hdr) = 40, thus the following
expression will result negative:

        datalen = pkt_dev->cur_pkt_size - 14 -
                  sizeof(struct ipv6hdr) - sizeof(struct udphdr) -
                  pkt_dev->pkt_overhead;

And,  the check "if (datalen < sizeof(struct pktgen_hdr))" will be
passed as "datalen" is promoted to unsigned, therefore will cause
a crash later.

This is a quick fix by checking if "datalen" is negative. The following
patch will increase the default value of 'min_pkt_size' for IPv6.

This bug should exist for a long time, so Cc -stable too.

Cc: 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller