linux.git/net/core, branch v3.3-rc5

netpoll: netpoll_poll_dev() should access dev->flags

2012-02-14T20:24:26+00:00

commit 5a698af53f (bond: service netpoll arp queue on master device)
tested IFF_SLAVE flag against dev->priv_flags instead of dev->flags

Signed-off-by: Eric Dumazet 
Cc: WANG Cong 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

netprio_cgroup: fix wrong memory access when NETPRIO_CGROUP=m

2012-02-10T20:08:57+00:00

When the netprio_cgroup module is not loaded, net_prio_subsys_id
is -1, and so sock_update_prioidx() accesses cgroup_subsys array
with negative index subsys[-1].

Make the code resembles cls_cgroup code, which is bug free.

Origionally-authored-by: Li Zefan 
Signed-off-by: Li Zefan 
Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

netprio_cgroup: don't allocate prio table when a device is registered

2012-02-10T20:08:57+00:00

So we delay the allocation till the priority is set through cgroup,
and this makes skb_update_priority() faster when it's not set.

This also eliminates an off-by-one bug similar with the one fixed
in the previous patch.

Origionally-authored-by: Li Zefan 
Signed-off-by: Li Zefan 
Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

netprio_cgroup: fix an off-by-one bug

2012-02-10T20:08:56+00:00

# mount -t cgroup xxx /mnt
  # mkdir /mnt/tmp
  # cat /mnt/tmp/net_prio.ifpriomap
  lo 0
  eth0 0
  virbr0 0
  # echo 'lo 999' > /mnt/tmp/net_prio.ifpriomap
  # cat /mnt/tmp/net_prio.ifpriomap
  lo 999
  eth0 0
  virbr0 4101267344

We got weired output, because we exceeded the boundary of the array.
We may even crash the kernel..

Origionally-authored-by: Li Zefan 
Signed-off-by: Li Zefan 
Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

gro: more generic L2 header check

2012-02-08T23:26:54+00:00

Shlomo Pongratz reported GRO L2 header check was suited for Ethernet
only, and failed on IB/ipoib traffic.

He provided a patch faking a zeroed header to let GRO aggregates frames.

Roland Dreier, Herbert Xu, and others suggested we change GRO L2 header
check to be more generic, ie not assuming L2 header is 14 bytes, but
taking into account hard_header_len.

__napi_gro_receive() has special handling for the common case (Ethernet)
to avoid a memcmp() call and use an inline optimized function instead.

Signed-off-by: Eric Dumazet 
Reported-by: Shlomo Pongratz 
Cc: Roland Dreier 
Cc: Or Gerlitz 
Cc: Herbert Xu 
Tested-by: Sean Hefty 
Signed-off-by: David S. Miller

netprio_cgroup: Fix obo in get_prioidx

2012-02-04T21:30:24+00:00

It was recently pointed out to me that the get_prioidx function sets a bit in
the prioidx map prior to checking to see if the index being set is out of
bounds.  This patch corrects that, avoiding the possiblity of us writing beyond
the end of the array

Signed-off-by: Neil Horman 
Reported-by: Stanislaw Gruszka 
CC: Stanislaw Gruszka 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

ethtool: Null-terminate filename passed to ethtool_ops::flash_device

2012-02-01T19:47:17+00:00

The parameters for ETHTOOL_FLASHDEV include a filename, which ought to
be null-terminated.  Currently the only driver that implements
ethtool_ops::flash_device attempts to add a null terminator if
necessary, but does it wrongly.  Do it in the ethtool core instead.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

net: RTNETLINK adjusting values of min_ifinfo_dump_size

2012-01-26T21:35:57+00:00

Setting link parameters on a netdevice changes the value
of if_nlmsg_size(), therefore it is necessary to recalculate
min_ifinfo_dump_size.

Signed-off-by: Stefan Gula 
Signed-off-by: David S. Miller

netns: fix net_alloc_generic()

2012-01-26T18:36:19+00:00

When a new net namespace is created, we should attach to it a "struct
net_generic" with enough slots (even empty), or we can hit the following
BUG_ON() :

[  200.752016] kernel BUG at include/net/netns/generic.h:40!
...
[  200.752016]  [] ? get_cfcnfg+0x3a/0x180
[  200.752016]  [] ? lockdep_rtnl_is_held+0x10/0x20
[  200.752016]  [] caif_device_notify+0x2e/0x530
[  200.752016]  [] notifier_call_chain+0x67/0x110
[  200.752016]  [] raw_notifier_call_chain+0x11/0x20
[  200.752016]  [] call_netdevice_notifiers+0x32/0x60
[  200.752016]  [] register_netdevice+0x196/0x300
[  200.752016]  [] register_netdev+0x19/0x30
[  200.752016]  [] loopback_net_init+0x4a/0xa0
[  200.752016]  [] ops_init+0x42/0x180
[  200.752016]  [] setup_net+0x6b/0x100
[  200.752016]  [] copy_net_ns+0x86/0x110
[  200.752016]  [] create_new_namespaces+0xd9/0x190

net_alloc_generic() should take into account the maximum index into the
ptr array, as a subsystem might use net_generic() anytime.

This also reduces number of reallocations in net_assign_generic()

Reported-by: Sasha Levin 
Tested-by: Sasha Levin 
Signed-off-by: Eric Dumazet 
Cc: Sjur Brændeland 
Cc: Eric W. Biederman 
Cc: Pavel Emelyanov 
Signed-off-by: David S. Miller

net: flow_dissector.c missing include linux/export.h

2012-01-24T21:03:33+00:00

The file net/core/flow_dissector.c seems to be missing
including linux/export.h.

Signed-off-by: Jesper Dangaard Brouer 
Signed-off-by: David S. Miller