linux.git/net/core, branch v2.6.15

[NET]: Validate socket filters against BPF_MAXINSNS in one spot.

2005-12-27T21:57:59+00:00

Currently the checks are scattered all over and this leads
to inconsistencies and even cases where the check is not made.

Based upon a patch from Kris Katterjohn.

Signed-off-by: David S. Miller

[NET]: Fix NULL pointer deref in checksum debugging.

2005-12-08T23:21:39+00:00

The problem I was seeing turned out to be that skb->dev is NULL when
the checksum is being completed in user context. This happens because
the reference to the device is dropped (to allow it to be released
when packets are in the queue).

Because skb->dev was NULL, the netdev_rx_csum_fault was panicing on
deref of dev->name. How about this?

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NET]: make function pointer argument parseable by kernel-doc

2005-12-05T21:40:12+00:00

When a function takes a function pointer as argument it should use the 'return
(*pointer)(params...)' syntax used everywhere else in the kernel as this is
recognized by kernel-doc.

Signed-off-by: Martin Waitz 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NET]: Reject socket filter if division by constant zero is attempted.

2005-11-20T21:41:34+00:00

This way we don't have to check it in sk_run_filter().

Signed-off-by: Kris Katterjohn 
Signed-off-by: David S. Miller

[NET]: Detect hardware rx checksum faults correctly

2005-11-10T21:01:24+00:00

Here is the patch that introduces the generic skb_checksum_complete
which also checks for hardware RX checksum faults.  If that happens,
it'll call netdev_rx_csum_fault which currently prints out a stack
trace with the device name.  In future it can turn off RX checksum.

I've converted every spot under net/ that does RX checksum checks to
use skb_checksum_complete or __skb_checksum_complete with the
exceptions of:

* Those places where checksums are done bit by bit.  These will call
netdev_rx_csum_fault directly.

* The following have not been completely checked/converted:

ipmr
ip_vs
netfilter
dccp

This patch is based on patches and suggestions from Stephen Hemminger
and David S. Miller.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[RTNETLINK]: Use generic netlink receive queue processor

2005-11-10T01:26:40+00:00

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NETLINK]: Make netlink_callback->done() optional

2005-11-10T01:26:40+00:00

Most netlink families make no use of the done() callback, making
it optional gets rid of all unnecessary dummy implementations.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NETFILTER]: Add nf_conntrack subsystem.

2005-11-10T00:38:16+00:00

The existing connection tracking subsystem in netfilter can only
handle ipv4.  There were basically two choices present to add
connection tracking support for ipv6.  We could either duplicate all
of the ipv4 connection tracking code into an ipv6 counterpart, or (the
choice taken by these patches) we could design a generic layer that
could handle both ipv4 and ipv6 and thus requiring only one sub-protocol
(TCP, UDP, etc.) connection tracking helper module to be written.

In fact nf_conntrack is capable of working with any layer 3
protocol.

The existing ipv4 specific conntrack code could also not deal
with the pecularities of doing connection tracking on ipv6,
which is also cured here.  For example, these issues include:

1) ICMPv6 handling, which is used for neighbour discovery in
   ipv6 thus some messages such as these should not participate
   in connection tracking since effectively they are like ARP
   messages

2) fragmentation must be handled differently in ipv6, because
   the simplistic "defrag, connection track and NAT, refrag"
   (which the existing ipv4 connection tracking does) approach simply
   isn't feasible in ipv6

3) ipv6 extension header parsing must occur at the correct spots
   before and after connection tracking decisions, and there were
   no provisions for this in the existing connection tracking
   design

4) ipv6 has no need for stateful NAT

The ipv4 specific conntrack layer is kept around, until all of
the ipv4 specific conntrack helpers are ported over to nf_conntrack
and it is feature complete.  Once that occurs, the old conntrack
stuff will get placed into the feature-removal-schedule and we will
fully kill it off 6 months later.

Signed-off-by: Yasuyuki Kozakai 
Signed-off-by: Harald Welte 
Signed-off-by: Arnaldo Carvalho de Melo

[NET]: kfree cleanup

2005-11-08T17:41:34+00:00

From: Jesper Juhl 

This is the net/ part of the big kfree cleanup patch.

Remove pointless checks for NULL prior to calling kfree() in net/.

Signed-off-by: Jesper Juhl 
Cc: "David S. Miller" 
Cc: Arnaldo Carvalho de Melo 
Acked-by: Marcel Holtmann 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: Andrew Morton

[NET]: Fix race condition in sk_stream_wait_connect

2005-11-05T23:05:20+00:00

When sk_stream_wait_connect detects a state transition to ESTABLISHED
or CLOSE_WAIT prior to it going to sleep, it will return without
calling finish_wait and decrementing sk_write_pending.

This may result in crashes and other unintended behaviour.

The fix is to always call finish_wait and update sk_write_pending since
it is safe to do so even if the wait entry is no longer on the queue.

This bug was tracked down with the help of Alex Sidorenko and the
fix is also based on his suggestion.

Signed-off-by: Herbert Xu 
Signed-off-by: Arnaldo Carvalho de Melo