linux.git/net/core/skbuff.c, branch v2.6.30

net: fix skb_seq_read returning wrong offset/length for page frag data

2009-05-19T04:43:27+00:00

When called with a consumed value that is less than skb_headlen(skb)
bytes into a page frag, skb_seq_read() incorrectly returns an
offset/length relative to skb->data. Ensure that data which should come
from a page frag does.

Signed-off-by: Thomas Chenault 
Tested-by: Shyam Iyer 
Signed-off-by: David S. Miller

net: update skb_recycle_check() for hardware timestamping changes

2009-05-06T23:49:18+00:00

Commit ac45f602ee3d1b6f326f68bc0c2591ceebf05ba4 ("net: infrastructure
for hardware time stamping") added two skb initialization actions to
__alloc_skb(), which need to be added to skb_recycle_check() as well.

Signed-off-by: Lennert Buytenhek 
Signed-off-by: Patrick Ohly 
Signed-off-by: David S. Miller

net: Fix oops when splicing skbs from a frag_list.

2009-04-30T12:41:19+00:00

Lennert Buytenhek wrote:
> Since 4fb669948116d928ae44262ab7743732c574630d ("net: Optimize memory
> usage when splicing from sockets.") I'm seeing this oops (e.g. in
> 2.6.30-rc3) when splicing from a TCP socket to /dev/null on a driver
> (mv643xx_eth) that uses LRO in the skb mode (lro_receive_skb) rather
> than the frag mode:

My patch incorrectly assumed skb->sk was always valid, but for
"frag_listed" skbs we can only use skb->sk of their parent.

Reported-by: Lennert Buytenhek 
Debugged-by: Lennert Buytenhek 
Tested-by: Lennert Buytenhek 
Signed-off-by: Jarek Poplawski 
Signed-off-by: David S. Miller

gso: Fix support for linear packets

2009-03-29T06:39:18+00:00

When GRO/frag_list support was added to GSO, I made an error
which broke the support for segmenting linear GSO packets (GSO
packets are normally non-linear in the payload).

These days most of these packets are constructed by the tun
driver, which prefers to allocate linear memory if possible.
This is fixed in the latest kernel, but for 2.6.29 and earlier
it is still the norm.

Therefore this bug causes failures with GSO when used with tun
in 2.6.29.

Reported-by: James Huang 
Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs

2009-03-13T19:09:28+00:00

Signed-off-by: Neil Horman 

 include/linux/skbuff.h |    4 +++-
 net/core/datagram.c    |    2 +-
 net/core/skbuff.c      |   22 ++++++++++++++++++++++
 net/ipv4/arp.c         |    2 +-
 net/ipv4/udp.c         |    2 +-
 net/packet/af_packet.c |    2 +-
 6 files changed, 29 insertions(+), 5 deletions(-)
Signed-off-by: David S. Miller

core: remove some pointless conditionals before kfree_skb()

2009-02-27T07:07:36+00:00

Remove some pointless conditionals before kfree_skb().

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller

Merge branch 'master' of /home/davem/src/GIT/linux-2.6/

2009-02-24T11:50:29+00:00

net: Kill skb_truesize_check(), it only catches false-positives.

2009-02-18T05:24:05+00:00

A long time ago we had bugs, primarily in TCP, where we would modify
skb->truesize (for TSO queue collapsing) in ways which would corrupt
the socket memory accounting.

skb_truesize_check() was added in order to try and catch this error
more systematically.

However this debugging check has morphed into a Frankenstein of sorts
and these days it does nothing other than catch false-positives.

Signed-off-by: David S. Miller

net: infrastructure for hardware time stamping

2009-02-16T06:43:34+00:00

The additional per-packet information (16 bytes for time stamps, 1
byte for flags) is stored for all packets in the skb_shared_info
struct. This implementation detail is hidden from users of that
information via skb_* accessor functions. A separate struct resp.
union is used for the additional information so that it can be
stored/copied easily outside of skb_shared_info.

Compared to previous implementations (reusing the tstamp field
depending on the context, optional additional structures) this
is the simplest solution. It does not extend sk_buff itself.

TX time stamping is implemented in software if the device driver
doesn't support hardware time stamping.

The new semantic for hardware/software time stamping around
ndo_start_xmit() is based on two assumptions about existing
network device drivers which don't support hardware time
stamping and know nothing about it:
 - they leave the new skb_shared_tx unmodified
 - the keep the connection to the originating socket in skb->sk
   alive, i.e., don't call skb_orphan()

Given that skb_shared_tx is new, the first assumption is safe.
The second is only true for some drivers. As a result, software
TX time stamping currently works with the bnx2 driver, but not
with the unmodified igb driver (the two drivers this patch series
was tested with).

Signed-off-by: Patrick Ohly 
Signed-off-by: David S. Miller

net: Fix page seeking for skb_splice_bits().

2009-02-13T00:51:43+00:00

struct page walking should be done with proper accessor functions, not
directly.

With doubts from David S. Miller and Herbert Xu.

Signed-off-by: Jarek Poplawski 
Signed-off-by: David S. Miller