linux.git/net/core/skbuff.c, branch v2.6.17

[NET]: Add skb->truesize assertion checking.

2006-04-20T07:10:50+00:00

Add some sanity checking.  truesize should be at least sizeof(struct
sk_buff) plus the current packet length.  If not, then truesize is
seriously mangled and deserves a kernel log message.

Currently we'll do the check for release of stream socket buffers.

But we can add checks to more spots over time.

Incorporating ideas from Herbert Xu.

Signed-off-by: David S. Miller

[PATCH] slab: implement /proc/slab_allocators

2006-03-25T16:22:49+00:00

Implement /proc/slab_allocators.   It produces output like:

idr_layer_cache: 80 idr_pre_get+0x33/0x4e
buffer_head: 2555 alloc_buffer_head+0x20/0x75
mm_struct: 9 mm_alloc+0x1e/0x42
mm_struct: 20 dup_mm+0x36/0x370
vm_area_struct: 384 dup_mm+0x18f/0x370
vm_area_struct: 151 do_mmap_pgoff+0x2e0/0x7c3
vm_area_struct: 1 split_vma+0x5a/0x10e
vm_area_struct: 11 do_brk+0x206/0x2e2
vm_area_struct: 2 copy_vma+0xda/0x142
vm_area_struct: 9 setup_arg_pages+0x99/0x214
fs_cache: 8 copy_fs_struct+0x21/0x133
fs_cache: 29 copy_process+0xf38/0x10e3
files_cache: 30 alloc_files+0x1b/0xcf
signal_cache: 81 copy_process+0xbaa/0x10e3
sighand_cache: 77 copy_process+0xe65/0x10e3
sighand_cache: 1 de_thread+0x4d/0x5f8
anon_vma: 241 anon_vma_prepare+0xd9/0xf3
size-2048: 1 add_sect_attrs+0x5f/0x145
size-2048: 2 journal_init_revoke+0x99/0x302
size-2048: 2 journal_init_revoke+0x137/0x302
size-2048: 2 journal_init_inode+0xf9/0x1c4

Cc: Manfred Spraul 
Cc: Alexander Nyberg 
Cc: Pekka Enberg 
Cc: Christoph Lameter 
Cc: Ravikiran Thirumalai 
Signed-off-by: Al Viro 
DESC
slab-leaks3-locking-fix
EDESC
From: Andrew Morton 

Update for slab-remove-cachep-spinlock.patch

Cc: Al Viro 
Cc: Manfred Spraul 
Cc: Alexander Nyberg 
Cc: Pekka Enberg 
Cc: Christoph Lameter 
Cc: Ravikiran Thirumalai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[SK_BUFF]: export skb_pull_rcsum

2006-03-21T06:47:55+00:00

*** Warning: "skb_pull_rcsum" [net/bridge/bridge.ko] undefined!
*** Warning: "skb_pull_rcsum" [net/8021q/8021q.ko] undefined!
*** Warning: "skb_pull_rcsum" [drivers/net/pppoe.ko] undefined!
*** Warning: "skb_pull_rcsum" [drivers/net/ppp_generic.ko] undefined!

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum

2006-03-21T06:43:56+00:00

We're now starting to have quite a number of places that do skb_pull
followed immediately by an skb_postpull_rcsum.  We can merge these two
operations into one function with skb_pull_rcsum.  This makes sense
since most pull operations on receive skb's need to update the
checksum.

I've decided to make this out-of-line since it is fairly big and the
fast path where hardware checksums are enabled need to call
csum_partial anyway.

Since this is a brand new function we get to add an extra check on the
len argument.  As it is most callers of skb_pull ignore its return
value which essentially means that there is no check on the len
argument.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: Uninline kfree_skb and allow NULL argument

2006-03-21T05:28:35+00:00

o Uninline kfree_skb, which saves some 15k of object code on my notebook.

o Allow kfree_skb to be called with a NULL argument.

  Subsequent patches can remove conditional from drivers and further
  reduce source and object size.

Signed-off-by: J�rn Engel 
Signed-off-by: David S. Miller

[NET]: NETFILTER: remove duplicated lines and fix order in skb_clone().

2006-02-20T06:32:06+00:00

Some of netfilter-related members are initalized / copied twice in
skb_clone(). Remove one.

Pointed out by Olivier MATZ .

And this patch also fixes order of copying / clearing members.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[NET]: Fix skb fclone error path handling.

2006-01-24T00:32:45+00:00

On the error path if we allocated an fclone then we will free it in
the wrong pool.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: Change some "if (x) BUG();" to "BUG_ON(x);"

2006-01-09T22:16:18+00:00

This changes some simple "if (x) BUG();" statements to "BUG_ON(x);"

Signed-off-by: Kris Katterjohn 
Signed-off-by: David S. Miller

[NET]: Speed up __alloc_skb()

2006-01-03T22:06:50+00:00

From: Benjamin LaHaise 

In __alloc_skb(), the use of skb_shinfo() which casts a u8 * to the 
shared info structure results in gcc being forced to do a reload of the 
pointer since it has no information on possible aliasing.  Fix this by 
using a pointer to refer to skb_shared_info.

By initializing skb_shared_info sequentially, the write combining buffers 
can reduce the number of memory transactions to a single write.  Reorder 
the initialization in __alloc_skb() to match the structure definition.  
There is also an alignment issue on 64 bit systems with skb_shared_info 
by converting nr_frags to a short everything packs up nicely.

Also, pass the slab cache pointer according to the fclone flag instead 
of using two almost identical function calls.

This raises bw_unix performance up to a peak of 707KB/s when combined 
with the spinlock patch.  It should help other networking protocols, too.

Signed-off-by: David S. Miller

[NET]: make function pointer argument parseable by kernel-doc

2005-12-05T21:40:12+00:00

When a function takes a function pointer as argument it should use the 'return
(*pointer)(params...)' syntax used everywhere else in the kernel as this is
recognized by kernel-doc.

Signed-off-by: Martin Waitz 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller