linux.git/net/core/netpoll.c, branch v2.6.36

Revert "net: remove zap_completion_queue"

2010-08-03T07:24:04+00:00

This reverts commit 15e83ed78864d0625e87a85f09b297c0919a4797.

As explained by Johannes Berg, the optimization made here is
invalid.  Or, at best, incomplete.

Not only destructor invocation, but conntract entry releasing
must be executed outside of hw IRQ context.

So just checking "skb->destructor" is insufficient.

Signed-off-by: David S. Miller

net/core: EXPORT_SYMBOL cleanups

2010-07-12T19:57:55+00:00

CodingStyle cleanups

EXPORT_SYMBOL should immediately follow the symbol declaration.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: fix "netpoll: Allow netpoll_setup/cleanup recursion"

2010-06-25T03:33:04+00:00

Remove rtnl_unlock() which had no corresponding rtnl_lock().

Signed-off-by: Andrew Morton 
Acked-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Allow netpoll_setup/cleanup recursion

2010-06-15T17:58:40+00:00

This patch adds the functions __netpoll_setup/__netpoll_cleanup
which is designed to be called recursively through ndo_netpoll_seutp.

They must be called with RTNL held, and the caller must initialise
np->dev and ensure that it has a valid reference count.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Add ndo_netpoll_setup

2010-06-15T17:58:39+00:00

This patch adds ndo_netpoll_setup as the initialisation primitive
to complement ndo_netpoll_cleanup.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Add locking for netpoll_setup/cleanup

2010-06-15T17:58:39+00:00

As it stands, netpoll_setup and netpoll_cleanup have no locking
protection whatsoever.  So chaos ensures if two entities try to
perform them on the same device.

This patch adds RTNL to the equation.  The code has been rearranged so
that bits that do not need RTNL protection are now moved to the top of
netpoll_setup.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Fix RCU usage

2010-06-15T17:58:38+00:00

The use of RCU in netpoll is incorrect in a number of places:

1) The initial setting is lacking a write barrier.
2) The synchronize_rcu is in the wrong place.
3) Read barriers are missing.
4) Some places are even missing rcu_read_lock.
5) npinfo is zeroed after freeing.

This patch fixes those issues.  As most users are in BH context,
this also converts the RCU usage to the BH variant.

Signed-off-by: Herbert Xu 
Acked-by: Paul E. McKenney 
Signed-off-by: David S. Miller

netpoll: Set npinfo to NULL even with ndo_netpoll_cleanup

2010-06-15T17:58:37+00:00

Since we have to NULL npinfo regardless of whether there is a
ndo_netpoll_cleanup, it makes sense to do this unconditionally
in netpoll_cleanup rather than having every driver do it by
themselves.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

net: remove zap_completion_queue

2010-05-31T07:24:01+00:00

netpoll does an interesting work in zap_completion_queue(), but this was
before we did skb orphaning before delivering packets to device.

It now makes sense to add a test in dev_kfree_skb_irq() to not queue a
skb if already orphaned, and to remove netpoll zap_completion_queue() as
a bonus.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

netpoll: add generic support for bridge and bonding devices

2010-05-06T07:47:21+00:00

This whole patchset is for adding netpoll support to bridge and bonding
devices. I already tested it for bridge, bonding, bridge over bonding,
and bonding over bridge. It looks fine now.

To make bridge and bonding support netpoll, we need to adjust
some netpoll generic code. This patch does the following things:

1) introduce two new priv_flags for struct net_device:
   IFF_IN_NETPOLL which identifies we are processing a netpoll;
   IFF_DISABLE_NETPOLL is used to disable netpoll support for a device
   at run-time;

2) introduce one new method for netdev_ops:
   ->ndo_netpoll_cleanup() is used to clean up netpoll when a device is
     removed.

3) introduce netpoll_poll_dev() which takes a struct net_device * parameter;
   export netpoll_send_skb() and netpoll_poll_dev() which will be used later;

4) hide a pointer to struct netpoll in struct netpoll_info, ditto.

5) introduce ->real_dev for struct netpoll.

6) introduce a new status NETDEV_BONDING_DESLAE, which is used to disable
   netconsole before releasing a slave, to avoid deadlocks.

Cc: David Miller 
Cc: Neil Horman 
Signed-off-by: WANG Cong 
Signed-off-by: David S. Miller