linux.git/net/core/netpoll.c, branch v2.6.25

netpoll: zap_completion_queue: adjust skb->users counter

2008-03-20T23:07:27+00:00

zap_completion_queue() retrieves skbs from completion_queue where they have
zero skb->users counter.  Before dev_kfree_skb_any() it should be non-zero
yet, so it's increased now.

Reported-and-tested-by: Andrew Morton 
Signed-off-by: Jarek Poplawski 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NETPOLL]: Revert two bogus cleanups that broke netconsole.

2008-03-04T20:28:49+00:00

Based upon a report by Andrew Morton and code analysis done
by Jarek Poplawski.

This reverts 33f807ba0d9259e7c75c7a2ce8bd2787e5b540c7 ("[NETPOLL]:
Kill NETPOLL_RX_DROP, set but never tested.")  and
c7b6ea24b43afb5749cb704e143df19d70e23dea ("[NETPOLL]: Don't need
rx_flags.").

The rx_flags did get tested for zero vs. non-zero and therefore we do
need those tests and that code which sets NETPOLL_RX_DROP et al.

Signed-off-by: David S. Miller

[IPV4] net/core: Use ipv4_is_

2008-01-28T22:58:15+00:00

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[NETPOLL]: Don't need rx_flags.

2008-01-28T22:54:18+00:00

The rx_flags variable is redundant. Turning rx on/off is done
via setting the rx_np pointer.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETPOLL]: Kill NETPOLL_RX_DROP, set but never tested.

2008-01-28T22:54:18+00:00

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETPOLL]: no need to store local_mac

2008-01-28T22:54:17+00:00

The local_mac is managed by the network device, no need to keep a
spare copy and all the management problems that could cause.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETPOLL]: netpoll_poll() cleanup

2008-01-28T22:54:16+00:00

Restructure code slightly to improve readability:
  * dereference device once
  * change obvious while() loop
  * let poll_napi() handle null list itself

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NETPOLL]: Use skb_queue_purge().

2008-01-28T22:54:16+00:00

Use standard routine for flushing queue.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[NET]: Fix race between poll_napi() and net_rx_action()

2007-10-30T05:37:28+00:00

netpoll_poll_lock() synchronizes the ->poll() invocation
code paths, but once we have the lock we have to make
sure that NAPI_STATE_SCHED is still set.  Otherwise we
get:

	cpu 0			cpu 1

	net_rx_action()		poll_napi()
	netpoll_poll_lock()	... spin on ->poll_lock
	->poll()
	  netif_rx_complete
	netpoll_poll_unlock()	acquire ->poll_lock()
				->poll()
				 netif_rx_complete()
				 CRASH

Based upon a bug report from Tina Yang.

Signed-off-by: David S. Miller

[NET]: Hide the queue_mapping field inside netif_subqueue_stopped

2007-10-22T09:59:56+00:00

Many places get the queue_mapping field from skb to pass it to the
netif_subqueue_stopped() which will be 0 in any case.

Make the helper that works with sk_buff

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller