linux.git/net/core/netpoll.c, branch v2.6.22

[NETPOLL]: Fixups for 'fix soft lockup when removing module'

2007-07-06T00:42:44+00:00

>From my recent patch:

> >    #1
> >    Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
> >    required a work function should always (unconditionally) rearm with
> >    delay > 0 - otherwise it would endlessly loop. This patch replaces
> >    this function with cancel_delayed_work(). Later kernel versions don't
> >    require this, so here it's only for uniformity.

But Oleg Nesterov  found:

> But 2.6.22 doesn't need this change, why it was merged?
> 
> In fact, I suspect this change adds a race,
...

His description was right (thanks), so this patch reverts #1.

Signed-off-by: Jarek Poplawski 
Signed-off-by: David S. Miller

[NETPOLL] netconsole: fix soft lockup when removing module

2007-06-29T05:11:47+00:00

#1
Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
required a work function should always (unconditionally) rearm with
delay > 0 - otherwise it would endlessly loop. This patch replaces
this function with cancel_delayed_work(). Later kernel versions don't
require this, so here it's only for uniformity.

#2
After deleting a timer in cancel_[rearming_]delayed_work() there could
stay a last skb queued in npinfo->txq causing a memory leak after
kfree(npinfo).

Initial patch & testing by: Jason Wessel 

Signed-off-by: Jarek Poplawski 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NETPOLL]: tx lock deadlock fix

2007-06-27T07:39:42+00:00

If sky2 device poll routine is called from netpoll_send_skb, it would
deadlock. The netpoll_send_skb held the netif_tx_lock, and the poll
routine could acquire it to clean up skb's. Other drivers might use
same locking model.

The driver is correct, netpoll should not introduce more locking
problems than it causes already. So change the code to drop lock
before calling poll handler.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

header cleaning: don't include smp_lock.h when not used

2007-05-08T18:15:07+00:00

Remove includes of  where it is not used/needed.
Suggested by Al Viro.

Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
sparc64, and arm (all 59 defconfigs).

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NET]: Treat CHECKSUM_PARTIAL as CHECKSUM_UNNECESSARY

2007-04-26T05:28:43+00:00

When a transmitted packet is looped back directly, CHECKSUM_PARTIAL
maps to the semantics of CHECKSUM_UNNECESSARY.  Therefore we should
treat it as such in the stack.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}

2007-04-26T05:28:29+00:00

To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.

Signed-off-by: Arnaldo Carvalho de Melo

[SK_BUFF]: Introduce udp_hdr(), remove skb->h.uh

2007-04-26T05:25:22+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_reset_transport_header(skb)

2007-04-26T05:25:15+00:00

For the common, open coded 'skb->h.raw = skb->data' operation, so that we can
later turn skb->h.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.

This one touches just the most simple cases:

skb->h.raw = skb->data;
skb->h.raw = {skb_push|[__]skb_pull}()

The next ones will handle the slightly more "complex" cases.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce arp_hdr(), remove skb->nh.arph

2007-04-26T05:25:12+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph

2007-04-26T05:25:10+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller