linux.git/net/core/netpoll.c, branch v2.6.20

[PATCH] netpoll: fix netpoll lockup

2006-12-12T16:37:51+00:00

current -git doesnt boot on my laptop due to netpoll not unlocking the
tx lock in the else branch.

booted this up on my laptop with lockdep enabled and there are no
locking complaints and it works fine.

Signed-off-by: Ingo Molnar 
Signed-off-by: Linus Torvalds

[NETPOLL]: Fix local_bh_enable() warning.

2006-12-12T01:24:46+00:00

During boot we get:

netconsole: device eth0 not up yet, forcing it
e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex
WARNING (!__warned) at kernel/softirq.c:137 local_bh_enable()

Call Trace:
 [] local_bh_enable+0x41/0xa3
 [] netpoll_send_skb+0x116/0x144
 [] netpoll_send_udp+0x263/0x271
 [] write_msg+0x42/0x5e
 [] __call_console_drivers+0x5f/0x70
 [] _call_console_drivers+0x6d/0x71
 [] release_console_sem+0x148/0x1ec
 [] register_console+0x1b1/0x1ba
 [] init_netconsole+0x54/0x68
 [] init+0x152/0x308
 [] _spin_unlock_irq+0x14/0x30
 [] schedule_tail+0x43/0x9f
 [] child_rip+0xa/0x12

Herbert sayeth:

  Normally networking isn't invoked with interrupts turned off, but I
  suppose we don't have a choice here.  This is unique being a place where you
  can get called with BH on, off, or IRQs off.

  Given that this is only used for printk, the easiest solution is probably
  just to disable local IRQs instead of BH.

Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[NETPOLL]: Make sure TX lock is taken with BH disabled.

2006-12-11T22:34:36+00:00

Acked-by: Herbert Xu 
Signed-off-by: David S. Miller

[NETPOLL]: make arp replies through netpoll use mac address of sender

2006-12-09T01:19:28+00:00

Back in 2.4 arp requests that were recevied by netpoll were processed
in netconsole_receive_skb, where they were responded to using the src
mac of the request sender.  In the 2.6 kernel arp_reply is responsible
for this function, but instead of using the src mac address of the
incomming request, the stored mac address that was registered for the
netconsole application is used.  While this is usually ok, it can lead
to failures in netpoll in some situations (specifically situations
where a network may have two gateways, as arp requests from one may be
responded to using the mac address of the other).  This patch reverts
the behavior to what we had in 2.4, in which all arp requests are sent
back using the src address of the request sender.

Signed-off-by: Neil Horman 
Acked-by: Chris Lalancette 
Signed-off-by: David S. Miller

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

2006-12-05T14:37:56+00:00

Conflicts:

	drivers/infiniband/core/iwcm.c
	drivers/net/chelsio/cxgb2.c
	drivers/net/wireless/bcm43xx/bcm43xx_main.c
	drivers/net/wireless/prism54/islpci_eth.c
	drivers/usb/core/hub.h
	drivers/usb/input/hid-core.c
	net/core/netpoll.c

Fix up merge failures with Linus's head and fix new compilation failures.

Signed-Off-By: David Howells

[NETPOLL]: Another udp checksum mangling.

2006-12-03T05:27:20+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[NET]: Annotate __skb_checksum_complete() and friends.

2006-12-03T05:23:38+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[NET]: Annotate callers of csum_tcpudp_nofold() in net/*

2006-12-03T05:23:28+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[NET]: Annotate callers of csum_fold() in net/*

2006-12-03T05:23:27+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[NET] net/core: Annotations.

2006-12-03T05:22:49+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller