linux.git/net/core/flow_offload.c, branch v5.15

net: Fix offloading indirect devices dependency on qdisc order creation

2021-08-19T12:19:30+00:00

Currently, when creating an ingress qdisc on an indirect device before
the driver registered for callbacks, the driver will not have a chance
to register its filter configuration callbacks.

To fix that, modify the code such that it keeps track of all the ingress
qdiscs that call flow_indr_dev_setup_offload(). When a driver calls
flow_indr_dev_register(),  go through the list of tracked ingress qdiscs
and call the driver callback entry point so as to give it a chance to
register its callback.

Reviewed-by: Jiri Pirko 
Signed-off-by: Eli Cohen 
Signed-off-by: David S. Miller

net/core: Remove unused field from struct flow_indr_dev

2021-08-19T12:19:30+00:00

rcu field is not used. Remove it.

Reviewed-by: Jiri Pirko 
Signed-off-by: Eli Cohen 
Signed-off-by: David S. Miller

net: flow_offload: Fix memory leak for indirect flow block

2020-12-10T00:08:33+00:00

The offending commit introduces a cleanup callback that is invoked
when the driver module is removed to clean up the tunnel device
flow block. But it returns on the first iteration of the for loop.
The remaining indirect flow blocks will never be freed.

Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
CC: Pablo Neira Ayuso 
Signed-off-by: Chris Mi 
Reviewed-by: Roi Dayan

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-07-26T00:49:04+00:00

The UDP reuseport conflict was a little bit tricky.

The net-next code, via bpf-next, extracted the reuseport handling
into a helper so that the BPF sk lookup code could invoke it.

At the same time, the logic for reuseport handling of unconnected
sockets changed via commit efc6b6f6c3113e8b203b9debfb72d81e0f3dcace
which changed the logic to carry on the reuseport result into the
rest of the lookup loop if we do not return immediately.

This requires moving the reuseport_has_conns() logic into the callers.

While we are here, get rid of inline directives as they do not belong
in foo.c files.

The other changes were cases of more straightforward overlapping
modifications.

Signed-off-by: David S. Miller

flow_offload: Move rhashtable inclusion to the source file

2020-07-24T22:17:22+00:00

I noticed that touching linux/rhashtable.h causes lib/vsprintf.c to
be rebuilt.  This dependency came through a bogus inclusion in the
file net/flow_offload.h.  This patch moves it to the right place.

This patch also removes a lingering rhashtable inclusion in cls_api
created by the same commit.

Fixes: 4e481908c51b ("flow_offload: move tc indirect block to...")
Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

net: sched: Pass qdisc reference in struct flow_block_offload

2020-07-14T00:22:21+00:00

Previously, shared blocks were only relevant for the pseudo-qdiscs ingress
and clsact. Recently, a qevent facility was introduced, which allows to
bind blocks to well-defined slots of a qdisc instance. RED in particular
got two qevents: early_drop and mark. Drivers that wish to offload these
blocks will be sent the usual notification, and need to know which qdisc it
is related to.

To that end, extend flow_block_offload with a "sch" pointer, and initialize
as appropriate. This prompts changes in the indirect block facility, which
now tracks the scheduler in addition to the netdevice. Update signatures of
several functions similarly.

Signed-off-by: Petr Machata 
Signed-off-by: David S. Miller

net: flow_offload: fix flow_indr_dev_unregister path

2020-06-20T03:12:58+00:00

If the representor is removed, then identify the indirect flow_blocks
that need to be removed by the release callback and the port representor
structure. To identify the port representor structure, a new
indr.cb_priv field needs to be introduced. The flow_block also needs to
be removed from the driver list from the cleanup path.

Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")

Signed-off-by: wenxu 
Signed-off-by: David S. Miller

flow_offload: use flow_indr_block_cb_alloc/remove function

2020-06-20T03:12:58+00:00

Prepare fix the bug in the next patch. use flow_indr_block_cb_alloc/remove
function and remove the __flow_block_indr_binding.

Signed-off-by: wenxu 
Signed-off-by: David S. Miller

flow_offload: add flow_indr_block_cb_alloc/remove function

2020-06-20T03:12:58+00:00

Add flow_indr_block_cb_alloc/remove function for next fix patch.

Signed-off-by: wenxu 
Signed-off-by: David S. Miller

net: remove indirect block netdev event registration

2020-06-01T18:41:50+00:00

Drivers do not register to netdev events to set up indirect blocks
anymore. Remove __flow_indr_block_cb_register() and
__flow_indr_block_cb_unregister().

The frontends set up the callbacks through flow_indr_dev_setup_block()

Signed-off-by: Pablo Neira Ayuso 
Signed-off-by: David S. Miller