linux.git/net/core/fib_rules.c, branch v4.19

fib_rules: NULL check before kfree is not needed

2018-07-30T16:44:06+00:00

kfree(NULL) is safe,so this removes NULL check before freeing the mem

Signed-off-by: YueHaibing 
Signed-off-by: David S. Miller

net: fib_rules: bring back rule_exists to match rule during add

2018-06-30T13:11:13+00:00

After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule
delrule msgs into fib_nl2rule"), rule_exists got replaced by rule_find
for existing rule lookup in both the add and del paths. While this
is good for the delete path, it solves a few problems but opens up
a few invalid key matches in the add path.

$ip -4 rule add table main tos 10 fwmark 1
$ip -4 rule add table main tos 10
RTNETLINK answers: File exists

The problem here is rule_find does not check if the key masks in
the new and old rule are the same and hence ends up matching a more
secific rule. Rule key masks cannot be easily compared today without
an elaborate if-else block. Its best to introduce key masks for easier
and accurate rule comparison in the future. Until then, due to fear of
regressions this patch re-introduces older loose rule_exists during add.
Also fixes both rule_exists and rule_find to cover missing attributes.

Fixes: f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule")
Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller

fib_rules: match rules based on suppress_* properties too

2018-06-27T01:33:05+00:00

Two rules with different values of suppress_prefix or suppress_ifgroup
are not the same. This fixes an -EEXIST when running:

   $ ip -4 rule add table main suppress_prefixlength 0

Signed-off-by: Jason A. Donenfeld 
Fixes: f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule")
Signed-off-by: David S. Miller

net: rules: Move l3mdev attribute validation to a helper

2018-04-25T17:26:12+00:00

Move the check on FRA_L3MDEV attribute to helper to improve the
readability of fib_nl2rule. Update the extack messages to be
clear when the configuration option is disabled versus an invalid
value has been passed.

Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

net: fib_rules: fix l3mdev netlink attr processing

2018-04-24T03:20:12+00:00

Fixes: b16fb418b1bf ("net: fib_rules: add extack support")
Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller

net: fib_rules: add extack support

2018-04-23T14:21:24+00:00

Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller

fib_rules: move common handling of newrule delrule msgs into fib_nl2rule

2018-04-23T14:21:24+00:00

This reduces code duplication in the fib rule add and del paths.
Get rid of validate_rulemsg. This became obvious when adding duplicate
extack support in fib newrule/delrule error paths.

Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller

net: Move call_fib_rule_notifiers up in fib_nl_newrule

2018-03-29T18:10:30+00:00

Move call_fib_rule_notifiers up in fib_nl_newrule to the point right
before the rule is inserted into the list. At this point there are no
more failure paths within the core rule code, so if the notifier
does not fail then the rule will be inserted into the list.

Signed-off-by: David Ahern 
Reviewed-by: Ido Schimmel 
Signed-off-by: David S. Miller

net: Drop pernet_operations::async

2018-03-27T17:18:09+00:00

Synchronous pernet_operations are not allowed anymore.
All are asynchronous. So, drop the structure member.

Signed-off-by: Kirill Tkhai 
Signed-off-by: David S. Miller

net: fib_rules: support for match on ip_proto, sport and dport

2018-03-01T03:44:43+00:00

uapi for ip_proto, sport and dport range match
in fib rules.

Signed-off-by: Roopa Prabhu 
Acked-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller