linux.git/net/core/fib_rules.c, branch v2.6.23

[RTNETLINK]: Remove unnecessary locking in dump callbacks

2007-04-26T05:29:05+00:00

Since we're now holding the rtnl during the entire dump operation, we can
remove additional locking for rtnl protected data. This patch does that
for all simple cases (dev_base_lock for dev_base walking, RCU protection
for FIB rule dumping).

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET] fib_rules: Flush route cache after rule modifications

2007-04-26T05:28:18+00:00

The results of FIB rules lookups are cached in the routing cache
except for IPv6 as no such cache exists. So far, it was the
responsibility of the user to flush the cache after modifying any
rules. This lead to many false bug reports due to misunderstanding
of this concept.

This patch automatically flushes the route cache after inserting
or deleting a rule.

Thanks to Muli Ben-Yehuda  for catching a bug
in the previous patch.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET] fib_rules: Add no-operation action

2007-04-26T05:28:14+00:00

The use of nop rules simplifies the usage of goto rules
and adds more flexibility as they allow targets to remain
while the actual content of the branches can change easly.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET] fib_rules: Mark rules detached from the device

2007-04-26T05:28:13+00:00

Rules which match against device names in their selector can
remain while the device itself disappears, in fact the device
doesn't have to present when the rule is added in the first
place. The device name is resolved by trying when the rule is
added and later by listening to NETDEV_REGISTER/UNREGISTER
notifications.

This patch adds the flag FIB_RULE_DEV_DETACHED which is set
towards userspace when a rule contains a device match which
is unresolved at the moment. This eases spotting the reason
why certain rules seem not to function properly.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET] fib_rules: goto rule action

2007-04-26T05:28:12+00:00

This patch adds a new rule action FR_ACT_GOTO which allows
to skip a set of rules by jumping to another rule. The rule
to jump to is specified via the FRA_GOTO attribute which
carries a rule preference.

Referring to a rule which doesn't exists is explicitely allowed.
Such goto rules are marked with the flag FIB_RULE_UNRESOLVED
and will act like a rule with a non-matching selector. The rule
will become functional as soon as its target is present.

The goto action enables performance optimizations by reducing
the average number of rules that have to be passed per lookup.

Example:
0:      from all lookup local
40:     not from all to 192.168.23.128 goto 32766
41:     from all fwmark 0xa blackhole
42:     from all fwmark 0xff blackhole
32766:  from all lookup main

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET] rules: Unified rules dumping

2007-04-26T05:27:17+00:00

Implements a unified, protocol independant rules dumping function
which is capable of both, dumping a specific protocol family or
all of them. This speeds up dumping as less lookups are required.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET] rules: Use rtnl registration interface

2007-04-26T05:27:07+00:00

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET]: Change "not found" return value for rule lookup

2007-04-02T20:30:51+00:00

This changes the "not found" error return for the lookup
function to -ESRCH so that it can be distinguished from
the case where a rule or route resulting in -ENETUNREACH
has been found during the search.

It fixes a bug where if DECnet was compiled with routing
support, but no routes were added to the routing table,
it was failing to fall back to endnode routing.

Signed-off-by: Steven Whitehouse 
Signed-off-by: Patrick Caulfield 
Signed-off-by: David S. Miller

[NET]: Fix fib_rules compatibility breakage

2007-03-26T01:48:00+00:00

Based upon a patch from Patrick McHardy.

The fib_rules netlink attribute policy introduced in 2.6.19 broke
userspace compatibilty. When specifying a rule with "from all"
or "to all", iproute adds a zero byte long netlink attribute,
but the policy requires all addresses to have a size equal to
sizeof(struct in_addr)/sizeof(struct in6_addr), resulting in a
validation error.

Check attribute length of FRA_SRC/FRA_DST in the generic framework
by letting the family specific rules implementation provide the
length of an address. Report an error if address length is non
zero but no address attribute is provided. Fix actual bug by
checking address length for non-zero instead of relying on
availability of attribute.

Signed-off-by: Thomas Graf 
Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET]: Fix fib_rules dump race

2007-03-22T19:24:38+00:00

fib_rules_dump needs to use list_for_each_entry_rcu to protect against
concurrent changes to the rules list.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller