linux.git/net/core/ethtool.c, branch v5.1

net: ethtool: not call vzalloc for zero sized memory request

2019-03-29T20:41:55+00:00

NULL or ZERO_SIZE_PTR will be returned for zero sized memory
request, and derefencing them will lead to a segfault

so it is unnecessory to call vzalloc for zero sized memory
request and not call functions which maybe derefence the
NULL allocated memory

this also fixes a possible memory leak if phy_ethtool_get_stats
returns error, memory should be freed before exit

Signed-off-by: Li RongQing 
Reviewed-by: Wang Li 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: reduce stack usage with clang

2019-03-07T17:45:21+00:00

clang inlines the dev_ethtool() more aggressively than gcc does, leading
to a larger amount of used stack space:

net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=]

Marking the sub-functions that require the most stack space as
noinline_for_stack gives us reasonable behavior on all compilers.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller

ethtool: Use explicit designated initializers for .cmd

2019-02-27T18:07:57+00:00

Initialize the .cmd member by using a designated struct
initializer. This fixes warning of missing field initializers,
and makes code a little easier to read.

Signed-off-by: Li RongQing 
Reviewed-by: Michal Kubecek 
Signed-off-by: David S. Miller

devlink: hold a reference to the netdevice around ethtool compat

2019-02-26T16:49:05+00:00

When ethtool is calling into devlink compat code make sure we have
a reference on the netdevice on which the operation was invoked.

v3: move the hold/lock logic into devlink_compat_* functions (Florian)

Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: add compat for flash update

2019-02-17T23:27:38+00:00

If driver does not support ethtool flash update operation
call into devlink.

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

2019-02-09T07:05:18+00:00

net/core/ethtool.c:3023:19: warning: address of array
'ext_m_spec->h_dest' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                if (ext_m_spec->h_dest) {
                ~~  ~~~~~~~~~~~~^~~~~~

h_dest is an array, it can't be null so remove this check.

Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
Link: https://github.com/ClangBuiltLinux/linux/issues/353
Signed-off-by: Nathan Chancellor 
Acked-by: Pablo Neira Ayuso 
Signed-off-by: David S. Miller

ethtool: add ethtool_rx_flow_spec to flow_rule structure translator

2019-02-06T18:38:26+00:00

This patch adds a function to translate the ethtool_rx_flow_spec
structure to the flow_rule representation.

This allows us to reuse code from the driver side given that both flower
and ethtool_rx_flow interfaces use the same representation.

This patch also includes support for the flow type flags FLOW_EXT,
FLOW_MAC_EXT and FLOW_RSS.

The ethtool_rx_flow_spec_input wrapper structure is used to convey the
rss_context field, that is away from the ethtool_rx_flow_spec structure,
and the ethtool_rx_flow_spec structure.

Signed-off-by: Pablo Neira Ayuso 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: add compat for devlink info

2019-02-01T23:30:31+00:00

If driver did not fill the fw_version field, try to call into
the new devlink get_info op and collect the versions that way.
We assume ethtool was always reporting running versions.

v4:
 - use IS_REACHABLE() to avoid problems with DEVLINK=m (kbuildbot).
v3 (Jiri):
 - do a dump and then parse it instead of special handling;
 - concatenate all versions (well, all that fit :)).

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: remove unnecessary check in ethtool_get_regs()

2019-02-01T17:58:07+00:00

We recently changed this function in commit f9fc54d313fa ("ethtool:
check the return value of get_regs_len") such that if "reglen" is zero
we return directly.  That means we can remove this condition as well.

Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

ethtool: check the return value of get_regs_len

2018-12-29T05:24:56+00:00

The return type for get_regs_len in struct ethtool_ops is int,
the hns3 driver may return error when failing to get the regs
len by sending cmd to firmware.

Signed-off-by: Yunsheng Lin 
Signed-off-by: David S. Miller