linux.git/net/core/ethtool.c, branch v2.6.39

net: fix ethtool->set_flags not intended -EINVAL return value

2011-03-28T06:35:24+00:00

After commit d5dbda23804156ae6f35025ade5307a49d1db6d7 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka 
Signed-off-by: David S. Miller

net: implement dev_disable_lro() hw_features compatibility

2011-03-22T08:00:26+00:00

Implement compatibility with new hw_features for dev_disable_lro().
This is a transition path - dev_disable_lro() should be later
integrated into netdev_fix_features() after all drivers are converted.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

ethtool: __ethtool_set_sg: check for function pointer before using it

2011-03-18T22:13:10+00:00

__ethtool_set_sg does not check if dev->ethtool_ops->set_sg is defined
which can result in a NULL pointer dereference when ethtool is used to
change SG settings for drivers without SG support.

Signed-off-by: Roger Luethi 
Reviewed-by: Ben Hutchings 
Signed-off-by: David S. Miller

net: Implement SFEATURES compatibility for not updated drivers

2011-02-23T22:23:32+00:00

Use discrete setting ops for not updated drivers. This will not make
them conform to full G/SFEATURES semantics, though.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

net: Fix ETHTOOL_GFEATURES compatibility

2011-02-23T22:23:32+00:00

Implement getting rx checksum state for not updated drivers.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

net: introduce NETIF_F_RXCSUM

2011-02-17T22:16:35+00:00

Introduce NETIF_F_RXCSUM to replace device-private flags for RX checksum
offload. Integrate it with ndo_fix_features.

ethtool_op_get_rx_csum() is removed altogether as nothing in-tree uses it.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

net: use ndo_fix_features for ethtool_ops->set_flags

2011-02-17T22:16:34+00:00

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

net: ethtool: use ndo_fix_features for offload setting

2011-02-17T22:16:34+00:00

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

net: Introduce new feature setting ops

2011-02-17T22:16:33+00:00

This introduces a new framework to handle device features setting.
It consists of:
  - new fields in struct net_device:
	+ hw_features - features that hw/driver supports toggling
	+ wanted_features - features that user wants enabled, when possible
  - new netdev_ops:
	+ feat = ndo_fix_features(dev, feat) - API checking constraints for
		enabling features or their combinations
	+ ndo_set_features(dev) - API updating hardware state to match
		changed dev->features
  - new ethtool commands:
	+ ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
		and trigger device reconfiguration if resulting dev->features
		changed
	+ ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

ethtool: factorize get/set_one_feature

2011-02-17T22:16:33+00:00

This allows to enable GRO even if RX csum is disabled. GRO will not
be used for packets without hardware checksum anyway.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller