linux.git/net/core/devlink.c, branch v5.4-rc2

devlink: Fix error handling in param and info_get dumpit cb

2019-10-01T17:08:30+00:00

If any of the param or info_get op returns error, dumpit cb is
skipping to dump remaining params or info_get ops for all the
drivers.

Fix to not return if any of the param/info_get op returns error
as not supported and continue to dump remaining information.

v2: Modify the patch to return error, except for params/info_get
op that return -EOPNOTSUPP as suggested by Andrew Lunn. Also, modify
commit message to reflect the same.

Cc: Andrew Lunn 
Cc: Jiri Pirko 
Cc: Michael Chan 
Signed-off-by: Vasundhara Volam 
Acked-by: Jiri Pirko 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: devlink: move reload fail indication to devlink core and expose to user

2019-09-13T20:11:14+00:00

Currently the fact that devlink reload failed is stored in drivers.
Move this flag into devlink core. Also, expose it to the user.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: devlink: split reload op into two

2019-09-13T20:11:14+00:00

In order to properly implement failure indication during reload,
split the reload op into two ops, one for down phase and one for
up phase.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: add 'reset_dev_on_drv_probe' param

2019-09-10T16:29:26+00:00

Add the 'reset_dev_on_drv_probe' devlink parameter, controlling the
device reset policy on driver probe.

This parameter is useful in conjunction with the existing
'fw_load_policy' parameter.

Signed-off-by: Dirk van der Merwe 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Simon Horman 
Signed-off-by: David S. Miller

devlink: Use switch-case instead of if-else

2019-09-01T06:46:13+00:00

Make core more readable with switch-case for various port flavours.

Acked-by: Jiri Pirko 
Signed-off-by: Parav Pandit 
Signed-off-by: David S. Miller

devlink: Make port index data type as unsigned int

2019-09-01T06:46:13+00:00

Devlink port index attribute is returned to users as u32 through
netlink response.
Change index data type from 'unsigned' to 'unsigned int' to avoid
below checkpatch.pl warning.

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
81: FILE: include/net/devlink.h:81:
+       unsigned index;

Acked-by: Jiri Pirko 
Signed-off-by: Parav Pandit 
Signed-off-by: David S. Miller

devlink: Add generic packet traps and groups

2019-08-17T19:40:08+00:00

Add generic packet traps and groups that can report dropped packets as
well as exceptions such as TTL error.

Signed-off-by: Ido Schimmel 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: Add packet trap infrastructure

2019-08-17T19:40:08+00:00

Add the basic packet trap infrastructure that allows device drivers to
register their supported packet traps and trap groups with devlink.

Each driver is expected to provide basic information about each
supported trap, such as name and ID, but also the supported metadata
types that will accompany each packet trapped via the trap. The
currently supported metadata type is just the input port, but more will
be added in the future. For example, output port and traffic class.

Trap groups allow users to set the action of all member traps. In
addition, users can retrieve per-group statistics in case per-trap
statistics are too narrow. In the future, the trap group object can be
extended with more attributes, such as policer settings which will limit
the amount of traffic generated by member traps towards the CPU.

Beside registering their packet traps with devlink, drivers are also
expected to report trapped packets to devlink along with relevant
metadata. devlink will maintain packets and bytes statistics for each
packet trap and will potentially report the trapped packet with its
metadata to user space via drop monitor netlink channel.

The interface towards the drivers is simple and allows devlink to set
the action of the trap. Currently, only two actions are supported:
'trap' and 'drop'. When set to 'trap', the device is expected to provide
the sole copy of the packet to the driver which will pass it to devlink.
When set to 'drop', the device is expected to drop the packet and not
send a copy to the driver. In the future, more actions can be added,
such as 'mirror'.

Signed-off-by: Ido Schimmel 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: devlink: remove redundant rtnl lock assert

2019-08-13T23:47:11+00:00

It is enough for caller of devlink_compat_switch_id_get() to hold the net
device to guarantee that devlink port is not destroyed concurrently. Remove
rtnl lock assertion and modify comment to warn user that they must hold
either rtnl lock or reference to net device. This is necessary to
accommodate future implementation of rtnl-unlocked TC offloads driver
callbacks.

Signed-off-by: Vlad Buslov 
Acked-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski

devlink: send notifications for deleted snapshots on region destroy

2019-08-13T21:55:46+00:00

Currently the notifications for deleted snapshots are sent only in case
user deletes a snapshot manually. Send the notifications in case region
is destroyed too.

Signed-off-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski