linux.git/net/core/devlink.c, branch v5.1

net: devlink: skip info_get op call if it is not defined in dumpit

2019-03-26T18:25:29+00:00

In dumpit, unlike doit, the check for info_get op being defined
is missing. Add it and avoid null pointer dereference in case driver
does not define this op.

Fixes: f9cf22882c60 ("devlink: add device information API")
Reported-by: Ido Schimmel 
Signed-off-by: Jiri Pirko 
Acked-by: Jakub Kicinski 
Signed-off-by: David S. Miller

devlink: Add support for direct reporter health state update

2019-03-04T19:00:43+00:00

It is possible that a reporter state will be updated due to a recover flow
which is not triggered by a devlink health related operation, but as a side
effect of some other operation in the system.

Expose devlink health API for a direct update of a reporter status.

Move devlink_health_reporter_state enum definition to devlink.h so it could
be used from drivers as a parameter of devlink_health_reporter_state_update.

In addition, add trace_devlink_health_reporter_state_update to provide user
notification for reporter state change.

Signed-off-by: Eran Ben Elisha 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: Update reporter state to error even if recover aborted

2019-03-04T19:00:43+00:00

If devlink_health_report() aborted the recover flow due to grace period checker,
it left the reporter status as DEVLINK_HEALTH_REPORTER_STATE_HEALTHY, which is
a bug. Fix that by always setting the reporter state to
DEVLINK_HEALTH_REPORTER_STATE_ERROR prior to running the checker mentioned above.

In addition, save the previous health_state in a temporary variable, then use
it in the abort check comparison instead of using reporter->health_state which
might be already changed.

Fixes: c8e1da0bf923 ("devlink: Add health report functionality")
Signed-off-by: Eran Ben Elisha 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: fix kdoc

2019-03-02T01:00:22+00:00

devlink suffers from a few kdoc warnings:

net/core/devlink.c:5292: warning: Function parameter or member 'dev' not described in 'devlink_register'
net/core/devlink.c:5351: warning: Function parameter or member 'port_index' not described in 'devlink_port_register'
net/core/devlink.c:5753: warning: Function parameter or member 'parent_resource_id' not described in 'devlink_resource_register'
net/core/devlink.c:5753: warning: Function parameter or member 'size_params' not described in 'devlink_resource_register'
net/core/devlink.c:5753: warning: Excess function parameter 'top_hierarchy' description in 'devlink_resource_register'
net/core/devlink.c:5753: warning: Excess function parameter 'reload_required' description in 'devlink_resource_register'
net/core/devlink.c:5753: warning: Excess function parameter 'parent_reosurce_id' description in 'devlink_resource_register'
net/core/devlink.c:6451: warning: Function parameter or member 'region' not described in 'devlink_region_snapshot_create'
net/core/devlink.c:6451: warning: Excess function parameter 'devlink_region' description in 'devlink_region_snapshot_create'

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: require non-NULL ops for devlink instances

2019-02-26T16:49:05+00:00

Commit 76726ccb7f46 ("devlink: add flash update command") and
commit 2d8dc5bbf4e7 ("devlink: Add support for reload")
access devlink ops without NULL-checking. There is, however, no
driver which would pass in NULL ops, so let's just make that
a requirement. Remove the now unnecessary NULL-checking.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: hold a reference to the netdevice around ethtool compat

2019-02-26T16:49:05+00:00

When ethtool is calling into devlink compat code make sure we have
a reference on the netdevice on which the operation was invoked.

v3: move the hold/lock logic into devlink_compat_* functions (Florian)

Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: create a special NDO for getting the devlink instance

2019-02-26T16:49:05+00:00

Instead of iterating over all devlink ports add a NDO which
will return the devlink instance from the driver.

v2: add the netdev_to_devlink() helper (Michal)
v3: check that devlink has ops (Florian)
v4: hold devlink_mutex (Jiri)

Suggested-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: devlink: turn devlink into a built-in

2019-02-26T16:49:05+00:00

Being able to build devlink as a module causes growing pains.
First all drivers had to add a meta dependency to make sure
they are not built in when devlink is built as a module.  Now
we are struggling to invoke ethtool compat code reliably.

Make devlink code built-in, users can still not build it at
all but the dynamically loadable module option is removed.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: Modify reply of DEVLINK_CMD_HEALTH_REPORTER_GET

2019-02-21T18:38:51+00:00

Avoid sending attributes related to recovery:
DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD and
DEVLINK_ATTR_HEALTH_REPORTER_AUTO_RECOVER in reply to
DEVLINK_CMD_HEALTH_REPORTER_GET for a reporter which didn't register a
recover operation.
These parameters can't be configured on a reporter that did not provide
a recover operation, thus not needed to return them.

Fixes: 7afe335a8bed ("devlink: Add health get command")
Signed-off-by: Aya Levin 
Signed-off-by: Eran Ben Elisha 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: Rename devlink health attributes

2019-02-21T18:38:51+00:00

Rename devlink health attributes for better reflect the attributes use.
Add COUNT prefix on error counter attribute and recovery counter
attribute.

Fixes: 7afe335a8bed ("devlink: Add health get command")
Signed-off-by: Aya Levin 
Signed-off-by: Eran Ben Elisha 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller