linux.git/net/core/dev.c, branch v3.12-rc2

net: correctly interlink lower/upper devices

2013-09-04T04:27:26+00:00

Currently we're linking upper devices to lower ones, which results in
upside-down relationship: upper devices seeing lower devices via its upper
lists.

Fix this by correctly linking lower devices to the upper ones.

CC: "David S. Miller" 
CC: Eric Dumazet 
CC: Jiri Pirko 
CC: Alexander Duyck 
CC: Cong Wang 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

skb: allow skb_scrub_packet() to be used by tunnels

2013-09-04T04:27:25+00:00

This function was only used when a packet was sent to another netns. Now, it can
also be used after tunnel encapsulation or decapsulation.

Only skb_orphan() should not be done when a packet is not crossing netns.

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

net: add netdev_upper_get_next_dev_rcu(dev, iter)

2013-08-29T20:19:42+00:00

This function returns the next dev in the dev->upper_dev_list after the
struct list_head **iter position, and updates *iter accordingly. Returns
NULL if there are no devices left.

Caller must hold RCU read lock.

CC: "David S. Miller" 
CC: Eric Dumazet 
CC: Jiri Pirko 
CC: Alexander Duyck 
CC: Cong Wang 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

net: remove search_list from netdev_adjacent

2013-08-29T20:19:42+00:00

We already don't need it cause we see every upper/lower device in the list
already.

CC: "David S. Miller" 
CC: Eric Dumazet 
CC: Jiri Pirko 
CC: Alexander Duyck 
CC: Cong Wang 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

net: add lower_dev_list to net_device and make a full mesh

2013-08-29T20:19:42+00:00

This patch adds lower_dev_list list_head to net_device, which is the same
as upper_dev_list, only for lower devices, and begins to use it in the same
way as the upper list.

It also changes the way the whole adjacent device lists work - now they
contain *all* of upper/lower devices, not only the first level. The first
level devices are distinguished by the bool neighbour field in
netdev_adjacent, also added by this patch.

There are cases when a device can be added several times to the adjacent
list, the simplest would be:

     /---- eth0.10 ---\
eth0-		       --- bond0
     \---- eth0.20 ---/

where both bond0 and eth0 'see' each other in the adjacent lists two times.
To avoid duplication of netdev_adjacent structures ref_nr is being kept as
the number of times the device was added to the list.

The 'full view' is achieved by adding, on link creation, all of the
upper_dev's upper_dev_list devices as upper devices to all of the
lower_dev's lower_dev_list devices (and to the lower_dev itself), and vice
versa. On unlink they are removed using the same logic.

I've tested it with thousands vlans/bonds/bridges, everything works ok and
no observable lags even on a huge number of interfaces.

Memory footprint for 128 devices interconnected with each other via both
upper and lower (which is impossible, but for the comparison) lists would be:

128*128*2*sizeof(netdev_adjacent) = 1.5MB

but in the real world we usualy have at most several devices with slaves
and a lot of vlans, so the footprint will be much lower.

CC: "David S. Miller" 
CC: Eric Dumazet 
CC: Jiri Pirko 
CC: Alexander Duyck 
CC: Cong Wang 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

net: rename netdev_upper to netdev_adjacent

2013-08-29T20:19:41+00:00

Rename the structure to reflect the upcoming addition of lower_dev_list.

CC: "David S. Miller" 
CC: Eric Dumazet 
CC: Jiri Pirko 
CC: Alexander Duyck 
CC: Cong Wang 
Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

dev: move skb_scrub_packet() after eth_type_trans()

2013-08-15T08:00:20+00:00

skb_scrub_packet() was called before eth_type_trans() to let eth_type_trans()
set pkt_type.

In fact, we should force pkt_type to PACKET_HOST, so move the call after
eth_type_trans().

Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

net: add ndo to get id of physical port of the device

2013-07-31T00:31:24+00:00

This patch adds a ndo for getting physical port of the device. Driver
which is aware of being virtual function of some physical port should
implement this ndo. This is applicable not only for IOV, but for other
solutions (NPAR, multichannel) as well. Basically if there is possible
to have multiple netdevs on the single hw port.

Signed-off-by: Jiri Pirko 
Acked-by: Ben Hutchings 
Signed-off-by: David S. Miller

net: Make devnet_rename_seq static

2013-07-25T00:57:26+00:00

No users outside net/core/dev.c.

Signed-off-by: Thomas Gleixner 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

vlan: mask vlan prio bits

2013-07-18T20:05:23+00:00

In commit 48cc32d38a52d0b68f91a171a8d00531edc6a46e
("vlan: don't deliver frames for unknown vlans to protocols")
Florian made sure we set pkt_type to PACKET_OTHERHOST
if the vlan id is set and we could find a vlan device for this
particular id.

But we also have a problem if prio bits are set.

Steinar reported an issue on a router receiving IPv6 frames with a
vlan tag of 4000 (id 0, prio 2), and tunneled into a sit device,
because skb->vlan_tci is set.

Forwarded frame is completely corrupted : We can see (8100:4000)
being inserted in the middle of IPv6 source address :

16:48:00.780413 IP6 2001:16d8:8100:4000:ee1c:0:9d9:bc87 >
9f94:4d95:2001:67c:29f4::: ICMP6, unknown icmp6 type (0), length 64
       0x0000:  0000 0029 8000 c7c3 7103 0001 a0ae e651
       0x0010:  0000 0000 ccce 0b00 0000 0000 1011 1213
       0x0020:  1415 1617 1819 1a1b 1c1d 1e1f 2021 2223
       0x0030:  2425 2627 2829 2a2b 2c2d 2e2f 3031 3233

It seems we are not really ready to properly cope with this right now.

We can probably do better in future kernels :
vlan_get_ingress_priority() should be a netdev property instead of
a per vlan_dev one.

For stable kernels, lets clear vlan_tci to fix the bugs.

Reported-by: Steinar H. Gunderson 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller