linux.git/net/ceph/osd_client.c, branch v3.18

libceph: change from BUG to WARN for __remove_osd() asserts

2014-11-13T19:26:34+00:00

No reason to use BUG_ON for osd request list assertions.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: clear r_req_lru_item in __unregister_linger_request()

2014-11-13T19:21:14+00:00

kick_requests() can put linger requests on the notarget list.  This
means we need to clear the much-overloaded req->r_req_lru_item in
__unregister_linger_request() as well, or we get an assertion failure
in ceph_osdc_release_request() - !list_empty(&req->r_req_lru_item).

AFAICT the assumption was that registered linger requests cannot be on
any of req->r_req_lru_item lists, but that's clearly not the case.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: unlink from o_linger_requests when clearing r_osd

2014-11-13T19:21:13+00:00

Requests have to be unlinked from both osd->o_requests (normal
requests) and osd->o_linger_requests (linger requests) lists when
clearing req->r_osd.  Otherwise __unregister_linger_request() gets
confused and we trip over a !list_empty(&osd->o_linger_requests)
assert in __remove_osd().

MON=1 OSD=1:

    # cat remove-osd.sh
    #!/bin/bash
    rbd create --size 1 test
    DEV=$(rbd map test)
    ceph osd out 0
    sleep 3
    rbd map dne/dne # obtain a new osdmap as a side effect
    rbd unmap $DEV & # will block
    sleep 3
    ceph osd in 0

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: sync osd op definitions in rados.h

2014-10-14T19:57:02+00:00

Bring in missing osd ops and strings, use macros to eliminate multiple
points of maintenance.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Sage Weil

libceph: don't try checking queue_work() return value

2014-10-14T17:03:25+00:00

queue_work() doesn't "fail to queue", it returns false if work was
already on a queue, which can't happen here since we allocate
event_work right before we queue it.  So don't bother at all.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: Convert pr_warning to pr_warn

2014-10-14T17:03:23+00:00

Use the more common pr_warn.

Other miscellanea:

o Coalesce formats
o Realign arguments

Signed-off-by: Joe Perches 
Signed-off-by: Ilya Dryomov

libceph: resend lingering requests with a new tid

2014-10-14T17:03:19+00:00

Both not yet registered (r_linger && list_empty(&r_linger_item)) and
registered linger requests should use the new tid on resend to avoid
the dup op detection logic on the OSDs, yet we were doing this only for
"registered" case.  Factor out and simplify the "registered" logic and
use the new helper for "not registered" case as well.

Fixes: http://tracker.ceph.com/issues/8806

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: abstract out ceph_osd_request enqueue logic

2014-10-14T17:03:18+00:00

Introduce __enqueue_request() and switch to it.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: nuke ceph_osdc_unregister_linger_request()

2014-07-08T11:08:45+00:00

Remove now unused ceph_osdc_unregister_linger_request().

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder

libceph: introduce ceph_osdc_cancel_request()

2014-07-08T11:08:44+00:00

Introduce ceph_osdc_cancel_request() intended for canceling requests
from the higher layers (rbd and cephfs).  Because higher layers are in
charge and are supposed to know what and when they are canceling, the
request is not completed, only unref'ed and removed from the libceph
data structures.

__cancel_request() is no longer called before __unregister_request(),
because __unregister_request() unconditionally revokes r_request and
there is no point in trying to do it twice.

Signed-off-by: Ilya Dryomov 
Reviewed-by: Alex Elder