linux.git/net/can, branch v2.6.29

can: fix slowpath issue in hrtimer callback function

2009-01-15T05:06:55+00:00

Due to the loopback functionality in can_send() we can not invoke it
from hardirq context which was done inside the
bcm_tx_timeout_handler() hrtimer callback:

[  700.361154]  [] warn_slowpath+0x80/0xb6
[  700.361163]  [] valid_state+0x125/0x136
[  700.361171]  [] mark_lock+0x18e/0x332
[  700.361180]  [] __lock_acquire+0x12e/0xb1e
[  700.361189]  [] bcm_tx_timeout_handler+0x0/0xbc [can_bcm]
[  700.361198]  [] dev_queue_xmit+0x191/0x479
[  700.361206]  [] __local_bh_disable+0x2b/0x64
[  700.361213]  [] dev_queue_xmit+0x191/0x479
[  700.361225]  [] can_send+0xd7/0x11a [can]
[  700.361235]  [] bcm_can_tx+0x9d/0xd9 [can_bcm]
[  700.361245]  [] bcm_tx_timeout_handler+0x6a/0xbc [can_bcm]
[  700.361255]  [] bcm_tx_timeout_handler+0x0/0xbc [can_bcm]
[  700.361263]  [] __run_hrtimer+0x5a/0x86
[  700.361273]  [] bcm_tx_timeout_handler+0x0/0xbc [can_bcm]
[  700.361282]  [] hrtimer_interrupt+0xb9/0x110

This patch moves the rest of the functionality from the hrtimer
callback to the already existing tasklet to fix this slowpath problem.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: omit unneeded skb_clone() calls

2009-01-06T19:07:54+00:00

The AF_CAN core delivered always cloned sk_buffs to the AF_CAN
protocols, although this was _only_ needed by the can-raw protocol.
With this (additionally documented) change, the AF_CAN core calls the
callback functions of the registered AF_CAN protocols with the original
(uncloned) sk_buff pointer and let's the can-raw protocol do the
skb_clone() itself which omits all unneeded skb_clone() calls for other
AF_CAN protocols.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: Urs Thuermann 
Signed-off-by: David S. Miller

can: update can-bcm for hrtimer hardirq callbacks

2009-01-05T01:31:18+00:00

Since commit ca109491f612aab5c8152207631c0444f63da97f ("hrtimer:
removing all ur callback modes") the hrtimer callbacks are processed
only in hardirq context.

This patch moves some functionality into tasklets to run in softirq
context.

Additionally some duplicated code was removed in bcm_rx_thr_flush()
and an avoidable memcpy was removed from bcm_rx_handler().

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: merge error paths

2008-12-15T07:16:58+00:00

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

can: omit received RTR frames for single ID filter lists

2008-12-04T23:01:08+00:00

Since commit d253eee20195b25e298bf162a6e72f14bf4803e5 the single CAN
identifier filter lists handle only non-RTR CAN frames.

So we need to omit the check of these filter lists when receiving RTR
CAN frames.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter

2008-12-03T23:52:35+00:00

Due to a wrong safety check in af_can.c it was not possible to filter
for SFF frames with a specific CAN identifier without getting the
same selected CAN identifier from a received EFF frame also.

This fix has a minimum (but user visible) impact on the CAN filter
API and therefore the CAN version is set to a new date.

Indeed the 'old' API is still working as-is. But when now setting
CAN_(EFF|RTR)_FLAG in can_filter.can_mask you might get less traffic
than before - but still the stuff that you expected to get for your
defined filter ...

Thanks to Kurt Van Dijck for pointing at this issue and for the review.

Signed-off-by: Oliver Hartkopp 
Acked-by: Kurt Van Dijck 
Signed-off-by: David S. Miller

net: Remove CONFIG_KMOD from net/ (towards removing CONFIG_KMOD entirely)

2008-10-16T22:24:51+00:00

Some code here depends on CONFIG_KMOD to not try to load
protocol modules or similar, replace by CONFIG_MODULES
where more than just request_module depends on CONFIG_KMOD
and and also use try_then_request_module in ebtables.

Signed-off-by: Johannes Berg 
Signed-off-by: Rusty Russell 
Signed-off-by: David S. Miller

netns: Use net_eq() to compare net-namespaces for optimization.

2008-07-20T05:34:43+00:00

Without CONFIG_NET_NS, namespace is always &init_net.
Compiler will be able to omit namespace comparisons with this patch.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

can: add sanity checks

2008-07-06T06:38:43+00:00

Even though the CAN netlayer only deals with CAN netdevices, the 
netlayer interface to the userspace and to the device layer should 
perform some sanity checks.

This patch adds several sanity checks that mainly prevent userspace apps 
to send broken content into the system that may be misinterpreted by 
some other userspace application.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: Urs Thuermann 
Acked-by: Andre Naujoks 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6

2008-05-09T02:03:26+00:00

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (32 commits)
  net: Added ASSERT_RTNL() to dev_open() and dev_close().
  can: Fix can_send() handling on dev_queue_xmit() failures
  netns: Fix arbitrary net_device-s corruptions on net_ns stop.
  netfilter: Kconfig: default DCCP/SCTP conntrack support to the protocol config values
  netfilter: nf_conntrack_sip: restrict RTP expect flushing on error to last request
  macvlan: Fix memleak on device removal/crash on module removal
  net/ipv4: correct RFC 1122 section reference in comment
  tcp FRTO: SACK variant is errorneously used with NewReno
  e1000e: don't return half-read eeprom on error
  ucc_geth: Don't use RX clock as TX clock.
  cxgb3: Use CAP_SYS_RAWIO for firmware
  pcnet32: delete non NAPI code from driver.
  fs_enet: Fix a memory leak in fs_enet_mdio_probe
  [netdrvr] eexpress: IPv6 fails - multicast problems
  3c59x: use netstats in net_device structure
  3c980-TX needs EXTRA_PREAMBLE
  fix warning in drivers/net/appletalk/cops.c
  e1000e: Add support for BM PHYs on ICH9
  uli526x: fix endianness issues in the setup frame
  uli526x: initialize the hardware prior to requesting interrupts
  ...