linux.git/net/can/raw.c, branch v5.7

can: introduce CAN_REQUIRED_SIZE macro

2019-09-04T11:29:15+00:00

The size of this structure will be increased with J1939 support. To stay
binary compatible, the CAN_REQUIRED_SIZE macro is introduced for
existing CAN protocols.

Signed-off-by: Kurt Van Dijck 
Signed-off-by: Oleksij Rempel 
Acked-by: Oliver Hartkopp 
Signed-off-by: Marc Kleine-Budde

can: raw: raw_sock_no_ioctlcmd(): mark function as static

2019-08-13T15:32:20+00:00

This patch marks the raw_sock_no_ioctlcmd() function as static as it's
only used in this source file.

Fixes: 473d924d7d46 ("can: fix ioctl function removal")
Signed-off-by: Marc Kleine-Budde

can: raw: raw_module_init(): use pr_err() instead of printk(KERN_ERR, ...)

2019-08-13T15:32:20+00:00

This patch converts a printk(KERN_ERR, ...) to a pr_err().

Signed-off-by: Marc Kleine-Budde

can: raw: balance braces around else statements

2019-08-13T15:32:20+00:00

This patch balances the braces around else statements, so that
checkpatch doesn't complain anymore.

Signed-off-by: Marc Kleine-Budde

can: raw: remove unnecessary blank lines, add suggested blank lines

2019-08-13T15:32:20+00:00

This patch removes unnecessary blank lines, and adds suggested ones, so
that checkpatch doesn't complain anymore.

Signed-off-by: Marc Kleine-Budde

can: raw: convert block comments to network style comments

2019-08-13T15:32:20+00:00

This patch converts all block comments to network subsystem style block
comments.

Signed-off-by: Marc Kleine-Budde

can: fix ioctl function removal

2019-07-29T21:12:35+00:00

Commit 60649d4e0af ("can: remove obsolete empty ioctl() handler") replaced the
almost empty can_ioctl() function with sock_no_ioctl() which always returns
-EOPNOTSUPP.

Even though we don't have any ioctl() functions on socket/network layer we need
to return -ENOIOCTLCMD to be able to forward ioctl commands like SIOCGIFINDEX
to the network driver layer.

This patch fixes the wrong return codes in the CAN network layer protocols.

Reported-by: kernel test robot 
Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler")
Signed-off-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

can: Add SPDX license identifiers for CAN subsystem

2019-07-24T08:31:55+00:00

Add missing SPDX identifiers for the CAN network layer and correct the SPDX
license for two of its include files to make sure the BSD-3-Clause applies
for the entire subsystem.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: Marc Kleine-Budde

can: remove obsolete empty ioctl() handler

2019-07-24T08:31:55+00:00

With commit c7cbdbf29f488a ("net: rework SIOCGSTAMP ioctl handling") the only
ioctl function in can_ioctl() has been removed.

As this SIOCGSTAMP ioctl command is now handled in net/socket.c we can entirely
remove the CAN specific ioctl functions.

Signed-off-by: Oliver Hartkopp 
Signed-off-by: Marc Kleine-Budde

net: rework SIOCGSTAMP ioctl handling

2019-04-19T21:07:40+00:00

The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many
socket protocol handlers, and all of those end up calling the same
sock_get_timestamp()/sock_get_timestampns() helper functions, which
results in a lot of duplicate code.

With the introduction of 64-bit time_t on 32-bit architectures, this
gets worse, as we then need four different ioctl commands in each
socket protocol implementation.

To simplify that, let's add a new .gettstamp() operation in
struct proto_ops, and move ioctl implementation into the common
sock_ioctl()/compat_sock_ioctl_trans() functions that these all go
through.

We can reuse the sock_get_timestamp() implementation, but generalize
it so it can deal with both native and compat mode, as well as
timeval and timespec structures.

Acked-by: Stefan Schmidt 
Acked-by: Neil Horman 
Acked-by: Marc Kleine-Budde 
Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2=WDCp82ys8eUT+A@mail.gmail.com/
Signed-off-by: Arnd Bergmann 
Acked-by: Willem de Bruijn 
Signed-off-by: David S. Miller