linux.git/net/caif, branch v3.4-rc2

caif: make zero a legal caif connetion id.

2012-03-11T22:38:16+00:00

Connection ID configured through RTNL must allow zero as
connection id. If connection-id is not given when creating the
interface, configure a loopback interface using ifindex as
connection-id.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Fix for a race in socket transmit with flow control.

2012-03-11T22:38:16+00:00

Kill faulty checks on flow-off leading to connection drop at race conditions.
caif_socket checks for flow-on before transmitting and goes to sleep or
return -EAGAIN upon flow stop. Remove faulty subsequent checks on flow-off
leading to connection drop. Also fix memory leaks on some of the errors paths.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: remove duplicate initialization

2012-02-07T18:39:37+00:00

"priv" is initialized twice.  I kept the second one, because it is next
to the check for NULL.

Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

caif: caifdev is never used in net/caif/caif_dev.c::transmit() - remove it.

2012-02-05T22:53:04+00:00

Signed-off-by: Jesper Juhl 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-02-04T21:39:32+00:00

caif: Add drop count for caif_net device.

2012-02-04T21:06:27+00:00

Count dropped packets in CAIF Netdevice.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Kill debugfs vars for caif socket

2012-02-04T21:06:27+00:00

Kill off the debug-fs exposed varaibles from caif_socket.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Bugfix double kfree_skb upon xmit failure

2012-02-02T19:35:12+00:00

SKB is freed twice upon send error. The Network stack consumes SKB even
when it returns error code.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Bugfix list_del_rcu race in cfmuxl_ctrlcmd.

2012-02-02T19:35:12+00:00

Always use cfmuxl_remove_uplayer when removing a up-layer.
cfmuxl_ctrlcmd() can be called independently and in parallel with
cfmuxl_remove_uplayer(). The race between them could cause list_del_rcu
to be called on a node which has been already taken out from the list.
That lead to a (rare) crash on accessing poisoned node->prev inside
list_del_rcu.

This fix ensures that deletion are done holding the same lock.

Reported-by: Dmitry Tarnyagin 
Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

net caif: Register properly as a pernet subsystem.

2012-01-28T02:06:03+00:00

caif is a subsystem and as such it needs to register with
register_pernet_subsys instead of register_pernet_device.

Among other problems using register_pernet_device was resulting in
net_generic being called before the caif_net structure was allocated.
Which has been causing net_generic to fail with either BUG_ON's or by
return NULL pointers.

A more ugly problem that could be caused is packets in flight why the
subsystem is shutting down.

To remove confusion also remove the cruft cause by inappropriately
trying to fix this bug.

With the aid of the previous patch I have tested this patch and
confirmed that using register_pernet_subsys makes the failure go away as
it should.

Signed-off-by: Eric W. Biederman 
Acked-by: Sjur Brændeland 
Tested-by: Sasha Levin 
Signed-off-by: David S. Miller