linux.git/net/bluetooth/a2mp.c, branch v4.14

networking: make skb_pull & friends return void pointers

2017-06-16T15:48:39+00:00

It seems like a historic accident that these return unsigned char *,
and in many places that means casts are required, more often than not.

Make these functions return void * and remove all the casts across
the tree, adding a (u8 *) cast only where the unsigned char pointer
was used directly, all done with the following spatch:

    @@
    expression SKB, LEN;
    typedef u8;
    identifier fn = {
            skb_pull,
            __skb_pull,
            skb_pull_inline,
            __pskb_pull_tail,
            __pskb_pull,
            pskb_pull
    };
    @@
    - *(fn(SKB, LEN))
    + *(u8 *)fn(SKB, LEN)

    @@
    expression E, SKB, LEN;
    identifier fn = {
            skb_pull,
            __skb_pull,
            skb_pull_inline,
            __pskb_pull_tail,
            __pskb_pull,
            pskb_pull
    };
    type T;
    @@
    - E = ((T *)(fn(SKB, LEN)))
    + E = fn(SKB, LEN)

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

locking/atomic, kref: Add kref_read()

2017-01-14T10:37:18+00:00

Since we need to change the implementation, stop exposing internals.

Provide kref_read() to read the current reference count; typically
used for debug messages.

Kills two anti-patterns:

	atomic_read(&kref->refcount)
	kref->refcount.counter

Signed-off-by: Peter Zijlstra (Intel) 
Cc: Andrew Morton 
Cc: Greg Kroah-Hartman 
Cc: Linus Torvalds 
Cc: Paul E. McKenney 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar

Bluetooth: Move get info completed callback to a2mp.c

2015-07-30T11:37:22+00:00

To avoid a2mp module hooks from hci_event.c and send
getinfo response operation only required by a2mp module,
we can move this callback to a2mp.c

Signed-off-by: Arron Wang 
Signed-off-by: Marcel Holtmann

Bluetooth: Make __next_ident function static.

2015-02-15T08:14:54+00:00

The __next_ident function is a local function and so do not export it
and make it static.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Make a2mp_send function static

2015-02-15T08:14:52+00:00

The a2mp_send function is a local function and so do not export it
and make it static.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Make amp_mgr_lookup_by_state function static

2015-02-15T08:14:51+00:00

The amp_mgr_lookup_by_state function does not need to be exported. So
just move it to a different location and make it static.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Make amp_mgr_list and amp_mgr_list_lock static

2015-02-15T08:14:49+00:00

There is no reason to have amp_mgr_list and amp_mgr_list_lock exported
from a2mp.c and thus make both of them static.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Move A2MP_FEAT_EXT declaration into A2MP source

2015-02-15T08:14:48+00:00

The A2MP_FEAT_EXT declaration has a single user in a2mp.c and thus
just move it there.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

first fruits - kill l2cap ->memcpy_fromiovec()

2014-12-09T21:29:10+00:00

Just use copy_from_iter().  That's what this method is trying to do
in all cases, in a very convoluted fashion.

Signed-off-by: Al Viro

put iov_iter into msghdr

2014-12-09T21:29:03+00:00

Note that the code _using_ ->msg_iter at that point will be very
unhappy with anything other than unshifted iovec-backed iov_iter.
We still need to convert users to proper primitives.

Signed-off-by: Al Viro