linux.git/net/atm, branch v2.6.28 Linux kernel source tree ATM: CVE-2008-5079: duplicate listen() on socket corrupts the vcc table 2008-12-04T22:58:13+00:00 Chas Williams chas@cmf.nrl.navy.mil 2008-12-04T22:58:13+00:00 17b24b3c97498935a2ef9777370b1151dfed3f6f As reported by Hugo Dias that it is possible to cause a local denial of service attack by calling the svc_listen function twice on the same socket and reading /proc/net/atm/*vc Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: David S. Miller <davem@davemloft.net> 
As reported by Hugo Dias that it is possible to cause a local denial
of service attack by calling the svc_listen function twice on the same
socket and reading /proc/net/atm/*vc

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/atm/lec.c: drop code after return 2008-09-23T02:24:45+00:00 Julia Lawall julia@diku.dk 2008-09-23T02:24:45+00:00 5e687220a047dc4f0c2fb9ce886359a23075ddbc The break after the return serves no purpose. Signed-off-by: Julia Lawall <julia@diku.dk> Reviewed-by: Richard Genoud <richard.genoud@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
The break after the return serves no purpose.

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Use hton[sl]() instead of __constant_hton[sl]() where applicable 2008-09-21T05:20:49+00:00 Arnaldo Carvalho de Melo acme@redhat.com 2008-09-21T05:20:49+00:00 6067804047b64dde89f4f133fc7eba48ee44107d Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: fix const assignment/discard warnings in the ATM networking driver 2008-07-30T23:31:46+00:00 David Howells dhowells@redhat.com 2008-07-30T23:31:46+00:00 cba5cbd1559f49bec76e54de6ed21b7df3742ada Fix const assignment/discard warnings in the ATM networking driver. The lane2_assoc_ind() function needed its arguments changing to match changes in the lane2_ops struct (patch 61c33e012964ce358b42d2a1e9cd309af5dab02b "atm: use const where reasonable"). Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Fix const assignment/discard warnings in the ATM networking driver.

The lane2_assoc_ind() function needed its arguments changing to match changes
in the lane2_ops struct (patch 61c33e012964ce358b42d2a1e9cd309af5dab02b
"atm: use const where reasonable").

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
netns: Use net_eq() to compare net-namespaces for optimization. 2008-07-20T05:34:43+00:00 YOSHIFUJI Hideaki yoshfuji@linux-ipv6.org 2008-07-20T05:34:43+00:00 721499e8931c5732202481ae24f2dfbf9910f129 Without CONFIG_NET_NS, namespace is always &init_net. Compiler will be able to omit namespace comparisons with this patch. Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Without CONFIG_NET_NS, namespace is always &init_net.
Compiler will be able to omit namespace comparisons with this patch.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: use const where reasonable 2008-06-17T23:20:06+00:00 Mitchell Blank Jr mitch@sfgoth.com 2008-06-17T23:20:06+00:00 61c33e012964ce358b42d2a1e9cd309af5dab02b From: Mitchell Blank Jr <mitch@sfgoth.com> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: David S. Miller <davem@davemloft.net> 
From: Mitchell Blank Jr <mitch@sfgoth.com>

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: [br2864] fix routed vcmux support 2008-06-17T00:18:18+00:00 Eric Kinzie ekinzie@cmf.nrl.navy.mil 2008-06-17T00:18:18+00:00 7e903c2ae36efb526eacab3b25d00e90424bd8a8 From: Eric Kinzie <ekinzie@cmf.nrl.navy.mil> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: David S. Miller <davem@davemloft.net> 
From: Eric Kinzie <ekinzie@cmf.nrl.navy.mil>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: [br2684] Fix oops due to skb->dev being NULL 2008-06-17T00:15:33+00:00 Jorge Boncompte [DTI2] jorge@dti2.net 2008-06-17T00:15:33+00:00 27141666b69f535a4d63d7bc6d9e84ee5032f82a It happens that if a packet arrives in a VC between the call to open it on the hardware and the call to change the backend to br2684, br2684_regvcc processes the packet and oopses dereferencing skb->dev because it is NULL before the call to br2684_push(). Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil> 
It happens that if a packet arrives in a VC between the call to open it on
the hardware and the call to change the backend to br2684, br2684_regvcc
processes the packet and oopses dereferencing skb->dev because it is
NULL before the call to br2684_push().

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Revert "atm: Do not free already unregistered net device." 2008-05-06T07:00:16+00:00 David S. Miller davem@davemloft.net 2008-05-06T07:00:16+00:00 5f6b1ea41b46bc63f667f9b30d939b49734c20b0 This reverts commit 65e4113684e50cee75357ce10dc9026b0929e4e9. Unlike the other cases Pavel fixed, this case did not setup a netdev->destructor of free_netdev, therefore this change was not correct. Signed-off-by: David S. Miller <davem@davemloft.net> 
This reverts commit 65e4113684e50cee75357ce10dc9026b0929e4e9.

Unlike the other cases Pavel fixed, this case did not
setup a netdev->destructor of free_netdev, therefore this
change was not correct.

Signed-off-by: David S. Miller <davem@davemloft.net>
atm: Bad locking on br2684_devs modifications. 2008-05-05T01:00:36+00:00 Pavel Emelyanov xemul@openvz.org 2008-05-05T01:00:36+00:00 1e0ba0060ffcee2e766ec3159196235b1a2a0ff3 The list_del happens under read-locked devs_lock. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
The list_del happens under read-locked devs_lock.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>