<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/net/9p, branch v2.6.25</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>net/9p/trans_fd.c:p9_trans_fd_init(): module_init functions should return 0 on success</title>
<updated>2008-03-28T21:45:22+00:00</updated>
<author>
<name>Andrew Morton</name>
<email>akpm@linux-foundation.org</email>
</author>
<published>2008-03-28T21:15:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=3387b804d8850494bdf91d16800925a3fd46e37d'/>
<id>3387b804d8850494bdf91d16800925a3fd46e37d</id>
<content type='text'>
Mar 23 09:06:31 opensuse103 kernel: Installing 9P2000 support
Mar 23 09:06:31 opensuse103 kernel: sys_init_module: '9pnet_fd'-&gt;init suspiciously returned 1, it should follow 0/-E convention
Mar 23 09:06:31 opensuse103 kernel: sys_init_module: loading module anyway...
Mar 23 09:06:31 opensuse103 kernel: Pid: 5323, comm: modprobe Not tainted 2.6.25-rc6-git7-default #1
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c013c253&gt;] sys_init_module+0x172b/0x17c9
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c0108a6a&gt;] sys_mmap2+0x62/0x77
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c01059c4&gt;] sysenter_past_esp+0x6d/0xa9
Mar 23 09:06:31 opensuse103 kernel:  =======================

Cc: Latchesar Ionkov &lt;lucho@ionkov.net&gt;
Cc: Eric Van Hensbergen &lt;ericvh@opteron.(none)&gt;
Cc: David S. Miller &lt;davem@davemloft.net&gt;
Cc: "Rafael J. Wysocki" &lt;rjw@sisk.pl&gt;
Cc: &lt;devzero@web.de&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Mar 23 09:06:31 opensuse103 kernel: Installing 9P2000 support
Mar 23 09:06:31 opensuse103 kernel: sys_init_module: '9pnet_fd'-&gt;init suspiciously returned 1, it should follow 0/-E convention
Mar 23 09:06:31 opensuse103 kernel: sys_init_module: loading module anyway...
Mar 23 09:06:31 opensuse103 kernel: Pid: 5323, comm: modprobe Not tainted 2.6.25-rc6-git7-default #1
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c013c253&gt;] sys_init_module+0x172b/0x17c9
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c0108a6a&gt;] sys_mmap2+0x62/0x77
Mar 23 09:06:31 opensuse103 kernel:  [&lt;c01059c4&gt;] sysenter_past_esp+0x6d/0xa9
Mar 23 09:06:31 opensuse103 kernel:  =======================

Cc: Latchesar Ionkov &lt;lucho@ionkov.net&gt;
Cc: Eric Van Hensbergen &lt;ericvh@opteron.(none)&gt;
Cc: David S. Miller &lt;davem@davemloft.net&gt;
Cc: "Rafael J. Wysocki" &lt;rjw@sisk.pl&gt;
Cc: &lt;devzero@web.de&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[9P] net/9p/trans_fd.c: remove unused variable</title>
<updated>2008-03-23T01:05:33+00:00</updated>
<author>
<name>Julia Lawall</name>
<email>julia@diku.dk</email>
</author>
<published>2008-03-23T01:05:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=53a6201fdfa04accc91ea1a7accce8e8bc37ef8e'/>
<id>53a6201fdfa04accc91ea1a7accce8e8bc37ef8e</id>
<content type='text'>
The variable cb is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The variable cb is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>net/9p/trans_virtio.c: kmalloc() enough memory</title>
<updated>2008-02-20T00:25:30+00:00</updated>
<author>
<name>Adrian Bunk</name>
<email>bunk@kernel.org</email>
</author>
<published>2008-02-20T00:25:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=15e29b8b0542f28fc0feed2d60e0377b39a45c4f'/>
<id>15e29b8b0542f28fc0feed2d60e0377b39a45c4f</id>
<content type='text'>
The Coverity checker spotted that less memory than required was
allocated.

Signed-off-by: Adrian Bunk &lt;bunk@kernel.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Coverity checker spotted that less memory than required was
allocated.

Signed-off-by: Adrian Bunk &lt;bunk@kernel.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>net/9p/trans_virtio.c: Use BUG_ON</title>
<updated>2008-02-18T02:42:53+00:00</updated>
<author>
<name>Julia Lawall</name>
<email>julia@diku.dk</email>
</author>
<published>2008-02-18T02:42:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d6584f3a08055688b2344eb26379fb2f3147ce91'/>
<id>d6584f3a08055688b2344eb26379fb2f3147ce91</id>
<content type='text'>
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@ disable unlikely @ expression E,f; @@

(
  if (&lt;... f(...) ...&gt;) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)

@@ expression E,f; @@

(
  if (&lt;... f(...) ...&gt;) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@ disable unlikely @ expression E,f; @@

(
  if (&lt;... f(...) ...&gt;) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)

@@ expression E,f; @@

(
  if (&lt;... f(...) ...&gt;) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>9p: fix p9_printfcall export</title>
<updated>2008-02-07T01:25:01+00:00</updated>
<author>
<name>Andrew Morton</name>
<email>akpm@linux-foundation.org</email>
</author>
<published>2008-02-07T01:25:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=727674435470537a5e75e5f81f96d5d97de57956'/>
<id>727674435470537a5e75e5f81f96d5d97de57956</id>
<content type='text'>
ERROR: "p9_printfcall" [net/9p/9pnet_virtio.ko] undefined!

Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Acked-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ERROR: "p9_printfcall" [net/9p/9pnet_virtio.ko] undefined!

Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Acked-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>9p: transport API reorganization</title>
<updated>2008-02-07T01:25:03+00:00</updated>
<author>
<name>Eric Van Hensbergen</name>
<email>ericvh@opteron.homeip.net</email>
</author>
<published>2008-02-07T01:25:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=8a0dc95fd976a052e5e799ef33e6c8e3141b5dff'/>
<id>8a0dc95fd976a052e5e799ef33e6c8e3141b5dff</id>
<content type='text'>
This merges the mux.c (including the connection interface) with trans_fd
in preparation for transport API changes.  Ultimately, trans_fd will need
to be rewritten to clean it up and simplify the implementation, but this
reorganization is viewed as the first step.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This merges the mux.c (including the connection interface) with trans_fd
in preparation for transport API changes.  Ultimately, trans_fd will need
to be rewritten to clean it up and simplify the implementation, but this
reorganization is viewed as the first step.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>9p: add remove function to trans_virtio</title>
<updated>2008-02-07T01:25:04+00:00</updated>
<author>
<name>Eric Van Hensbergen</name>
<email>ericvh@ericvh-desktop.(none)</email>
</author>
<published>2008-02-07T01:25:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=f39335453fe79f4e12e263e7c6387dc9fb86bfff'/>
<id>f39335453fe79f4e12e263e7c6387dc9fb86bfff</id>
<content type='text'>
Request from rusty:
Just cleaning up patches for 2.6.25 merge, and noticed that
net/9p/trans_virtio.c doesn't have a remove function.  This will crash when
removing the module (console doesn't have one because it can't really be
removed).

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Request from rusty:
Just cleaning up patches for 2.6.25 merge, and noticed that
net/9p/trans_virtio.c doesn't have a remove function.  This will crash when
removing the module (console doesn't have one because it can't really be
removed).

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>9p: Convert semaphore to spinlock for p9_idpool</title>
<updated>2008-02-07T01:25:04+00:00</updated>
<author>
<name>Anthony Liguori</name>
<email>aliguori@us.ibm.com</email>
</author>
<published>2008-02-07T01:25:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=dea7bbb603735ceceb07bb370eca17198faf7c8d'/>
<id>dea7bbb603735ceceb07bb370eca17198faf7c8d</id>
<content type='text'>
When booting from v9fs, down_interruptible in p9_idpool_get() triggered a BUG
as it was being called with IRQs disabled.  A spinlock seems like the right
thing to be using since the idr functions go out of their way not to sleep.

This patch eliminates the BUG by converting the semaphore to a spinlock.

Signed-off-by: Anthony Liguori &lt;aliguori@us.ibm.com&gt;
Acked-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When booting from v9fs, down_interruptible in p9_idpool_get() triggered a BUG
as it was being called with IRQs disabled.  A spinlock seems like the right
thing to be using since the idr functions go out of their way not to sleep.

This patch eliminates the BUG by converting the semaphore to a spinlock.

Signed-off-by: Anthony Liguori &lt;aliguori@us.ibm.com&gt;
Acked-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>9p: Fix soft lockup in virtio transport</title>
<updated>2008-02-07T01:25:07+00:00</updated>
<author>
<name>Eric Van Hensbergen</name>
<email>ericvh@opteron.homeip.net</email>
</author>
<published>2008-02-07T01:25:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=7c7d90f2dda6daec5a6aaf8f97aacc10ee4deb77'/>
<id>7c7d90f2dda6daec5a6aaf8f97aacc10ee4deb77</id>
<content type='text'>
This fixes a poorly placed spinlock which could result in a
soft lockup condition.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes a poorly placed spinlock which could result in a
soft lockup condition.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
<entry>
<title>9p: block-based virtio client</title>
<updated>2008-02-07T01:25:58+00:00</updated>
<author>
<name>Eric Van Hensbergen</name>
<email>ericvh@gmail.com</email>
</author>
<published>2008-02-07T01:25:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=e2735b7720320b68590ca2b32b78ca91213931b2'/>
<id>e2735b7720320b68590ca2b32b78ca91213931b2</id>
<content type='text'>
This replaces the console-based virto client with a block-based
client using a single request queue.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This replaces the console-based virto client with a block-based
client using a single request queue.

Signed-off-by: Eric Van Hensbergen &lt;ericvh@gmail.com&gt;

</pre>
</div>
</content>
</entry>
</feed>
