linux.git/kernel/irq/spurious.c, branch v3.9

genirq: Avoid deadlock in spurious handling

2012-12-11T11:25:30+00:00

commit 52553ddf(genirq: fix regression in irqfixup, irqpoll)
introduced a potential deadlock by calling the action handler with the
irq descriptor lock held.

Remove the call and let the handling code run even for an interrupt
where only a single action is registered. That matches the goal of
the above commit and avoids the deadlock.

Document the confusing action = desc->action reload in the handling
loop while at it.

Reported-and-tested-by: "Wang, Warner" 
Tested-by: Edward Donovan 
Cc: "Wang, Song-Bo (Stoney)" 
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Gleixner

module_param: make bool parameters really bool (core code)

2012-01-12T23:02:18+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Signed-off-by: Rusty Russell

genirq: fix regression in irqfixup, irqpoll

2011-11-28T16:43:09+00:00

Commit fa27271bc8d2("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware configurations.

Amidst reorganizing 'try_one_irq', that patch removed a test that
checked for 'action->handler' returning IRQ_HANDLED, before acting on
the interrupt.  Restoring this test back returns the functionality lost
since 2.6.39.  In the current set of tests, after 'action' is set, it
must precede '!action->next' to take effect.

With this and my previous patch to irq/spurious.c, c75d720fca8a, all
IRQ regressions that I have encountered are fixed.

Signed-off-by: Edward Donovan 
Reported-and-tested-by: Rogério Brito 
Cc: Thomas Gleixner 
Cc: stable@kernel.org (2.6.39+)
Signed-off-by: Linus Torvalds

genirq: Fix irqfixup, irqpoll regression

2011-11-03T12:12:39+00:00

commit d05c65fff0 ("genirq: spurious: Run only one poller at a time")
introduced a regression, leaving the boot options 'irqfixup' and
'irqpoll' non-functional. The patch placed tests in each function, to
exit if the function is already running. The test in 'misrouted_irq'
exited when it should have proceeded, effectively disabling
'misrouted_irq' and 'poll_spurious_irqs'.

The check for an already running poller needs to be "!= 1" not "== 1"
as "1" is the value when the first poller starts running.

Signed-off-by: Edward Donovan 
Cc: maciej.rutecki@gmail.com
Link: http://lkml.kernel.org/r/1320175784-6745-1-git-send-email-edward.donovan@numble.net
Cc: stable@vger.kernel.org # >= 2.6.39
Signed-off-by: Thomas Gleixner

irq: Handle spurios irq detection for threaded irqs

2011-06-03T12:53:15+00:00

The detection of spurios interrupts is currently limited to first level
handler. In force-threaded mode we never notice if the threaded irq does
not feel responsible.
This patch catches the return value of the threaded handler and forwards
it to the spurious detector. If the primary handler returns only
IRQ_WAKE_THREAD then the spourious detector ignores it because it gets
called again from the threaded handler.

[ tglx: Report the erroneous return value early and bail out ]

Signed-off-by: Sebastian Andrzej Siewior 
Link: http://lkml.kernel.org/r/1306824972-27067-2-git-send-email-sebastian@breakpoint.cc
Signed-off-by: Thomas Gleixner

genirq: Print threaded handler in spurious debug output

2011-06-03T12:53:15+00:00

In forced threaded mode (or with an explicit threaded handler) we only
see the primary handler, but not the threaded handler.

Signed-off-by: Sebastian Andrzej Siewior 
Link: http://lkml.kernel.org/r/1306824972-27067-1-git-send-email-sebastian@breakpoint.cc
Signed-off-by: Thomas Gleixner

genirq: Remove compat code

2011-03-29T12:48:19+00:00

Signed-off-by: Thomas Gleixner

genirq: Fix typo and remove unused variable

2011-03-28T18:28:56+00:00

Sigh, I'm overworked.

Signed-off-by: Thomas Gleixner

genirq: Move INPROGRESS, MASKED and DISABLED state flags to irq_data

2011-03-28T14:55:10+00:00

We really need these flags for some of the interrupt chips. Move it
from internal state to irq_data and provide proper accessors.

Signed-off-by: Thomas Gleixner 
Cc: David Daney

genirq: Wrap the remaning IRQ_* flags

2011-02-19T11:58:21+00:00

Use wrappers to keep them away from the core code.

Signed-off-by: Thomas Gleixner