linux.git/kernel/irq/migration.c, branch v2.6.37

genirq: Provide compat handling for chip->set_affinity()

2010-10-04T10:43:46+00:00

Wrap the old chip function set_affinity() until the migration is
complete and the old chip functions are removed.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
LKML-Reference: <20100927121842.732894108@linutronix.de>
Reviewed-by: H. Peter Anvin 
Reviewed-by: Ingo Molnar

genirq: Provide compat handling for chip->unmask()

2010-10-04T10:43:37+00:00

Wrap the old chip function unmask() until the migration is complete
and the old chip functions are removed.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
LKML-Reference: <20100927121842.043608928@linutronix.de>
Reviewed-by: H. Peter Anvin 
Reviewed-by: Ingo Molnar

genirq: Provide compat handling for chip->mask()

2010-10-04T10:43:36+00:00

Wrap the old chip function mask() until the migration is complete and
the old chip functions are removed.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
LKML-Reference: <20100927121841.940355859@linutronix.de>
Reviewed-by: H. Peter Anvin 
Reviewed-by: Ingo Molnar

genirq: Convert core code to irq_data

2010-10-04T10:36:26+00:00

Convert all references in the core code to orq, chip, handler_data,
chip_data, msi_desc, affinity to irq_data.*

Signed-off-by: Thomas Gleixner 
Reviewed-by: Ingo Molnar

genirq: Convert irq_desc.lock to raw_spinlock

2009-12-14T22:55:33+00:00

Convert locks which cannot be sleeping locks in preempt-rt to
raw_spinlocks.

Signed-off-by: Thomas Gleixner 
Acked-by: Peter Zijlstra 
Acked-by: Ingo Molnar

genirq: Delegate irq affinity setting to the irq thread

2009-07-21T12:35:07+00:00

irq_set_thread_affinity() calls set_cpus_allowed_ptr() which might
sleep, but irq_set_thread_affinity() is called with desc->lock held
and can be called from hard interrupt context as well. The code has
another bug as it does not hold a ref on the task struct as required
by set_cpus_allowed_ptr().

Just set the IRQTF_AFFINITY bit in action->thread_flags. The next time
the thread runs it migrates itself. Solves all of the above problems
nicely.

Add kerneldoc to irq_set_thread_affinity() while at it.

Signed-off-by: Thomas Gleixner 
LKML-Reference:

irq: only update affinity if ->set_affinity() is sucessfull

2009-04-28T10:21:16+00:00

irq_set_affinity() and move_masked_irq() try to assign affinity
before calling chip set_affinity(). Some archs are assigning it
in ->set_affinity() again.

We do something like:

 cpumask_cpy(desc->affinity, mask);
 desc->chip->set_affinity(mask);

But in the failure path, affinity should not be touched - otherwise
we'll end up with a different affinity mask despite the failure to
migrate the IRQ.

So try to update the afffinity only if set_affinity returns with 0.
Also call irq_set_thread_affinity accordingly.

v2: update after "irq, x86: Remove IRQ_DISABLED check in process context IRQ move"
v3: according to Ingo, change set_affinity() in irq_chip should return int.
v4: update comments by removing moving irq_desc code.

[ Impact: fix /proc/irq/*/smp_affinity setting corner case bug ]

Signed-off-by: Yinghai Lu 
Cc: Andrew Morton 
Cc: Suresh Siddha 
Cc: "Eric W. Biederman" 
Cc: Rusty Russell 
LKML-Reference: <49F65509.60307@kernel.org>
Signed-off-by: Ingo Molnar

cpumask: update irq_desc to use cpumask_var_t

2009-01-11T18:12:46+00:00

Impact: reduce memory usage, use new cpumask API.

Replace the affinity and pending_masks with cpumask_var_t's.  This adds
to the significant size reduction done with the SPARSE_IRQS changes.

The added functions (init_alloc_desc_masks & init_copy_desc_masks) are
in the include file so they can be inlined (and optimized out for the
!CONFIG_CPUMASKS_OFFSTACK case.)  [Naming chosen to be consistent with
the other init*irq functions, as well as the backwards arg declaration
of "from, to" instead of the more common "to, from" standard.]

Includes a slight change to the declaration of struct irq_desc to embed
the pending_mask within ifdef(CONFIG_SMP) to be consistent with other
references, and some small changes to Xen.

Tested: sparse/non-sparse/cpumask_offstack/non-cpumask_offstack/nonuma/nosmp on x86_64

Signed-off-by: Mike Travis 
Cc: Chris Wright 
Cc: Jeremy Fitzhardinge 
Cc: KOSAKI Motohiro 
Cc: Venkatesh Pallipadi 
Cc: virtualization@lists.osdl.org
Cc: xen-devel@lists.xensource.com
Cc: Yinghai Lu

cpumask: make irq_set_affinity() take a const struct cpumask

2008-12-13T10:50:26+00:00

Impact: change existing irq_chip API

Not much point with gentle transition here: the struct irq_chip's
setaffinity method signature needs to change.

Fortunately, not widely used code, but hits a few architectures.

Note: In irq_select_affinity() I save a temporary in by mangling
irq_desc[irq].affinity directly.  Ingo, does this break anything?

(Folded in fix from KOSAKI Motohiro)

Signed-off-by: Rusty Russell 
Signed-off-by: Mike Travis 
Reviewed-by: Grant Grundler 
Acked-by: Ingo Molnar 
Cc: ralf@linux-mips.org
Cc: grundler@parisc-linux.org
Cc: jeremy@xensource.com
Cc: KOSAKI Motohiro

genirq: keep affinities set from userspace across free/request_irq()

2008-11-09T21:23:49+00:00

Impact: preserve user-modified affinities on interrupts

Kumar Galak noticed that commit
18404756765c713a0be4eb1082920c04822ce588 (genirq: Expose default irq
affinity mask (take 3))

overrides an already set affinity setting across a free /
request_irq(). Happens e.g. with ifdown/ifup of a network device.

Change the logic to mark the affinities as set and keep them
intact. This also fixes the unlocked access to irq_desc in
irq_select_affinity() when called from irq_affinity_proc_write()

Signed-off-by: Thomas Gleixner 
Signed-off-by: Ingo Molnar