linux.git/kernel/irq/generic-chip.c, branch v6.12

genirq/generic_chip: Introduce init() and exit() hooks

2024-06-17T13:48:14+00:00

Most of generic chip drivers need to perform some more additional
initializations on the generic chips allocated before they can be fully
ready.

These additional initializations need to be performed before the IRQ
domain is published to avoid a race condition between IRQ consumers and
suppliers.

Introduce the init() hook to perform these initializations at the right
place just after the generic chip creation. Also introduce the exit() hook
to allow reverting operations done by the init() hook just before the
generic chip is destroyed.

Suggested-by: Thomas Gleixner 
Signed-off-by: Herve Codina 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20240614173232.1184015-15-herve.codina@bootlin.com

genirq/generic_chip: Introduce irq_domain_{alloc,remove}_generic_chips()

2024-06-17T13:48:14+00:00

The existing __irq_alloc_domain_generic_chips() uses a bunch of parameters
to describe the generic chips that need to be allocated.

Adding more parameters and wrappers to hide new parameters in the existing
code leads to more and more code without any relevant values and without
any flexibility.

Introduce irq_domain_alloc_generic_chips() where the generic chips
description is done using the irq_domain_chip_generic_info structure
instead of the bunch of parameters to allow flexibility and easy evolution.

Also introduce irq_domain_remove_generic_chips() to revert the operations
done by irq_domain_alloc_generic_chips().

Suggested-by: Thomas Gleixner 
Signed-off-by: Herve Codina 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20240614173232.1184015-14-herve.codina@bootlin.com

genirq/generic_chip: Make irq_remove_generic_chip() irqdomain aware

2023-10-27T07:15:44+00:00

irq_remove_generic_chip() calculates the Linux interrupt number for removing the
handler and interrupt chip based on gc::irq_base as a linear function of
the bit positions of set bits in the @msk argument.

When the generic chip is present in an irq domain, i.e. created with a call
to irq_alloc_domain_generic_chips(), gc::irq_base contains not the base
Linux interrupt number.  It contains the base hardware interrupt for this
chip. It is set to 0 for the first chip in the domain, 0 + N for the next
chip, where $N is the number of hardware interrupts per chip.

That means the Linux interrupt number cannot be calculated based on
gc::irq_base for irqdomain based chips without a domain map lookup, which
is currently missing.

Rework the code to take the irqdomain case into account and calculate the
Linux interrupt number by a irqdomain lookup of the domain specific
hardware interrupt number.

[ tglx: Massage changelog. Reshuffle the logic and add a proper comment. ]

Fixes: cfefd21e693d ("genirq: Add chip suspend and resume callbacks")
Signed-off-by: Herve Codina 
Signed-off-by: Thomas Gleixner 
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20231024150335.322282-1-herve.codina@bootlin.com

genirq/generic-chip: Fix the irq_chip name for /proc/interrupts

2023-10-13T10:25:31+00:00

irq_init_generic_chip() only sets the name for the first chip type, which
leads to empty names for other chip types.  Eventually, these names will be
shown as "-" /proc/interrupts.

Set the name for all chip types by default.

Signed-off-by: Keguang Zhang 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20230925121734.93017-1-keguang.zhang@gmail.com

genirq/generic_chip: Export irq_unmap_generic_chip

2022-07-20T11:05:55+00:00

Some irq controllers have to re-implement a private version for
irq_generic_chip_ops, because they have a different xlate to translate
hwirq. Export irq_unmap_generic_chip to allow reusing in drivers.

Signed-off-by: Jianmin Lv 
Signed-off-by: Marc Zyngier 
Link: https://lore.kernel.org/r/1658314292-35346-5-git-send-email-lvjianmin@loongson.cn

genirq/generic_chip: Constify irq_generic_chip_ops

2021-11-30T23:15:07+00:00

The only usage of irq_generic_chip_ops is to pass its address to
irq_domain_add_linear() which takes a pointer to const struct
irq_domain_ops. Make it const to allow the compiler to put it in
read-only memory.

[ tglx: Fixed subject prefix ]

Signed-off-by: Rikard Falkeborn 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20211130214043.1257585-1-rikard.falkeborn@gmail.com

genirq: Export irq_gc_noop()

2021-10-20T19:06:33+00:00

In order to build drivers/irqchip/irq-bcm7120-l2.c as a module which
references irq_gc_noop(), we need to export it towards modules.

Signed-off-by: Florian Fainelli 
Signed-off-by: Marc Zyngier 
Link: https://lore.kernel.org/r/20211020184859.2705451-10-f.fainelli@gmail.com

genirq: Export irq_gc_{unmask_enable,mask_disable}_reg

2021-10-20T19:06:33+00:00

In order to allow drivers/irqchip/irq-brcmstb-l2.c to be built as a
module we need to export: irq_gc_unmask_enable_reg() and
irq_gc_mask_disable_reg().

Signed-off-by: Florian Fainelli 
Signed-off-by: Marc Zyngier 
Link: https://lore.kernel.org/r/20211020184859.2705451-8-f.fainelli@gmail.com

genirq/generic_chip: Use struct_size() in kzalloc()

2021-08-10T13:35:20+00:00

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows
that, in the worst scenario, could lead to heap overflows.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/r/20210513212729.GA214145@embeddedor

kernel/irq: export irq_gc_set_wake

2021-03-15T15:36:44+00:00

Module driver may use irq_gc_set_wake.

Signed-off-by: Jianqun Xu 
Acked-by: Marc Zyngier 
Link: https://lore.kernel.org/r/20210305080658.2422114-1-jay.xu@rock-chips.com
Signed-off-by: Linus Walleij