linux.git/kernel/irq/chip.c, branch v2.6.28 Linux kernel source tree genirq: NULL struct irq_desc's member 'name' in dynamic_irq_cleanup() 2008-10-21T13:59:21+00:00 Dean Nelson dcn@sgi.com 2008-10-18T23:06:56+00:00 b6f3b7803a9231eddc36d0a2a6d2d8105ef89344 If the member 'name' of the irq_desc structure happens to point to a character string that is resident within a kernel module, problems ensue if that module is rmmod'd (at which time dynamic_irq_cleanup() is called) and then later show_interrupts() is called by someone. It is also not a good thing if the character string resided in kmalloc'd space that has been kfree'd (after having called dynamic_irq_cleanup()). dynamic_irq_cleanup() fails to NULL the 'name' member and show_interrupts() references it on a few architectures (like h8300, sh and x86). Signed-off-by: Dean Nelson <dcn@sgi.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
If the member 'name' of the irq_desc structure happens to point to a
character string that is resident within a kernel module, problems ensue
if that module is rmmod'd (at which time dynamic_irq_cleanup() is called)
and then later show_interrupts() is called by someone.

It is also not a good thing if the character string resided in kmalloc'd
space that has been kfree'd (after having called dynamic_irq_cleanup()).
dynamic_irq_cleanup() fails to NULL the 'name' member and
show_interrupts() references it on a few architectures (like h8300, sh and
x86).

Signed-off-by: Dean Nelson <dcn@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
genirq: fix set_irq_type() when recording trigger type 2008-10-21T08:10:08+00:00 Chris Friesen cfriesen@nortel.com 2008-10-20T18:41:58+00:00 0b3682ba33c59a362901b478bdab965da888b350 Impact: fix boot hang on a G5 In set_irq_type() we want to pass the type rather than the current interrupt state. Signed-off-by: Chris Friesen <cfriesen@nortel.com> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Acked-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
Impact: fix boot hang on a G5

In set_irq_type() we want to pass the type rather than the current
interrupt state.

Signed-off-by: Chris Friesen <cfriesen@nortel.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
genirq: cleanup the sparseirq modifications 2008-10-16T14:53:29+00:00 Thomas Gleixner tglx@linutronix.de 2008-10-16T07:55:00+00:00 d3c60047bdb03199b93497ac40bd531315d43a86 Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
genirq: revert dynarray 2008-10-16T14:53:15+00:00 Thomas Gleixner tglx@linutronix.de 2008-10-15T13:27:23+00:00 d6c88a507ef0b6afdb013cba4e7804ba7324d99a Revert the dynarray changes. They need more thought and polishing. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Revert the dynarray changes. They need more thought and polishing.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
genirq: remove irq_to_desc_alloc 2008-10-16T14:53:15+00:00 Thomas Gleixner tglx@linutronix.de 2008-10-15T12:34:09+00:00 ee32c9732244bde4b9b59eeac2814c23e2b71f8d Remove the leftover of sparseirqs. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Remove the leftover of sparseirqs.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
irq: set_irq_chip() has redundant call to irq_to_desc() 2008-10-16T14:53:07+00:00 Dean Nelson dcn@sgi.com 2008-09-05T14:10:40+00:00 21056830c4e5c6735f1d49453398d7186ca4e8d7 Extraneous call to irq_to_desc(). Signed-off-by: Dean Nelson <dcn@sgi.com> Cc: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
Extraneous call to irq_to_desc().

Signed-off-by: Dean Nelson <dcn@sgi.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
sparseirq: move kstat_irqs from kstat to irq_desc - fix 2008-10-16T14:53:04+00:00 Yinghai Lu yhlu.kernel@gmail.com 2008-08-25T19:41:19+00:00 8c464a4b23ca283b414022ebc77787f3c7040fa7 fix non-sparseirq architectures. Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
fix non-sparseirq architectures.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
x86_64: rename irq_desc/irq_desc_alloc 2008-10-16T14:52:51+00:00 Yinghai Lu yhlu.kernel@gmail.com 2008-08-20T03:50:17+00:00 cb5bc83225a86ca53bbb889ed8439e4fd6cf44ac change names: irq_desc() ==> irq_desc_alloc __irq_desc() ==> irq_desc Also split a few of the uses in lowlevel x86 code. v2: need to check if desc is null in smp_irq_move_cleanup Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
change names:

          irq_desc() ==> irq_desc_alloc
	__irq_desc() ==> irq_desc

Also split a few of the uses in lowlevel x86 code.

v2: need to check if desc is null in smp_irq_move_cleanup

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
irq: remove >= nr_irqs checking with config_have_sparse_irq 2008-10-16T14:52:50+00:00 Yinghai Lu yhlu.kernel@gmail.com 2008-08-20T03:50:14+00:00 7d94f7ca401dd7f445fda9a971a48aa5427b3e55 remove irq limit checks - nr_irqs is dynamic and we expand anytime. v2: fix checking about result irq_cfg_without_new, so could use msi again v3: use irq_desc_without_new to check irq is valid Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
remove irq limit checks - nr_irqs is dynamic and we expand anytime.

v2: fix checking about result irq_cfg_without_new, so could use msi again
v3: use irq_desc_without_new to check irq is valid

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
x86: move kstat_irqs from kstat to irq_desc 2008-10-16T14:52:32+00:00 Yinghai Lu yhlu.kernel@gmail.com 2008-08-20T03:50:09+00:00 7f95ec9e4c12fd067febfd57532da1166d75d858 based on Eric's patch ... together mold it with dyn_array for irq_desc, will allcate kstat_irqs for nr_irq_desc alltogether if needed. -- at that point nr_cpus is known already. v2: make sure system without generic_hardirqs works they don't have irq_desc v3: fix merging v4: [mingo@elte.hu] fix typo [ mingo@elte.hu ] irq: build fix fix: arch/x86/xen/spinlock.c: In function 'xen_spin_lock_slow': arch/x86/xen/spinlock.c:90: error: 'struct kernel_stat' has no member named 'irqs' Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
based on Eric's patch ...

together mold it with dyn_array for irq_desc, will allcate kstat_irqs for
nr_irq_desc alltogether if needed. -- at that point nr_cpus is known already.

v2: make sure system without generic_hardirqs works they don't have irq_desc
v3: fix merging
v4: [mingo@elte.hu] fix typo

[ mingo@elte.hu ] irq: build fix

fix:

 arch/x86/xen/spinlock.c: In function 'xen_spin_lock_slow':
 arch/x86/xen/spinlock.c:90: error: 'struct kernel_stat' has no member named 'irqs'

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>