linux.git/kernel/audit.c, branch v3.14-rc7

audit: Update kdoc for audit_send_reply and audit_list_rules_send

2014-03-08T23:31:54+00:00

The kbuild test robot reported:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
> head:   6f285b19d09f72e801525f5eea1bdad22e559bf0
> commit: 6f285b19d09f72e801525f5eea1bdad22e559bf0 [2/2] audit: Send replies in the proper network namespace.
> reproduce: make htmldocs
>
> >> Warning(kernel/audit.c:575): No description found for parameter 'request_skb'
> >> Warning(kernel/audit.c:575): Excess function parameter 'portid' description in 'audit_send_reply'
> >> Warning(kernel/auditfilter.c:1074): No description found for parameter 'request_skb'
> >> Warning(kernel/auditfilter.c:1074): Excess function parameter 'portid' description in 'audit_list_rules_s

Which was caused by my failure to update the kdoc annotations when I
updated the functions.  Fix that small oversight now.

Signed-off-by: "Eric W. Biederman"

audit: Send replies in the proper network namespace.

2014-03-01T03:44:55+00:00

In perverse cases of file descriptor passing the current network
namespace of a process and the network namespace of a socket used by
that socket may differ.  Therefore use the network namespace of the
appropiate socket to ensure replies always go to the appropiate
socket.

Signed-off-by: "Eric W. Biederman"

audit: Use struct net not pid_t to remember the network namespce to reply in

2014-02-28T12:04:33+00:00

In struct audit_netlink_list and audit_reply add a reference to the
network namespace of the caller and remove the userspace pid of the
caller.  This cleanly remembers the callers network namespace, and
removes a huge class of races and nasty failure modes that can occur
when attempting to relook up the callers network namespace from a
pid_t (including the caller's network namespace changing, pid
wraparound, and the pid simply not being present).

Signed-off-by: "Eric W. Biederman"

audit: fix location of __net_initdata for audit_net_ops

2014-01-17T22:14:32+00:00

Fixup caught by checkpatch.

Signed-off-by: Richard Guy Briggs 
Signed-off-by: Eric Paris

audit: remove pr_info for every network namespace

2014-01-17T22:04:38+00:00

A message about creating the audit socket might be fine at startup, but
a pr_info for every single network namespace created on a system isn't
useful.

Signed-off-by: Eric Paris

audit: Convert int limit uses to u32

2014-01-14T19:54:00+00:00

The equivalent uapi struct uses __u32 so make the kernel
uses u32 too.

This can prevent some oddities where the limit is
logged/emitted as a negative value.

Convert kstrtol to kstrtouint to disallow negative values.

Signed-off-by: Joe Perches 
[eparis: do not remove static from audit_default declaration]

audit: Use more current logging style

2014-01-14T19:53:54+00:00

Add pr_fmt to prefix "audit: " to output
Convert printk(KERN_ to pr_
Coalesce formats
Use pr_cont
Move a brace after switch

Signed-off-by: Joe Perches

audit: Use hex_byte_pack_upper

2014-01-14T19:53:50+00:00

Using the generic kernel function causes the
object size to increase with gcc 4.8.1.

$ size kernel/audit.o*
   text	   data	    bss	    dec	    hex	filename
  18577	   6079	   8436	  33092	   8144	kernel/audit.o.new
  18579	   6015	   8420	  33014	   80f6	kernel/audit.o.old

Unsigned...

audit: reorder AUDIT_TTY_SET arguments

2014-01-14T03:33:41+00:00

An admin is likely to want to see old and new values next to each other.
Putting all of the old values followed by all of the new values is just
hard to read as a human.

Signed-off-by: Eric Paris

audit: rework AUDIT_TTY_SET to only grab spin_lock once

2014-01-14T03:33:41+00:00

We can simplify the AUDIT_TTY_SET code to only grab the spin_lock one
time.  We need to determine if the new values are valid and if so, set
the new values at the same time we grab the old onces.  While we are
here get rid of 'res' and just use err.

Signed-off-by: Eric Paris