linux.git/kernel/audit.c, branch v3.14-rc2

audit: fix location of __net_initdata for audit_net_ops

2014-01-17T22:14:32+00:00

Fixup caught by checkpatch.

Signed-off-by: Richard Guy Briggs 
Signed-off-by: Eric Paris

audit: remove pr_info for every network namespace

2014-01-17T22:04:38+00:00

A message about creating the audit socket might be fine at startup, but
a pr_info for every single network namespace created on a system isn't
useful.

Signed-off-by: Eric Paris

audit: Convert int limit uses to u32

2014-01-14T19:54:00+00:00

The equivalent uapi struct uses __u32 so make the kernel
uses u32 too.

This can prevent some oddities where the limit is
logged/emitted as a negative value.

Convert kstrtol to kstrtouint to disallow negative values.

Signed-off-by: Joe Perches 
[eparis: do not remove static from audit_default declaration]

audit: Use more current logging style

2014-01-14T19:53:54+00:00

Add pr_fmt to prefix "audit: " to output
Convert printk(KERN_ to pr_
Coalesce formats
Use pr_cont
Move a brace after switch

Signed-off-by: Joe Perches

audit: Use hex_byte_pack_upper

2014-01-14T19:53:50+00:00

Using the generic kernel function causes the
object size to increase with gcc 4.8.1.

$ size kernel/audit.o*
   text	   data	    bss	    dec	    hex	filename
  18577	   6079	   8436	  33092	   8144	kernel/audit.o.new
  18579	   6015	   8420	  33014	   80f6	kernel/audit.o.old

Unsigned...

audit: reorder AUDIT_TTY_SET arguments

2014-01-14T03:33:41+00:00

An admin is likely to want to see old and new values next to each other.
Putting all of the old values followed by all of the new values is just
hard to read as a human.

Signed-off-by: Eric Paris

audit: rework AUDIT_TTY_SET to only grab spin_lock once

2014-01-14T03:33:41+00:00

We can simplify the AUDIT_TTY_SET code to only grab the spin_lock one
time.  We need to determine if the new values are valid and if so, set
the new values at the same time we grab the old onces.  While we are
here get rid of 'res' and just use err.

Signed-off-by: Eric Paris

audit: remove needless switch in AUDIT_SET

2014-01-14T03:33:39+00:00

If userspace specified that it was setting values via the mask we do not
need a second check to see if they also set the version field high
enough to understand those values.  (clearly if they set the mask they
knew those values).

Signed-off-by: Eric Paris

audit: use define's for audit version

2014-01-14T03:33:36+00:00

Give names to the audit versions.  Just something for a userspace
programmer to know what the version provides.

Signed-off-by: Eric Paris

audit: wait_for_auditd rework for readability

2014-01-14T03:33:27+00:00

We had some craziness with signed to unsigned long casting which appears
wholely unnecessary.  Just use signed long.  Even though 2 values of the
math equation are unsigned longs the result is expected to be a signed
long.  So why keep casting the result to signed long?  Just make it
signed long and use it.

We also remove the needless "timeout" variable.  We already have the
stack "sleep_time" variable.  Just use that...

Signed-off-by: Eric Paris