linux.git/ipc, branch v3.14-rc2

ipc: fix compat msgrcv with negative msgtyp

2014-01-28T05:02:40+00:00

Compat function takes msgtyp argument as u32 and passes it down to
do_msgrcv which results in casting to long, thus the sign is lost and we
get a big positive number instead.

Cast the argument to signed type before passing it down.

Signed-off-by: Mateusz Guzik 
Reported-by: Gabriellla Schmidt 
Cc: Al Viro 
Cc: Davidlohr Bueso 
Cc: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc,msg: document barriers

2014-01-28T05:02:40+00:00

Both expunge_all() and pipeline_send() rely on both a nil msg value and
a full barrier to guarantee the correct ordering when waking up a task.

While its counterpart at the receiving end is well documented for the
lockless recv algorithm, we still need to document these specific
smp_mb() calls.

[akpm@linux-foundation.org: fix typo, per Mike]
[akpm@linux-foundation.org: mroe tpyos]
Signed-off-by: Davidlohr Bueso 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Cc: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: delete seq_max field in struct ipc_ids

2014-01-28T05:02:40+00:00

This field is only used to reset the ids seq number if it exceeds the
smaller of INT_MAX/SEQ_MULTIPLIER and USHRT_MAX, and can therefore be
moved out of the structure and into its own macro.  Since each
ipc_namespace contains a table of 3 pointers to struct ipc_ids we can
save space in instruction text:

   text    data     bss     dec     hex filename
  56232    2348      24   58604    e4ec ipc/built-in.o
  56216    2348      24   58588    e4dc ipc/built-in.o-after

Signed-off-by: Davidlohr Bueso 
Reviewed-by: Jonathan Gonzalez 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: simplify sysvipc_proc_open() return

2014-01-28T05:02:40+00:00

Get rid of silly/useless label jumping.

Signed-off-by: Davidlohr Bueso 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: remove useless return statement

2014-01-28T05:02:40+00:00

Only found in ipc_rmid().

Signed-off-by: Davidlohr Bueso 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: remove braces for single statements

2014-01-28T05:02:39+00:00

Deal with checkpatch messages:
     WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Davidlohr Bueso 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: standardize code comments

2014-01-28T05:02:39+00:00

IPC commenting style is all over the place, *specially* in util.c.  This
patch orders things a bit.

Signed-off-by: Davidlohr Bueso 
Cc: Aswin Chandramouleeswaran 
Cc: Rik van Riel 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: whitespace cleanup

2014-01-28T05:02:39+00:00

The ipc code does not adhere the typical linux coding style.
This patch fixes lots of simple whitespace errors.

- mostly autogenerated by
  scripts/checkpatch.pl -f --fix \
	--types=pointer_location,spacing,space_before_tab
- one manual fixup (keep structure members tab-aligned)
- removal of additional space_before_tab that were not found by --fix

Tested with some of my msg and sem test apps.

Andrew: Could you include it in -mm and move it towards Linus' tree?

Signed-off-by: Manfred Spraul 
Suggested-by: Li Bin 
Cc: Joe Perches 
Acked-by: Rafael Aquini 
Cc: Davidlohr Bueso 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: change kern_ipc_perm.deleted type to bool

2014-01-28T05:02:39+00:00

struct kern_ipc_perm.deleted is meant to be used as a boolean toggle, and
the changes introduced by this patch are just to make the case explicit.

Signed-off-by: Rafael Aquini 
Reviewed-by: Rik van Riel 
Cc: Greg Thelen 
Acked-by: Davidlohr Bueso 
Cc: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: introduce ipc_valid_object() helper to sort out IPC_RMID races

2014-01-28T05:02:39+00:00

After the locking semantics for the SysV IPC API got improved, a couple
of IPC_RMID race windows were opened because we ended up dropping the
'kern_ipc_perm.deleted' check performed way down in ipc_lock().  The
spotted races got sorted out by re-introducing the old test within the
racy critical sections.

This patch introduces ipc_valid_object() to consolidate the way we cope
with IPC_RMID races by using the same abstraction across the API
implementation.

Signed-off-by: Rafael Aquini 
Acked-by: Rik van Riel 
Acked-by: Greg Thelen 
Reviewed-by: Davidlohr Bueso 
Cc: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds