linux.git/include/trace/events/sunrpc.h, branch v5.10

SUNRPC: Fix oops in the rpc_xdr_buf event class

2020-11-12T20:56:51+00:00

Backchannel rpc tasks don't have task->tk_client set, so it's necessary
to check it for NULL before dereferencing.

Fixes: c509f15a5801 ("SUNRPC: Split the xdr_buf event class")
Signed-off-by: Scott Mayhew 
Reviewed-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

SUNRPC: Fix general protection fault in trace_rpc_xdr_overflow()

2020-11-05T22:20:12+00:00

The TP_fast_assign() section is careful enough not to dereference
xdr->rqst if it's NULL. The TP_STRUCT__entry section is not.

Fixes: 5582863f450c ("SUNRPC: Add XDR overflow trace event")
Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

SUNRPC: Remove dprintk call sites in RPC queuing functions

2020-09-21T14:21:09+00:00

Remove redundant call sites or call sites that are already covered
by tracepoints.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Clean up RPC scheduler tracepoints

2020-09-21T14:21:09+00:00

Remove several redundant dprintk call sites, and replace a couple of
potentially useful ones with tracepoints.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Replace rpcbind dprintk call sites with tracepoints

2020-09-21T14:21:09+00:00

In many cases, tracepoints already report these errors. In others,
the dprintks were mainly useful when this code was less mature.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Hoist trace_xprtrdma_op_setport into generic code

2020-09-21T14:21:09+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Remove rpcb_getport_async dprintk call sites

2020-09-21T14:21:09+00:00

In many cases, tracepoints already report these errors. In others,
the dprintks were mainly useful when this code was less mature.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Clean up call_bind_status() observability

2020-09-21T14:21:09+00:00

Time to remove dprintk call sites in here.

Regarding the rpc_bind_status tracepoint: It's friendlier to
administrators if they don't have to look up the error code to
figure out what went wrong. Replace trace_rpc_bind_status with a
set of tracepoints that report more specifically what the problem
was, and what RPC program/version was being queried.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Trace call_refresh events

2020-09-21T14:21:09+00:00

Clean up: Replace dprintk call sites.

Note that rpc_call_rpcerror() already has a trace point, so perhaps
adding trace_rpc_refresh_status() isn't necessary. However, it does
report a particular category of error.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Add trace_rpc_timeout_status()

2020-09-21T14:21:09+00:00

For a long while we've wanted a tracepoint that fires when a major
timeout is reported in the system log. Such a tracepoint can be
attached to other actions that can take place when a timeout is
detected (eg, server or connection health assessment).

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker