linux.git/include/target, branch v3.10-rc2

target: removed unused transport_state flag

2013-05-15T08:46:53+00:00

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Remove unused struct members in se_dev_entry

2013-05-03T23:42:18+00:00

Some were incremented, but never used anywhere from what I could tell.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

iscsi-target: Add iscsit_transport API template

2013-04-25T08:05:26+00:00

Add basic struct iscsit_transport API template to allow iscsi-target for
running with external transport modules using existing iscsi_target_core.h
code.

For all external modules, this calls try_module_get() and module_put()
to obtain + release an external iscsit_transport module reference count.

Also include the iscsi-target symbols necessary in iscsi_transport.h to
allow external transport modules to function.

v3 changes:
- Add iscsit_build_reject export for ISTATE_SEND_REJECT usage

v2 changes:

- Drop unnecessary export of iscsit_get_transport + iscsit_put_transport (roland)
- Add ->iscsit_queue_data_in() to remove extra context switch on RDMA_WRITE
- Add ->iscsit_queue_status() to remove extra context switch on IB_SEND status
- Add ->iscsit_get_dataout() to remove extra context switch on RDMA_READ
- Drop ->iscsit_free_cmd()
- Drop ->iscsit_unmap_cmd()
- Rename iscsit_create_transport() -> iscsit_register_transport() (andy)
- Rename iscsit_destroy_transport() -> iscsit_unregister_transport() (andy)

Signed-off-by: Nicholas Bellinger

target: Add export of target_get_sess_cmd symbol

2013-04-25T08:05:26+00:00

Export target_get_sess_cmd() symbol so that it can be used by
iscsi-target.

Signed-off-by: Nicholas Bellinger

target: Add sbc_execute_unmap() helper

2013-04-25T08:05:24+00:00

iblock_execute_unmap() and fd_execute_unmap share a lot of code.
Add sbc_execute_unmap() helper to remove duplicated code for
iblock_execute_unmap() and fd_execute_unmap().

Cc: Christoph Hellwig 
Cc: Martin K. Petersen 
Cc: Nicholas Bellinger 
Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target: Rename spc_get_write_same_sectors -> sbc_get_write_same_sectors

2013-02-23T20:46:14+00:00

Trivial, but WRITE SAME is an SBC command so it seems strange for a
related function (defined in target_core_sbc.c) to be in the spc_
namespace.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Fix error checking for UNMAP commands

2013-02-13T20:16:05+00:00

SBC-3 (revision 35) says:

    The PARAMETER LIST LENGTH field specifies the length in bytes of the
    UNMAP parameter list that is available to be transferred from the
    Data-Out Buffer. If the parameter list length is greater than zero
    and less than 0008h (i.e., eight), then the device server shall
    terminate the command with CHECK CONDITION status with the sense key
    set to ILLEGAL REQUEST and the additional sense code set to
    PARAMETER LIST LENGTH ERROR. A PARAMETER LIST LENGTH set to zero
    specifies that no data shall be sent.

so our sense code for too-short descriptors was wrong, and we were
incorrectly failing commands that didn't transfer any descriptors.

While we're at it, also handle the UNMAP check:

    If the ANCHOR bit is set to one, and the ANC_SUP bit in the Logical
    Block Provisioning VPD page (see 6.6.4) is set to zero, then the
    device server shall terminate the command with CHECK CONDITION
    status with the sense key set to ILLEGAL REQUEST and the additional
    sense code set to INVALID FIELD IN CDB.

(chris boot: Fix wrong cut+paste comment in transport_send_check_condition_and_sense)

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Add device attribute to expose config_item_name for INQUIRY model

2013-02-13T19:27:58+00:00

This patch changes LIO to use the configfs backend device name as the
model if you echo '1' to an individual device's emulate_model_alias attribute.
This is a valid operation only on devices with an export count of 0.

Signed-off-by: Tregaron Bayly 
Signed-off-by: Nicholas Bellinger

target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status

2013-02-13T19:27:51+00:00

This patch allows IBLOCK to check block hints in request_queue->flush_flags
when reporting current backend device WriteCacheEnabled status to a remote
SCSI initiator port.

This is done via a se_subsystem_api->get_write_cache() call instead of a
backend se_device creation time flag, as we expect REQ_FLUSH bits to possibly
change from an underlying blk_queue_flush() by the SCSI disk driver, or
internal raw struct block_device driver usage.

Also go ahead and update iblock_execute_rw() bio I/O path code to use
REQ_FLUSH + REQ_FUA hints when determining WRITE_FUA usage, and make SPC
emulation code use a spc_check_dev_wce() helper to handle both types of
cases for virtual backend subsystem drivers.

(asias: Drop unnecessary comparsion operators)

Reported-by: majianpeng 
Cc: majianpeng 
Cc: Christoph Hellwig 
Cc: Jens Axboe 
Cc: James Bottomley 
Signed-off-by: Nicholas Bellinger

target: change sprintf to snprintf in transport_dump_vpd_ident

2013-02-13T19:27:31+00:00

"buf" is 128 characters and "vpd->device_identifier" is 256.  It makes
the static checkers complain.

Also bump VPD_TMP_BUF_SIZE to match INQUIRY_VPD_DEVICE_IDENTIFIER_LEN.

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger