linux.git/include/sound/compress_driver.h, branch v5.8

ALSA: compress: fix partial_drain completion state

2020-07-07T09:52:18+00:00

On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
state, so set that for partially draining streams in
snd_compr_drain_notify() and use a flag for partially draining streams

While at it, add locks for stream state change in
snd_compr_drain_notify() as well.

Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)")
Reviewed-by: Srinivas Kandagatla 
Tested-by: Srinivas Kandagatla 
Reviewed-by: Charles Keepax 
Tested-by: Charles Keepax 
Signed-off-by: Vinod Koul 
Link: https://lore.kernel.org/r/20200629134737.105993-4-vkoul@kernel.org
Signed-off-by: Takashi Iwai

ALSA: core: Implement compress page allocation and free routines

2020-02-18T21:52:05+00:00

Add simple malloc and free methods for memory management for compress
streams. Based on snd_pcm_lib_malloc_pages and snd_pcm_lib_free_pages
implementation.

Signed-off-by: Divya Prakash 
Signed-off-by: Cezary Rojewski 
Reviewed-by: Takashi Iwai 
Acked-by: Vinod Koul 
Acked-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20200218143924.10565-3-cezary.rojewski@intel.com
Signed-off-by: Mark Brown

ALSA: core: Expand DMA buffer information

2020-02-18T21:52:04+00:00

Update DMA buffer definition for snd_compr_runtime so it is represented
similarly as in snd_pcm_runtime. While at it, modify
snd_compr_set_runtime_buffer to account for newly added members.

Signed-off-by: Cezary Rojewski 
Reviewed-by: Takashi Iwai 
Acked-by: Vinod Koul 
Acked-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20200218143924.10565-2-cezary.rojewski@intel.com
Signed-off-by: Mark Brown

ALSA: compress: Fix regression on compressed capture streams

2019-07-23T10:07:22+00:00

A previous fix to the stop handling on compressed capture streams causes
some knock on issues. The previous fix updated snd_compr_drain_notify to
set the state back to PREPARED for capture streams. This causes some
issues however as the handling for snd_compr_poll differs between the
two states and some user-space applications were relying on the poll
failing after the stream had been stopped.

To correct this regression whilst still fixing the original problem the
patch was addressing, update the capture handling to skip the PREPARED
state rather than skipping the SETUP state as it has done until now.

Fixes: 4f2ab5e1d13d ("ALSA: compress: Fix stop handling on compressed capture streams")
Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Fix stop handling on compressed capture streams

2019-02-05T21:01:41+00:00

It is normal user behaviour to start, stop, then start a stream
again without closing it. Currently this works for compressed
playback streams but not capture ones.

The states on a compressed capture stream go directly from OPEN to
PREPARED, unlike a playback stream which moves to SETUP and waits
for a write of data before moving to PREPARED. Currently however,
when a stop is sent the state is set to SETUP for both types of
streams. This leaves a capture stream in the situation where a new
start can't be sent as that requires the state to be PREPARED and
a new set_params can't be sent as that requires the state to be
OPEN. The only option being to close the stream, and then reopen.

Correct this issues by allowing snd_compr_drain_notify to set the
state depending on the stream direction, as we already do in
set_params.

Fixes: 49bb6402f1aa ("ALSA: compress_core: Add support for capture streams")
Signed-off-by: Charles Keepax 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()

2018-12-14T12:43:41+00:00

Existing compress offload code allocates data buffers using simple kmalloc,
however there are situations where these buffers have to be mapped
in smmu. So provide a way to set the runtime buffer by the driver itself,
simillar to what we do with pcm.

This patch adds support to set runtime dma buffer on compressed stream.

Signed-off-by: Srinivas Kandagatla 
Acked-by: Vinod Koul 
Signed-off-by: Mark Brown

ASoC: soc-compress: convert to SPDX identifiers

2018-07-02T09:55:47+00:00

Signed-off-by: Kuninori Morimoto 
Signed-off-by: Mark Brown

ALSA: compress: Fix kernel-doc warnings

2016-11-15T06:28:15+00:00

Some fields in struct snd_compr have no corresponding comments, and
the kernel-doc complains like:

  ./include/sound/compress_driver.h:162: warning: No description found for parameter 'id[64]'
  ./include/sound/compress_driver.h:162: warning: No description found for parameter 'proc_root'
  ./include/sound/compress_driver.h:162: warning: No description found for parameter 'proc_info_entry'

Actually all these are internal elements, just put "private:" comment
so that they will be ignored.

Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Add function to indicate the stream has gone bad

2016-06-13T15:45:37+00:00

Currently, the avail IOCTL doesn't pass any error status, which
means typically on error it simply shows no data available. This
can lead to situations where user-space is waiting indefinitely
for data that will never come as the DSP has suffered an
unrecoverable error.

Add snd_compr_stop_error which end drivers can call to indicate
the stream has suffered an unrecoverable error and stop it. The
avail and poll IOCTLs are then updated to report if the stream is
in an error state to user-space. Allowing the error to propagate
out. Processing of the actual snd_compr_stop needs to be deferred
to a worker thread as the end driver may detect the errors during
an existing operation callback.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Mark Brown

ALSA: compress: Pass id string to snd_compress_new

2015-11-30T10:44:59+00:00

Make snd_compress_new take an id string (like snd_pcm_new).
This string can be included in the procfs info.

This patch also updates soc_new_compress() to create an ID
based on the stream and dai name, as done for PCM streams.

Signed-off-by: Richard Fitzgerald 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai