linux.git/include/net/act_api.h, branch v5.1-rc2

net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-10T17:28:43+00:00

Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For
example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with
TCA_ID_POLICE and also differentiates these identifier, used in struct
tc_action_ops type field, from other macros starting with TCA_ACT_.

To make things clearer, we name the enum defining the TCA_ID_*
identifiers and also change the "type" field of struct tc_action to
id.

Signed-off-by: Eli Cohen 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net/sched: Remove egdev mechanism

2018-12-10T23:54:34+00:00

The egdev mechanism was replaced by the TC indirect block notifications
platform.

Signed-off-by: Oz Shlomo 
Reviewed-by: Eli Britstein 
Reviewed-by: Jiri Pirko 
Cc: John Hurley 
Cc: Jakub Kicinski 
Signed-off-by: Saeed Mahameed

net_sched: convert idrinfo->lock from spinlock to a mutex

2018-10-05T07:36:31+00:00

In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take idrinfo->lock")
we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking
with the spinlock held. Unfortunately, this causes a lot of
troubles here:

1. tcf_chain_destroy() could be called right after we queue the work
   but before the work runs. This is a use-after-free.

2. The chain refcnt is already 0, we can't even just hold it again.
   We can check refcnt==1 but it is ugly.

3. The chain with refcnt 0 is still visible in its block, which means
   it could be still found and used!

4. The block has a refcnt too, we can't hold it without introducing a
   proper API either.

We can make it working but the end result is ugly. Instead of wasting
time on reviewing it, let's just convert the troubling spinlock to
a mutex, which allows us to use non-atomic allocations too.

Fixes: ec3ed293e766 ("net_sched: change tcf_del_walker() to take idrinfo->lock")
Reported-by: Ido Schimmel 
Cc: Jamal Hadi Salim 
Cc: Vlad Buslov 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Tested-by: Ido Schimmel 
Signed-off-by: David S. Miller

net/sched: Add hardware specific counters to TC actions

2018-09-24T19:18:42+00:00

Add additional counters that will store the bytes/packets processed by
hardware. These will be exported through the netlink interface for
displaying by the iproute2 tc tool

Signed-off-by: Eelco Chaudron 
Signed-off-by: David S. Miller

Revert "net: sched: act: add extack for lookup callback"

2018-09-01T05:50:15+00:00

This reverts commit 331a9295de23 ("net: sched: act: add extack for lookup callback").

This extack is never used after 6 months... In fact, it can be just
set in the caller, right after ->lookup().

Cc: Alexander Aring 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: remove unused tcfa_capab

2018-08-21T19:45:45+00:00

Cc: Jamal Hadi Salim 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: remove list_head from tc_action

2018-08-21T19:45:44+00:00

After commit 90b73b77d08e, list_head is no longer needed.
Now we just need to convert the list iteration to array
iteration for drivers.

Fixes: 90b73b77d08e ("net: sched: change action API to use array of pointers to actions")
Cc: Jiri Pirko 
Cc: Vlad Buslov 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: remove unused tcf_idr_check()

2018-08-21T19:45:44+00:00

tcf_idr_check() is replaced by tcf_idr_check_alloc(),
and __tcf_idr_check() now can be folded into tcf_idr_search().

Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
Cc: Jiri Pirko 
Cc: Vlad Buslov 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: remove unnecessary ops->delete()

2018-08-21T19:45:44+00:00

All ops->delete() wants is getting the tn->idrinfo, but we already
have tc_action before calling ops->delete(), and tc_action has
a pointer ->idrinfo.

More importantly, each type of action does the same thing, that is,
just calling tcf_idr_delete_index().

So it can be just removed.

Fixes: b409074e6693 ("net: sched: add 'delete' function to action ops")
Cc: Jiri Pirko 
Cc: Vlad Buslov 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: sched: extend action ops with put_dev callback

2018-08-11T19:37:10+00:00

As a preparation for removing dependency on rtnl lock from rules update
path, all users of shared objects must take reference while working with
them.

Extend action ops with put_dev() API to be used on net device returned by
get_dev().

Modify mirred action (only action that implements get_dev callback):
- Take reference to net device in get_dev.
- Implement put_dev API that releases reference to net device.

Signed-off-by: Vlad Buslov 
Signed-off-by: David S. Miller